Macrobenchmark startActivityAndWait() doesn't work on Android 29+ when Activity uses SplashScreen.setKeepOnScreenCondition() [244594339]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Sep 2, 2022 09:03AM

Component used: androidx.benchmark:benchmark-macro-junit4
Version used:1.1.0
Devices/Android versions reproduced on: Pixel 2Xl Android 11(30)

* Project uses androidx.core:core-splashscreen:1.0.0 library and method setKeepOnScreenCondition(condition: KeepOnScreenCondition) -> it takes some time to remove splash screen
* on Android 29+ lastLaunchNs is null because splashscreen delays view drawing and
```
.any {
val lastFrameTimestampNs = if (Build.VERSION.SDK_INT >= 29) {
it.lastLaunchNs
} else {
it.lastFrameNs
} ?: Long.MIN_VALUE
```
returns Long.MIN_VALUE and I'm getting
```
throw IllegalStateException("Unable to confirm activity launch completion $lastFrameStats" +
" Please report a bug with the output of" +
" `adb shell dumpsys gfxinfo $packageName framestats`")
```

Could you help me?

Comments

cc...@google.com <cc...@google.com> #2Sep 2, 2022 07:57PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

[Deleted User] <[Deleted User]> #3Sep 5, 2022 07:01AM

Hi,

Yeah trace in attachment.

macrobenchmark.perfetto-trace

14 MB

Download

cc...@google.com <cc...@google.com> #4Sep 6, 2022 06:33PM

Thanks, that verifies that the trace and app behavior all looks fine (see attached). Unfortunately that means the workaround wouldn't help.

Can you:

run "adb shell dumpsys gfxinfo com.stackin.android framestats"
launch your app to this screen (manually is fine)
run "adb shell dumpsys gfxinfo com.stackin.android framestats"

And attach the results from the two dumps?

It may be that we can't trust the launch bit to be set in the framestats output when using the frame cancellation like splashscreen uses. You could see if measurements work on an API 28 device, which would be one way to confirm thats the problem, and workaround.

Tue Sep 06 2022 11:32:33 GMT-0700 (Pacific Daylight Time).png

150 KB

View

Download

[Deleted User] <[Deleted User]> #5Sep 7, 2022 12:59PM

Framestats attached :) I don't have physical device with API 28. I've checked generating baseline profile on emulator with API 28 and it worked :)

Applications Graphics Acceleration Info:.pdf

32 KB

View

Download

ap...@google.com <ap...@google.com> #6Sep 9, 2022 08:55PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 597e8b0ade2b28bd01657b806307c6838dea54e7
Author: Chris Craik <ccraik@google.com>
Date: Thu Sep 08 16:51:06 2022

Remove check for launch flag for launch confirmation

Fixes: 244594339
Fixes: 228946895
Test: ./gradlew bench:b-m:cC

Relnote: "Fix bug where startActivityAndWait would timeout trying to
wait forlaunch completion on emulators by reducing strictness of frame
detection."

Change-Id: Ibe2c6c5519973f5c3311f4abb02e21c66a77bd2e

M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/FrameStatsResult.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MacrobenchmarkScope.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/FrameStatsResultTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MacrobenchmarkScopeTest.kt

https://android-review.googlesource.com/2212663

na...@google.com <na...@google.com> #7Sep 21, 2022 05:54PM

This bug was linked in a change in the following release(s):

androidx.benchmark:benchmark-macro:1.2.0-alpha04

Issue 244594339

Description

Issue summary

Comments

cc...@google.com <cc...@google.com> #2Sep 2, 2022 07:57PM

[Deleted User] <[Deleted User]> #3Sep 5, 2022 07:01AM

cc...@google.com <cc...@google.com> #4Sep 6, 2022 06:33PM

[Deleted User] <[Deleted User]> #5Sep 7, 2022 12:59PM

ap...@google.com <ap...@google.com> #6Sep 9, 2022 08:55PM

na...@google.com <na...@google.com> #7Sep 21, 2022 05:54PM

Add comment

Issue metadata