Unexpected attempt to determine if non-CF code needs desugaring [244970402]

Verified

Bug

Status Update

No update yet.

Description

do...@gmail.com

created issue #1

Sep 5, 2022 12:03PM

build env:

minSdkVersion 15
targetSdkVersion 27
compileSdkVersion android-31
buildToolsVersion 31.0.0
multiDexEnabled true
multiDexKeepProguard file('multidex.pro')
gradle7.5.1
agp > 7.2.2

It's ok in agp7.2.2, but failed in higher agp versions.

reproduce step

unzip desugar.zip
cd desugar
chmod +x gradlew
./gradlew :app:minifyReleaseWithR8 '-PAGP_VERSION=7.2.2' -S
./gradlew :app:minifyReleaseWithR8 '-PAGP_VERSION=7.3.0-beta04' -S
./gradlew :app:minifyReleaseWithR8 '-PAGP_VERSION=7.4.0-alpha07' -S

agp7.3.0-beta04

Caused by: com.android.tools.r8.CompilationFailedException: Compilation failed to complete
        at Version.fakeStackEntry(Version_3.3.54.java:0)
        at com.android.tools.r8.internal.Cj.a(R8_3.3.54_cfe1afa66b059d6edd95b633d0a3cbee37aa37d6fc6f14ad0e01c6219b6bd342:75)
        at com.android.tools.r8.internal.Cj.a(R8_3.3.54_cfe1afa66b059d6edd95b633d0a3cbee37aa37d6fc6f14ad0e01c6219b6bd342:28)
        at com.android.tools.r8.internal.Cj.a(R8_3.3.54_cfe1afa66b059d6edd95b633d0a3cbee37aa37d6fc6f14ad0e01c6219b6bd342:27)
        at com.android.tools.r8.R8.a(R8_3.3.54_cfe1afa66b059d6edd95b633d0a3cbee37aa37d6fc6f14ad0e01c6219b6bd342:25)
        at com.android.tools.r8.R8.run(R8_3.3.54_cfe1afa66b059d6edd95b633d0a3cbee37aa37d6fc6f14ad0e01c6219b6bd342:3)
        at com.android.builder.dexing.R8Tool.runR8(r8Tool.kt:306)
        at com.android.build.gradle.internal.tasks.R8Task$Companion.shrink(R8Task.kt:620)
        at com.android.build.gradle.internal.tasks.R8Task$R8Runnable.run(R8Task.kt:690)
Caused by: com.android.tools.r8.internal.f20: Unexpected attempt to determine if non-CF code needs desugaring
        at com.android.tools.r8.internal.gI.a(R8_3.3.54_cfe1afa66b059d6edd95b633d0a3cbee37aa37d6fc6f14ad0e01c6219b6bd342:193)
        at com.android.tools.r8.shaking.t.a(R8_3.3.54_cfe1afa66b059d6edd95b633d0a3cbee37aa37d6fc6f14ad0e01c6219b6bd342:16324)
        at com.android.tools.r8.shaking.I.a(R8_3.3.54_cfe1afa66b059d6edd95b633d0a3cbee37aa37d6fc6f14ad0e01c6219b6bd342:1)
        at com.android.tools.r8.shaking.t.a(R8_3.3.54_cfe1afa66b059d6edd95b633d0a3cbee37aa37d6fc6f14ad0e01c6219b6bd342:16160)
        at com.android.tools.r8.shaking.t.a(R8_3.3.54_cfe1afa66b059d6edd95b633d0a3cbee37aa37d6fc6f14ad0e01c6219b6bd342:7496)
        at com.android.tools.r8.R8.a(R8_3.3.54_cfe1afa66b059d6edd95b633d0a3cbee37aa37d6fc6f14ad0e01c6219b6bd342:2150)
        at com.android.tools.r8.R8.a(R8_3.3.54_cfe1afa66b059d6edd95b633d0a3cbee37aa37d6fc6f14ad0e01c6219b6bd342:1028)
        at com.android.tools.r8.R8.b(R8_3.3.54_cfe1afa66b059d6edd95b633d0a3cbee37aa37d6fc6f14ad0e01c6219b6bd342:1)
        at com.android.tools.r8.internal.Cj.a(R8_3.3.54_cfe1afa66b059d6edd95b633d0a3cbee37aa37d6fc6f14ad0e01c6219b6bd342:24)

agp7.4.0-alpha07

Caused by: com.android.tools.r8.CompilationFailedException: Compilation failed to complete
        at Version.fakeStackEntry(Version_4.0.12-dev.java:0)
        at com.android.tools.r8.internal.ik.a(R8_4.0.12-dev_9a221d2612df14983421c09987287416a6e5653055b6f1521a87c42cc884c9b8:75)
        at com.android.tools.r8.internal.ik.a(R8_4.0.12-dev_9a221d2612df14983421c09987287416a6e5653055b6f1521a87c42cc884c9b8:28)
        at com.android.tools.r8.internal.ik.a(R8_4.0.12-dev_9a221d2612df14983421c09987287416a6e5653055b6f1521a87c42cc884c9b8:27)
        at com.android.tools.r8.R8.a(R8_4.0.12-dev_9a221d2612df14983421c09987287416a6e5653055b6f1521a87c42cc884c9b8:25)
        at com.android.tools.r8.R8.run(R8_4.0.12-dev_9a221d2612df14983421c09987287416a6e5653055b6f1521a87c42cc884c9b8:3)
        at com.android.builder.dexing.R8Tool.runR8(r8Tool.kt:303)
        at com.android.build.gradle.internal.tasks.R8Task$Companion.shrink(R8Task.kt:624)
        at com.android.build.gradle.internal.tasks.R8Task$R8Runnable.run(R8Task.kt:694)
Caused by: com.android.tools.r8.internal.c40: Unexpected attempt to determine if non-CF code needs desugaring
        at com.android.tools.r8.internal.IJ.a(R8_4.0.12-dev_9a221d2612df14983421c09987287416a6e5653055b6f1521a87c42cc884c9b8:194)
        at com.android.tools.r8.shaking.z.a(R8_4.0.12-dev_9a221d2612df14983421c09987287416a6e5653055b6f1521a87c42cc884c9b8:16965)
        at com.android.tools.r8.shaking.P.a(R8_4.0.12-dev_9a221d2612df14983421c09987287416a6e5653055b6f1521a87c42cc884c9b8:1)
        at com.android.tools.r8.shaking.z.a(R8_4.0.12-dev_9a221d2612df14983421c09987287416a6e5653055b6f1521a87c42cc884c9b8:16790)
        at com.android.tools.r8.shaking.z.a(R8_4.0.12-dev_9a221d2612df14983421c09987287416a6e5653055b6f1521a87c42cc884c9b8:7804)
        at com.android.tools.r8.R8.a(R8_4.0.12-dev_9a221d2612df14983421c09987287416a6e5653055b6f1521a87c42cc884c9b8:2145)
        at com.android.tools.r8.R8.a(R8_4.0.12-dev_9a221d2612df14983421c09987287416a6e5653055b6f1521a87c42cc884c9b8:1020)
        at com.android.tools.r8.R8.b(R8_4.0.12-dev_9a221d2612df14983421c09987287416a6e5653055b6f1521a87c42cc884c9b8:1)
        at com.android.tools.r8.internal.ik.a(R8_4.0.12-dev_9a221d2612df14983421c09987287416a6e5653055b6f1521a87c42cc884c9b8:24)

agp7.2.2 with r8 main branch commit a772a4c8a518d46b9cbf8fbba43a8e88eb16e15d

Caused by: com.android.tools.r8.CompilationFailedException: Compilation failed to complete
        at Version.fakeStackEntry(Version_main.java:0)
        at com.android.tools.r8.utils.ExceptionUtils.failWithFakeEntry(ExceptionUtils.java:139)
        at com.android.tools.r8.utils.ExceptionUtils.failCompilation(ExceptionUtils.java:89)
        at com.android.tools.r8.utils.ExceptionUtils.withCompilationHandler(ExceptionUtils.java:83)
        at com.android.tools.r8.utils.ExceptionUtils.withR8CompilationHandler(ExceptionUtils.java:69)
        at com.android.tools.r8.R8.runForTesting(R8.java:229)
        at com.android.tools.r8.R8.run(R8.java:185)
        at com.android.builder.dexing.R8Tool.runR8(r8Tool.kt:301)
        at com.android.build.gradle.internal.tasks.R8Task$Companion.shrink(R8Task.kt:592)
        at com.android.build.gradle.internal.tasks.R8Task.doTaskAction(R8Task.kt:443)
Caused by: com.android.tools.r8.errors.Unreachable: Unexpected attempt to determine if non-CF code needs desugaring
        at com.android.tools.r8.ir.desugar.NonEmptyCfInstructionDesugaringCollection.needsDesugaring(NonEmptyCfInstructionDesugaringCollection.java:337)
        at com.android.tools.r8.shaking.Enqueuer.addToPendingDesugaring(Enqueuer.java:3983)
        at com.android.tools.r8.shaking.Enqueuer.traceNonDesugaredCode(Enqueuer.java:4776)
        at com.android.tools.r8.shaking.Enqueuer.markMethodAsLive(Enqueuer.java:4720)
        at com.android.tools.r8.shaking.EnqueuerWorklist$MarkMethodLiveAction.run(EnqueuerWorklist.java:166)
        at com.android.tools.r8.shaking.Enqueuer.trace(Enqueuer.java:4373)
        at com.android.tools.r8.shaking.Enqueuer.traceApplication(Enqueuer.java:3601)
        at com.android.tools.r8.R8.runEnqueuer(R8.java:1002)
        at com.android.tools.r8.R8.run(R8.java:359)
        at com.android.tools.r8.R8.run(R8.java:242)
        at com.android.tools.r8.R8.lambda$runForTesting$1(R8.java:233)
        at com.android.tools.r8.utils.ExceptionUtils.withCompilationHandler(ExceptionUtils.java:80)

desugar.zip

63 KB

Download

Comments

ze...@google.com <ze...@google.com> Sep 5, 2022 01:07PM

Reassigned to ze...@google.com.

ze...@google.com <ze...@google.com> #2Sep 5, 2022 02:17PM

Fixed in r1313.

ap...@google.com <ap...@google.com> #3Sep 5, 2022 02:19PM

[Empty comment from Monorail migration]

ap...@google.com <ap...@google.com> #4Sep 6, 2022 05:39AM

[Empty comment from Monorail migration]

ap...@google.com <ap...@google.com> #5Sep 6, 2022 07:52AM

This issue was migrated from

crbug.com/nativeclient/245?no_tracker_redirect=1

[Monorail components: TrustedRT]

ap...@google.com <ap...@google.com> #6Sep 6, 2022 07:52AM

Project: r8
Branch: 4.0

commit 98f97fe3a84b90b53f1c1b918d567768f4349e14
Author: Ian Zerny <zerny@google.com>
Date: Tue Sep 06 09:45:28 2022

Don't desugar interface methods when building main-dex root set.

Bug:

b/244970402

Change-Id: I9a4557137a57a9a347d40611d153a4546ccb9004

M src/test/java/com/android/tools/r8/desugar/staticinterfacemethod/RegressionB244970402.java
M src/main/java/com/android/tools/r8/shaking/RootSetUtils.java

https://r8-review.googlesource.com/71228

ap...@google.com <ap...@google.com> #7Sep 6, 2022 07:52AM

Project: r8
Branch: 4.0

commit 265c7674c7ca8342ae05175fe122db6ec764ad82
Author: Ian Zerny <zerny@google.com>
Date: Tue Sep 06 09:45:16 2022

Regression test for issue with desugaring and main-dex rules.

Bug:

b/244970402

Change-Id: I4d30e5b54f38d66465a93abeb87a123e9ce2fe47

A src/test/java/com/android/tools/r8/desugar/staticinterfacemethod/RegressionB244970402.java

https://r8-review.googlesource.com/71227

ap...@google.com <ap...@google.com> #8Sep 6, 2022 07:52AM

Project: r8
Branch: 3.3

commit 0d29f02764025b6fb7096fcd8a05534f2aceb52c
Author: Ian Zerny <zerny@google.com>
Date: Tue Sep 06 08:41:52 2022

Version 3.3.76

Bug:

b/244970402

Change-Id: Ic2b214911042572d961a039748b474aeb23ee70e

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/71226

ap...@google.com <ap...@google.com> #9Sep 6, 2022 07:52AM

Project: r8
Branch: 3.3

commit e19f363a9633d365386a02db9fe820185728d939
Author: Ian Zerny <zerny@google.com>
Date: Tue Sep 06 08:28:45 2022

Don't desugar interface methods when building main-dex root set.

Bug:

b/244970402

https://r8-review.googlesource.com/71225

ap...@google.com <ap...@google.com> #10Sep 6, 2022 07:52AM

Project: r8
Branch: 3.3

commit 31098d7c62256f1613b209e5bd6b6d54ff28e60d
Author: Ian Zerny <zerny@google.com>
Date: Tue Sep 06 08:28:34 2022

Regression test for issue with desugaring and main-dex rules.

Bug:

b/244970402

Change-Id: I4d30e5b54f38d66465a93abeb87a123e9ce2fe47

A src/test/java/com/android/tools/r8/desugar/staticinterfacemethod/RegressionB244970402.java

https://r8-review.googlesource.com/71224

ap...@google.com <ap...@google.com> #11Sep 6, 2022 07:53AM

b/244970402

https://r8-review.googlesource.com/71228

ap...@google.com <ap...@google.com> #12Sep 6, 2022 07:53AM

b/244970402

Change-Id: I4d30e5b54f38d66465a93abeb87a123e9ce2fe47

A src/test/java/com/android/tools/r8/desugar/staticinterfacemethod/RegressionB244970402.java

https://r8-review.googlesource.com/71227

ze...@google.com <ze...@google.com> #13Sep 6, 2022 08:10AM

Verified by ze...@google.com.

A fix for this is now on our 3.3 (AGP 7.3) and 4.0 (AG{ 7.4) branches. You can use the new R8 by updating your settings.gradle or settings.gradle.kts with the following where <R8VERSION> is replaced by 3.3.76 or 4.0.25.

Thanks again for reporting the issue and let us know if works for you.

pluginManagement {
    buildscript {
        repositories {
            mavenCentral()
            maven {
                url = uri("https://storage.googleapis.com/r8-releases/raw")
            }
        }
        dependencies {
            classpath("com.android.tools:r8:<R8VERSION>")
        }
    }
}

do...@gmail.com <do...@gmail.com> #14Sep 6, 2022 09:22AM

thx! I have tried the main branch and this issue has been fixed.

Issue 244970402

Description

Issue summary

Comments

ze...@google.com <ze...@google.com> Sep 5, 2022 01:07PM

ze...@google.com <ze...@google.com> #2Sep 5, 2022 02:17PM

ap...@google.com <ap...@google.com> #3Sep 5, 2022 02:19PM

ap...@google.com <ap...@google.com> #4Sep 6, 2022 05:39AM

ap...@google.com <ap...@google.com> #5Sep 6, 2022 07:52AM

ap...@google.com <ap...@google.com> #6Sep 6, 2022 07:52AM

ap...@google.com <ap...@google.com> #7Sep 6, 2022 07:52AM

ap...@google.com <ap...@google.com> #8Sep 6, 2022 07:52AM

ap...@google.com <ap...@google.com> #9Sep 6, 2022 07:52AM

ap...@google.com <ap...@google.com> #10Sep 6, 2022 07:52AM

ap...@google.com <ap...@google.com> #11Sep 6, 2022 07:53AM

ap...@google.com <ap...@google.com> #12Sep 6, 2022 07:53AM

ze...@google.com <ze...@google.com> #13Sep 6, 2022 08:10AM

do...@gmail.com <do...@gmail.com> #14Sep 6, 2022 09:22AM

Add comment

Issue metadata