Adding optional parameters to Kotlin inline functions is considered a breaking change [245139957]

Assigned

Bug

Status Update

No update yet.

Description

ku...@google.com

created issue #1

Sep 5, 2022 04:14PM

Adding optional parameters to Kotlin inline functions would make ./gradlew checkApiRelease fail with message "Your change has API compatibility issues."

I can bypass it with ./gradlew ignoreApiChange && ./gradlew updateApi, but it should be compatible as inline functions can't be called from Java and the old versions are already inlined in compiled Kotlin code.

CL: https://android-review.googlesource.com/c/platform/frameworks/support/+/2190956

Comments

al...@google.com <al...@google.com> Sep 7, 2022 06:53PM

Assigned to me...@google.com.

ap...@google.com <ap...@google.com> #2Oct 17, 2022 02:24PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8d1b84a6aabbb17cfd026e9626c612bf64a49709
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Mar 25 15:41:47 2022

Call Processor.startWork() in `DelayMetCommandHandler` from serial executor

After this CL `Processor.startWork()` is always called from serial executor,
so there is now a guarantee for other work in the serial executor, that now new
work will be started in parallel. This is important for work updating feature because
we want to guarantee that if update was successful, then next worker execution will have
updated spec.

bug: 219446409
Test: ./gradlew :work:work-runtime:cC
Change-Id: Ic9ff9e0fdcc6524b12b3761b9976f328e834e95a

M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java

https://android-review.googlesource.com/2042710

Issue 245139957

Description

Issue summary

Comments

al...@google.com <al...@google.com> Sep 7, 2022 06:53PM

ap...@google.com <ap...@google.com> #2Oct 17, 2022 02:24PM

Add comment

Issue metadata