Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 7390aaf82de6c67aa1aa1127abaec653e9adcd48
Author: Chris Craik <ccraik@google.com>
Date: Wed Sep 07 13:35:32 2022
Remove startActivityAndWait filtering for StartupTimingMetric
Fixes:245414235
Test: startup_withoutStartActivityAndWait
Test: ./gradlew bench:b-m:cC
Relnote: "Fixed StartupTimingMetric to no longer require measured
Activities to be launched through
MacrobenchmarkScope.startActivityAndWait(). This means the metric can
pick up launches from e.g. notifications, Context.startActivity(),
in-app Activity based navigation, or shell commands."
This change adds tests for in-app Activity based navigation for
validation, as Context.startActivity from a background (e.g. test)
context incurs significant delays on some platform versions, and is
awkward to await.
Change-Id: Ia2de6bc01cb697c016474ba364ef21a768b4e060
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/ConfigurableActivity.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/StartupTimingMetricTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/StartupTimingQuery.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/StartupTimingQueryTest.kt
https://android-review.googlesource.com/2210116
Branch: androidx-main
commit 7390aaf82de6c67aa1aa1127abaec653e9adcd48
Author: Chris Craik <ccraik@google.com>
Date: Wed Sep 07 13:35:32 2022
Remove startActivityAndWait filtering for StartupTimingMetric
Fixes:245414235
Test: startup_withoutStartActivityAndWait
Test: ./gradlew bench:b-m:cC
Relnote: "Fixed StartupTimingMetric to no longer require measured
Activities to be launched through
MacrobenchmarkScope.startActivityAndWait(). This means the metric can
pick up launches from e.g. notifications, Context.startActivity(),
in-app Activity based navigation, or shell commands."
This change adds tests for in-app Activity based navigation for
validation, as Context.startActivity from a background (e.g. test)
context incurs significant delays on some platform versions, and is
awkward to await.
Change-Id: Ia2de6bc01cb697c016474ba364ef21a768b4e060
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/ConfigurableActivity.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/StartupTimingMetricTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/StartupTimingQuery.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/StartupTimingQueryTest.kt
na...@google.com
This bug was linked in a change in the following release(s):
androidx.benchmark:benchmark-macro:1.2.0-alpha04
Description
Currently, this prevents measuring activity starts from e.g. clicking a button, instead of going through an intent.
Verified that in original trace, removing this requirement fixed measurements.