ClassNotFoundException in dynamic feature that depends directly on Kotlin library subproject [246326007]

Fixed

Bug

Status Update

No update yet.

Description

de...@squareup.com

created issue #1

Sep 12, 2022 04:48PM

DESCRIBE THE ISSUE IN DETAIL:

With the following project structure:

A base app module
A plain Kotlin module called library with some classes defined that also uses kapt/dagger2
A dynamic feature module feature which depends on library, and makes use of code from library.

Launching an activity from the feature module causes a NoClassDefFoundError when trying to instantiate the class(es) defined in the library module.

This only seems to happen when Dagger2 is applied to the library module and when code is generated via kapt. If all dagger-related code is removed from the library module then the class loading works fine. When dagger2 is applied it is actually also possible to instantiate the classes that are generated by dagger, despite the manually-defined classes being absent from the dex path.

A project that reproduces this error is available here: https://github.com/dellisd/manifest-boom/tree/dagger-wtf (on that particular branch).

Another behaviour of this issue is that changing the app deploy method from "Default APK" to "APK from app bundle" fixes this issue in that project, however the same problem has been observed in other larger projects when using "APK from app bundle". It's been difficult to reproduce in a smaller project, but presumably it is related to the issue described here.

STEPS TO REPRODUCE:

Clone this branch from this project https://github.com/dellisd/manifest-boom/tree/dagger-wtf
Run the app
Observe the crash in logcat
Change the deploy method to "APK from app bundle" in the run configuration
Launch the app and observe no crash

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

The output from these lines of code: https://github.com/dellisd/manifest-boom/blob/dagger-wtf/feature/src/main/java/com/example/manifestboom/feature/FirstFragment.kt#L26-L36

2022-09-12 12:46:22.939  9485-9485  FeatureFragment         com.example.manifestboom             E  com.example.manifestboom.feature.DaggerFeatureComponent$FeatureComponentImpl@d366fc1
2022-09-12 12:46:22.941  9485-9485  FeatureFragment         com.example.manifestboom             E  com.example.manifestboom.library.ThingContainer_Factory@88c06a7
2022-09-12 12:46:22.943  9485-9485  AndroidRuntime          com.example.manifestboom             D  Shutting down VM
2022-09-12 12:46:22.945  9485-9485  AndroidRuntime          com.example.manifestboom             E  FATAL EXCEPTION: main
                                                                                                    Process: com.example.manifestboom, PID: 9485
                                                                                                    java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.manifestboom/com.example.manifestboom.feature.FeatureActivity}: android.view.InflateException: Binary XML file line #23 in com.example.manifestboom.feature:layout/activity_shortcut: Binary XML file line #18 in com.example.manifestboom.feature:layout/content_feature: Error inflating class fragment
                                                                                                    	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3676)
                                                                                                    	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3813)
                                                                                                    	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2308)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:201)
                                                                                                    	at android.os.Looper.loop(Looper.java:288)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:7898)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
                                                                                                    Caused by: android.view.InflateException: Binary XML file line #23 in com.example.manifestboom.feature:layout/activity_shortcut: Binary XML file line #18 in com.example.manifestboom.feature:layout/content_feature: Error inflating class fragment
                                                                                                    Caused by: android.view.InflateException: Binary XML file line #18 in com.example.manifestboom.feature:layout/content_feature: Error inflating class fragment
                                                                                                    Caused by: androidx.fragment.app.Fragment$InstantiationException: Unable to instantiate fragment com.example.manifestboom.feature.FirstFragment: calling Fragment constructor caused an exception
                                                                                                    	at androidx.fragment.app.Fragment.instantiate(Fragment.java:681)
                                                                                                    	at androidx.fragment.app.FragmentContainer.instantiate(FragmentContainer.java:57)
                                                                                                    	at androidx.fragment.app.FragmentManager$3.instantiate(FragmentManager.java:498)
                                                                                                    	at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:190)
                                                                                                    	at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:162)
                                                                                                    	at androidx.navigation.NavGraphNavigator.navigate(NavGraphNavigator.kt:83)
                                                                                                    	at androidx.navigation.NavGraphNavigator.navigate(NavGraphNavigator.kt:49)
                                                                                                    	at androidx.navigation.NavController.navigateInternal(NavController.kt:260)
                                                                                                    	at androidx.navigation.NavController.navigate(NavController.kt:1719)
                                                                                                    	at androidx.navigation.NavController.onGraphCreated(NavController.kt:1161)
                                                                                                    	at androidx.navigation.NavController.setGraph(NavController.kt:1086)
                                                                                                    	at androidx.navigation.NavController.setGraph(NavController.kt:1039)
                                                                                                    	at androidx.navigation.fragment.NavHostFragment.onCreate(NavHostFragment.kt:155)
                                                                                                    	at androidx.fragment.app.Fragment.performCreate(Fragment.java:3090)
                                                                                                    	at androidx.fragment.app.FragmentStateManager.create(FragmentStateManager.java:475)
                                                                                                    	at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:257)
                                                                                                    	at androidx.fragment.app.FragmentLayoutInflaterFactory.onCreateView(FragmentLayoutInflaterFactory.java:142)
                                                                                                    	at androidx.fragment.app.FragmentController.onCreateView(FragmentController.java:136)
                                                                                                    	at androidx.fragment.app.FragmentActivity.dispatchFragmentsOnCreateView(FragmentActivity.java:248)
                                                                                                    	at androidx.fragment.app.FragmentActivity.onCreateView(FragmentActivity.java:227)
                                                                                                    	at android.view.LayoutInflater.tryCreateView(LayoutInflater.java:1073)
                                                                                                    	at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:1001)
                                                                                                    	at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:965)
                                                                                                    	at android.view.LayoutInflater.rInflate(LayoutInflater.java:1127)
                                                                                                    	at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:1088)
2022-09-12 12:46:22.948  9485-9485  AndroidRuntime          com.example.manifestboom             E  	at android.view.LayoutInflater.parseInclude(LayoutInflater.java:1267)
                                                                                                    	at android.view.LayoutInflater.rInflate(LayoutInflater.java:1123)
                                                                                                    	at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:1088)
                                                                                                    	at android.view.LayoutInflater.inflate(LayoutInflater.java:686)
                                                                                                    	at android.view.LayoutInflater.inflate(LayoutInflater.java:538)
                                                                                                    	at com.example.manifestboom.feature.databinding.ActivityShortcutBinding.inflate(ActivityShortcutBinding.java:50)
                                                                                                    	at com.example.manifestboom.feature.databinding.ActivityShortcutBinding.inflate(ActivityShortcutBinding.java:44)
                                                                                                    	at com.example.manifestboom.feature.FeatureActivity.onCreate(FeatureActivity.kt:20)
                                                                                                    	at android.app.Activity.performCreate(Activity.java:8290)
                                                                                                    	at android.app.Activity.performCreate(Activity.java:8269)
                                                                                                    	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1384)
                                                                                                    	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3657)
                                                                                                    	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3813)
                                                                                                    	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2308)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:201)
                                                                                                    	at android.os.Looper.loop(Looper.java:288)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:7898)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
                                                                                                    Caused by: java.lang.reflect.InvocationTargetException
                                                                                                    	at java.lang.reflect.Constructor.newInstance0(Native Method)
                                                                                                    	at java.lang.reflect.Constructor.newInstance(Constructor.java:343)
                                                                                                    	at androidx.fragment.app.Fragment.instantiate(Fragment.java:663)
                                                                                                    	... 48 more
                                                                                                    Caused by: java.lang.NoClassDefFoundError: Failed resolution of: Lcom/example/manifestboom/library/Thing;
                                                                                                    	at com.example.manifestboom.feature.FirstFragment.<init>(FirstFragment.kt:35)
                                                                                                    	... 51 more
                                                                                                    Caused by: java.lang.ClassNotFoundException: Didn't find class "com.example.manifestboom.library.Thing" on path: DexPathList[[zip file "/data/app/~~zo2NtxJr8auEuAY6LPCcqg==/com.example.manifestboom-n9SdGdBL3-sy2PLZwV1R1Q==/base.apk", zip file "/data/app/~~zo2NtxJr8auEuAY6LPCcqg==/com.example.manifestboom-n9SdGdBL3-sy2PLZwV1R1Q==/split_feature.apk"],nativeLibraryDirectories=[/data/app/~~zo2NtxJr8auEuAY6LPCcqg==/com.example.manifestboom-n9SdGdBL3-sy2PLZwV1R1Q==/lib/arm64, /system/lib64, /system_ext/lib64]]
                                                                                                    	at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:259)
                                                                                                    	at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
                                                                                                    	at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
                                                                                                    	... 52 more

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: 2021.3.1 RC 1, #AI-213.7172.25.2113.8913347 Version of Gradle Plugin: 7.3.0-rc01 (also observed on 7.2.2) Version of Gradle: 7.4 Version of Java: 11 OS: macOS

Comments

de...@squareup.com <de...@squareup.com> #2Sep 12, 2022 08:39PM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

dy...@google.com <dy...@google.com> Sep 15, 2022 03:15PM

Assigned to an...@google.com.

ju...@google.com <ju...@google.com> Sep 23, 2022 09:57PM

Status: New

ac...@google.com <ac...@google.com> #3Sep 24, 2022 03:58AM

Almost 2 months later and this is still broken

de...@squareup.com <de...@squareup.com> #4Oct 4, 2022 07:18PM

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

de...@squareup.com <de...@squareup.com> #5Oct 4, 2022 09:06PM

jb...@google.com What is the update on this?

de...@squareup.com <de...@squareup.com> #6Oct 6, 2022 07:06PM

What is the status of this item?

bi...@google.com <bi...@google.com> #7Oct 28, 2022 12:28AM

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

de...@squareup.com <de...@squareup.com> #8Oct 31, 2022 01:53PM

Any ETA on next release?

bi...@google.com <bi...@google.com> Oct 31, 2022 11:16PM

Accepted by bi...@google.com.

ga...@google.com <ga...@google.com> #9Nov 7, 2022 11:26AM

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

bi...@google.com <bi...@google.com> #10Jan 10, 2023 01:38AM

Comfirmed that this seems to still be broken. Can we have an update please?

```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1

(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```

de...@squareup.com <de...@squareup.com> #11Jan 26, 2023 04:23PM

Hi, is there any update to this issue? Thanks.

ga...@google.com <ga...@google.com> #12Jan 26, 2023 05:11PM

Hi Google. You claim it's been fixed on master, but we haven't had a new release since the broken version 26.1.1. Can you please release the fix?

bi...@google.com <bi...@google.com> #13Feb 9, 2023 07:21PM

Marked as fixed.

Yeah, still not fixed --'

hu...@google.com <hu...@google.com> #14Feb 10, 2023 12:40PM

Can't believe this still isn't fixed 2 years later for a command line utility that sits on the main dev site.

Message last modified on Feb 10, 2023 12:47PM