ClassNotFoundException in dynamic feature that depends directly on Kotlin library subproject [246326007]

Fixed

Bug

Status Update

No update yet.

Description

de...@squareup.com

created issue #1

Sep 12, 2022 04:48PM

DESCRIBE THE ISSUE IN DETAIL:

With the following project structure:

A base app module
A plain Kotlin module called library with some classes defined that also uses kapt/dagger2
A dynamic feature module feature which depends on library, and makes use of code from library.

Launching an activity from the feature module causes a NoClassDefFoundError when trying to instantiate the class(es) defined in the library module.

This only seems to happen when Dagger2 is applied to the library module and when code is generated via kapt. If all dagger-related code is removed from the library module then the class loading works fine. When dagger2 is applied it is actually also possible to instantiate the classes that are generated by dagger, despite the manually-defined classes being absent from the dex path.

A project that reproduces this error is available here: https://github.com/dellisd/manifest-boom/tree/dagger-wtf (on that particular branch).

Another behaviour of this issue is that changing the app deploy method from "Default APK" to "APK from app bundle" fixes this issue in that project, however the same problem has been observed in other larger projects when using "APK from app bundle". It's been difficult to reproduce in a smaller project, but presumably it is related to the issue described here.

STEPS TO REPRODUCE:

Clone this branch from this project https://github.com/dellisd/manifest-boom/tree/dagger-wtf
Run the app
Observe the crash in logcat
Change the deploy method to "APK from app bundle" in the run configuration
Launch the app and observe no crash

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

The output from these lines of code: https://github.com/dellisd/manifest-boom/blob/dagger-wtf/feature/src/main/java/com/example/manifestboom/feature/FirstFragment.kt#L26-L36

2022-09-12 12:46:22.939  9485-9485  FeatureFragment         com.example.manifestboom             E  com.example.manifestboom.feature.DaggerFeatureComponent$FeatureComponentImpl@d366fc1
2022-09-12 12:46:22.941  9485-9485  FeatureFragment         com.example.manifestboom             E  com.example.manifestboom.library.ThingContainer_Factory@88c06a7
2022-09-12 12:46:22.943  9485-9485  AndroidRuntime          com.example.manifestboom             D  Shutting down VM
2022-09-12 12:46:22.945  9485-9485  AndroidRuntime          com.example.manifestboom             E  FATAL EXCEPTION: main
                                                                                                    Process: com.example.manifestboom, PID: 9485
                                                                                                    java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.manifestboom/com.example.manifestboom.feature.FeatureActivity}: android.view.InflateException: Binary XML file line #23 in com.example.manifestboom.feature:layout/activity_shortcut: Binary XML file line #18 in com.example.manifestboom.feature:layout/content_feature: Error inflating class fragment
                                                                                                    	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3676)
                                                                                                    	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3813)
                                                                                                    	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2308)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:201)
                                                                                                    	at android.os.Looper.loop(Looper.java:288)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:7898)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
                                                                                                    Caused by: android.view.InflateException: Binary XML file line #23 in com.example.manifestboom.feature:layout/activity_shortcut: Binary XML file line #18 in com.example.manifestboom.feature:layout/content_feature: Error inflating class fragment
                                                                                                    Caused by: android.view.InflateException: Binary XML file line #18 in com.example.manifestboom.feature:layout/content_feature: Error inflating class fragment
                                                                                                    Caused by: androidx.fragment.app.Fragment$InstantiationException: Unable to instantiate fragment com.example.manifestboom.feature.FirstFragment: calling Fragment constructor caused an exception
                                                                                                    	at androidx.fragment.app.Fragment.instantiate(Fragment.java:681)
                                                                                                    	at androidx.fragment.app.FragmentContainer.instantiate(FragmentContainer.java:57)
                                                                                                    	at androidx.fragment.app.FragmentManager$3.instantiate(FragmentManager.java:498)
                                                                                                    	at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:190)
                                                                                                    	at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:162)
                                                                                                    	at androidx.navigation.NavGraphNavigator.navigate(NavGraphNavigator.kt:83)
                                                                                                    	at androidx.navigation.NavGraphNavigator.navigate(NavGraphNavigator.kt:49)
                                                                                                    	at androidx.navigation.NavController.navigateInternal(NavController.kt:260)
                                                                                                    	at androidx.navigation.NavController.navigate(NavController.kt:1719)
                                                                                                    	at androidx.navigation.NavController.onGraphCreated(NavController.kt:1161)
                                                                                                    	at androidx.navigation.NavController.setGraph(NavController.kt:1086)
                                                                                                    	at androidx.navigation.NavController.setGraph(NavController.kt:1039)
                                                                                                    	at androidx.navigation.fragment.NavHostFragment.onCreate(NavHostFragment.kt:155)
                                                                                                    	at androidx.fragment.app.Fragment.performCreate(Fragment.java:3090)
                                                                                                    	at androidx.fragment.app.FragmentStateManager.create(FragmentStateManager.java:475)
                                                                                                    	at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:257)
                                                                                                    	at androidx.fragment.app.FragmentLayoutInflaterFactory.onCreateView(FragmentLayoutInflaterFactory.java:142)
                                                                                                    	at androidx.fragment.app.FragmentController.onCreateView(FragmentController.java:136)
                                                                                                    	at androidx.fragment.app.FragmentActivity.dispatchFragmentsOnCreateView(FragmentActivity.java:248)
                                                                                                    	at androidx.fragment.app.FragmentActivity.onCreateView(FragmentActivity.java:227)
                                                                                                    	at android.view.LayoutInflater.tryCreateView(LayoutInflater.java:1073)
                                                                                                    	at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:1001)
                                                                                                    	at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:965)
                                                                                                    	at android.view.LayoutInflater.rInflate(LayoutInflater.java:1127)
                                                                                                    	at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:1088)
2022-09-12 12:46:22.948  9485-9485  AndroidRuntime          com.example.manifestboom             E  	at android.view.LayoutInflater.parseInclude(LayoutInflater.java:1267)
                                                                                                    	at android.view.LayoutInflater.rInflate(LayoutInflater.java:1123)
                                                                                                    	at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:1088)
                                                                                                    	at android.view.LayoutInflater.inflate(LayoutInflater.java:686)
                                                                                                    	at android.view.LayoutInflater.inflate(LayoutInflater.java:538)
                                                                                                    	at com.example.manifestboom.feature.databinding.ActivityShortcutBinding.inflate(ActivityShortcutBinding.java:50)
                                                                                                    	at com.example.manifestboom.feature.databinding.ActivityShortcutBinding.inflate(ActivityShortcutBinding.java:44)
                                                                                                    	at com.example.manifestboom.feature.FeatureActivity.onCreate(FeatureActivity.kt:20)
                                                                                                    	at android.app.Activity.performCreate(Activity.java:8290)
                                                                                                    	at android.app.Activity.performCreate(Activity.java:8269)
                                                                                                    	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1384)
                                                                                                    	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3657)
                                                                                                    	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3813)
                                                                                                    	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2308)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:201)
                                                                                                    	at android.os.Looper.loop(Looper.java:288)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:7898)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
                                                                                                    Caused by: java.lang.reflect.InvocationTargetException
                                                                                                    	at java.lang.reflect.Constructor.newInstance0(Native Method)
                                                                                                    	at java.lang.reflect.Constructor.newInstance(Constructor.java:343)
                                                                                                    	at androidx.fragment.app.Fragment.instantiate(Fragment.java:663)
                                                                                                    	... 48 more
                                                                                                    Caused by: java.lang.NoClassDefFoundError: Failed resolution of: Lcom/example/manifestboom/library/Thing;
                                                                                                    	at com.example.manifestboom.feature.FirstFragment.<init>(FirstFragment.kt:35)
                                                                                                    	... 51 more
                                                                                                    Caused by: java.lang.ClassNotFoundException: Didn't find class "com.example.manifestboom.library.Thing" on path: DexPathList[[zip file "/data/app/~~zo2NtxJr8auEuAY6LPCcqg==/com.example.manifestboom-n9SdGdBL3-sy2PLZwV1R1Q==/base.apk", zip file "/data/app/~~zo2NtxJr8auEuAY6LPCcqg==/com.example.manifestboom-n9SdGdBL3-sy2PLZwV1R1Q==/split_feature.apk"],nativeLibraryDirectories=[/data/app/~~zo2NtxJr8auEuAY6LPCcqg==/com.example.manifestboom-n9SdGdBL3-sy2PLZwV1R1Q==/lib/arm64, /system/lib64, /system_ext/lib64]]
                                                                                                    	at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:259)
                                                                                                    	at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
                                                                                                    	at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
                                                                                                    	... 52 more

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: 2021.3.1 RC 1, #AI-213.7172.25.2113.8913347 Version of Gradle Plugin: 7.3.0-rc01 (also observed on 7.2.2) Version of Gradle: 7.4 Version of Java: 11 OS: macOS

Comments

de...@squareup.com <de...@squareup.com> #2Sep 12, 2022 08:39PM

for example, many different devices return the same longitude and latitude.such as : longitude is 121.474000 and latitude is 31.230001.
i donnot understand why is the data the same?

dy...@google.com <dy...@google.com> Sep 15, 2022 03:15PM

Assigned to an...@google.com.

ju...@google.com <ju...@google.com> Sep 23, 2022 09:57PM

Status: New

ac...@google.com <ac...@google.com> #3Sep 24, 2022 03:58AM

the fractional part of the location data is exactly the same.

de...@squareup.com <de...@squareup.com> #4Oct 4, 2022 07:18PM

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

What steps are needed to reproduce this issue? Frequency of occurrence?

Which Android build are you using? (e.g. AP4A.241205.013.A1)

Which device did you use to reproduce this issue?

Can you confirm if this issue is reproducible on a Pixel/Nexus device?

Please provide a sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.

Android bug report (to be captured after reproducing the issue)
For steps to capture a bug report, please refer:

https://developer.android.com/studio/debug/bug-report#bugreportdevice

Alternate method
Navigate to “Developer options”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.

Note: Please upload the bug report and screenshot to google drive and share the folder to android-bugreport@google.com, then share the link here.

de...@squareup.com <de...@squareup.com> #5Oct 4, 2022 09:06PM

Please provide the requested information to proceed further. Unfortunately the issue will be closed within 7 days if there is no further update.

de...@squareup.com <de...@squareup.com> #6Oct 6, 2022 07:06PM

I only aply permission android.permission.ACCESS_COARSE_LOCATION.I use android.location.Location in the program.
for example,we hava 100 users.
20 users returned the same location information, longitude is 121.474000 and latitude is 31.230001。
30 users returned the same location information, longitude is 122.474000 and latitude is 32.230001。
15 users returned the same location information, longitude is 120.474000 and latitude is 30.230001。

as for Android build,all versions have it.
I dont reprodouce this issue.

what may be the cause of this issue?please

bi...@google.com <bi...@google.com> #7Oct 28, 2022 12:28AM

We have shared this with our product and engineering team and will update this issue with more information as it becomes available.

de...@squareup.com <de...@squareup.com> #8Oct 31, 2022 01:53PM

Thanks for reporting this issue.

COARSE_LOCATION typically takes location information from the nearby cell tower. If many users are near the same cell tower, each of those users will be given the same position. Using a FINE position will give much more detailed information.

Also, in certain areas, for privacy reasons, a less-exact location will be given, and that less-exact location might be identical for many users. Again, a fine-location configuration will return more precise location data.

bi...@google.com <bi...@google.com> Oct 31, 2022 11:16PM

Accepted by bi...@google.com.

ga...@google.com <ga...@google.com> #9Nov 7, 2022 11:26AM

We believe with reference to the above comment, your query has been answered, hence closing the bug. Please feel free to re-open the issue in the future if desired.

bi...@google.com <bi...@google.com> #10Jan 10, 2023 01:38AM

Thank you very much! it is very useful to me . It solved my confusion.

de...@squareup.com <de...@squareup.com> #11Jan 26, 2023 04:23PM

I noticed that this has been pushed back until AGP 8.1. If we're able to do the work of implementing the proper fix for this issue, would you be open to accepting a patch to get this in for 8.0?

We're currently monkey-patching this locally using that patch to DexingTransform.kt I submitted a while back which is proving to be an inconvenience for us to maintain as we upgrade AGP. So, if we're able to help expedite this fix by submitting a proper patch then that'd be great.

ga...@google.com <ga...@google.com> #12Jan 26, 2023 05:11PM

We are actually discussing internally and with Gradle how to address this.

Current options are (not in any particular order):

replace the filtering mechanism entirely: publish actual configuration from the base module that contains artifacts that need to be removed, and switch to something like SubtractingArtifactCollection that we already have
your proposal from #6: while it ensures different identity, I'm concerns about getting different output files on different machines, and ending up with multiple entries in the remote build cache. Consumers that care about file name or artifact identity will start getting cache misses.
similar to 2), but using the input file content hash and appending it to the output file name. This ensures that identity and output file remain the same across different machines. Also, it is a bit tricky as we need to snapshot dirs.
changing dex transforms from java-classes-directory -> dex with jar -> dex in dynamic features. We already do this when desugaring classpath is requested, so with this we'll just lose incremental dexing for API 24+ in dynamic features for local subprojects.

My current recommendation is 4).

bi...@google.com <bi...@google.com> #13Feb 9, 2023 07:21PM

Marked as fixed.

Fixed with Ia029820623ada6a24b4d74024c962925b0387b53

hu...@google.com <hu...@google.com> #14Feb 10, 2023 12:40PM

We decided to go with option 4: Disabling incremental dexing transforms for dynamic features (https://android.googlesource.com/platform/tools/base/+/246a2d52c80a7ff9c921ed9195645b40d0865b01), starting with AGP 8.1.0-alpha05.

This will likely slow down builds for dynamic features, so I've filed Issue 268603989 to revert this change once the Gradle bug https://github.com/gradle/gradle/issues/17213 is fixed.

Message last modified on Feb 10, 2023 12:47PM