No instantiated fragment for (xxx) [246519668]

Fixed

Bug

Status Update

No update yet.

Description

il...@gmail.com

created issue #1

Sep 13, 2022 12:53PM

Component used: Navigation Version used: 2.6.0-alpha01 Devices/Android versions reproduced on: Galaxy S21 5G

Hello! It seems like some users are facing very rare crashes with the following stack trace.

I'm unsure what the right direction would be to investigate and fix it. May it be somehow related to some rare Navigation framework internal issues?

Caused by java.lang.IllegalStateException: No instantiated fragment for (28176187-82ca-4cf9-b032-2a5429cad25a)
       at androidx.fragment.app.FragmentStore.restoreAddedFragments(FragmentStore.java:62)
       at androidx.fragment.app.FragmentManager.restoreSaveStateInternal(FragmentManager.java:2538)
       at androidx.fragment.app.FragmentManager.restoreSaveStateInternal(FragmentManager.java:414)
       at androidx.fragment.app.Fragment.restoreChildFragmentState(Fragment.java:1986)
       at androidx.fragment.app.Fragment.onCreate(Fragment.java:1965)
       at androidx.navigation.fragment.NavHostFragment.onCreate(NavHostFragment.kt:169)
       at androidx.fragment.app.Fragment.performCreate(Fragment.java:3090)
       at androidx.fragment.app.FragmentStateManager.create(FragmentStateManager.java:504)
       at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:268)
       at androidx.fragment.app.FragmentStore.moveToExpectedState(FragmentStore.java:114)
       at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1424)
       at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:63)
       at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:2971)
       at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:36)
       at androidx.fragment.app.FragmentManager.dispatchCreate(FragmentManager.java:2878)
       at androidx.fragment.app.Fragment.restoreChildFragmentState(Fragment.java:1987)
       at androidx.fragment.app.Fragment.onCreate(Fragment.java:1965)
       at app.ui.common.AbstractFragment.onCreate(AbstractFragment.kt:35)
       at androidx.fragment.app.Fragment.performCreate(Fragment.java:3090)
       at androidx.fragment.app.FragmentStateManager.create(FragmentStateManager.java:504)
       at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:268)
       at androidx.fragment.app.FragmentStore.moveToExpectedState(FragmentStore.java:114)
       at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1424)
       at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:63)
       at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:2971)
       at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:36)
       at androidx.fragment.app.FragmentManager.dispatchCreate(FragmentManager.java:2878)
       at androidx.fragment.app.Fragment.restoreChildFragmentState(Fragment.java:1987)
       at androidx.fragment.app.Fragment.onCreate(Fragment.java:1965)
       at androidx.navigation.fragment.NavHostFragment.onCreate(NavHostFragment.kt:169)
       at androidx.fragment.app.Fragment.performCreate(Fragment.java:3090)
       at androidx.fragment.app.FragmentStateManager.create(FragmentStateManager.java:504)
       at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:268)
       at androidx.fragment.app.FragmentStore.moveToExpectedState(FragmentStore.java:114)
       at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1424)
       at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:63)
       at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:2971)
       at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:36)
       at androidx.fragment.app.FragmentManager.dispatchCreate(FragmentManager.java:2878)
       at androidx.fragment.app.FragmentController.dispatchCreate(FragmentController.java:252)
       at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:220)
       at app.ui.main.MainActivity.onCreate(MainActivity.kt:43)
       at android.app.Activity.performCreate(Activity.java:8282)
       at android.app.Activity.performCreate(Activity.java:8262)
       at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1329)
       at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3996)
       at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:4188)
       at android.app.ActivityThread.handleRelaunchActivityInner(ActivityThread.java:6295)
       at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:6183)
       at android.app.servertransaction.ActivityRelaunchItem.execute(ActivityRelaunchItem.java:71)
       at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:45)
       at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
       at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2425)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loopOnce(Looper.java:226)
       at android.os.Looper.loop(Looper.java:313)
       at android.app.ActivityThread.main(ActivityThread.java:8582)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:563)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1133)

Fatal Exception: java.lang.RuntimeException: Unable to start activity ComponentInfo{app/app.ui.main.MainActivity}: java.lang.IllegalStateException: No instantiated fragment for (28176187-82ca-4cf9-b032-2a5429cad25a)
       at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:4022)
       at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:4188)
       at android.app.ActivityThread.handleRelaunchActivityInner(ActivityThread.java:6295)
       at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:6183)
       at android.app.servertransaction.ActivityRelaunchItem.execute(ActivityRelaunchItem.java:71)
       at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:45)
       at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
       at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2425)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loopOnce(Looper.java:226)
       at android.os.Looper.loop(Looper.java:313)
       at android.app.ActivityThread.main(ActivityThread.java:8582)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:563)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1133)

Comments

jb...@google.com <jb...@google.com> #2Sep 13, 2022 01:22PM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

il...@gmail.com <il...@gmail.com> #3Sep 18, 2022 12:28PM

yea i'll take it.

il...@gmail.com <il...@gmail.com> #4Sep 18, 2022 12:40PM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

il...@gmail.com <il...@gmail.com> #5Sep 18, 2022 12:43PM

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

studio64_fmDrC5ECDJ.mp4

44 MB

Download

jb...@google.com <jb...@google.com> #6Sep 19, 2022 10:57PM

With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)

il...@gmail.com <il...@gmail.com> #7Sep 20, 2022 08:00AM

yea sorry immediate does not fix it.
I actually have a WIP fix for it:

https://android-review.googlesource.com/c/platform/frameworks/support/+/1112186

if your case is the one i found (emitting same LiveData multiple times, as shown in #5) you can work around it by adding a dummy transformation.

val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData.map {it })
emitSource(subLiveData.map {it} )
}

il...@google.com <il...@google.com> Oct 18, 2022 08:49PM

Assigned to jb...@google.com.

ra...@gmail.com <ra...@gmail.com> #8Feb 9, 2023 08:54PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit af12e75e6b4110f48e44ca121466943909de8f06
Author: Yigit Boyar <yboyar@google.com>
Date: Tue Sep 03 12:58:11 2019

Fix coroutine livedata race condition

This CL fixes a bug in liveData builder where emitting same
LiveData source twice would make it crash because the second
emission registry could possibly happen before first one is
removed as source.

We fix it by using a suspending dispose function. It does feel
a bit hacky but we cannot make DisposableHandle.dispose async
and we do not want to block there. This does not mean that there
is a problem if developer disposes it manually since our emit
functions take care of making sure it disposes (and there is
no other way to add source to the underlying MediatorLiveData)

Bug: 140249349
Test: BuildLiveDataTest#raceTest_*

Change-Id: I0b464c242a583da4669af195cf2504e2adc4de40

M lifecycle/lifecycle-livedata-ktx/api/2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-ktx/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata-ktx/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt

https://android-review.googlesource.com/1112186

https://goto.google.com/android-sha1/af12e75e6b4110f48e44ca121466943909de8f06

ap...@google.com <ap...@google.com> #9Mar 29, 2023 10:58PM

Project: platform/frameworks/support
Branch: androidx-main

commit c5ff8b06a002ff7fcd89466b885f6ec930148d7f
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Mar 28 19:33:40 2023

Prevent accidentally removing active fragments

It is possible with saving and restoring state to accidentally make
fragment manager mark an active fragment as inactive.

This results in a failed restore after a config change.

We should only make FragmentStateManagers that are active inactive. This
ensures that active and inactive calls are 1 to 1.

RelNote: "Fixed a bug in FragmentManager where saving and restoring in
the same frame could cause a crash."
Test: Added FragmentManagerTest
Bug: 246519668

Change-Id: Ib36aff4a7263e10d7d795b4d8dbd6431d2552e5c

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentManagerTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStore.java

https://android-review.googlesource.com/2512715

jb...@google.com <jb...@google.com> #10Mar 29, 2023 11:26PM

Marked as fixed.

This has been fixed internally and will be available in the Fragment 1.6.0-alpha09 release.

na...@google.com <na...@google.com> #11Apr 5, 2023 06:28PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.fragment:fragment:1.6.0-alpha09

rp...@gmail.com <rp...@gmail.com> #12Jul 1, 2023 06:27AM

Comment has been deleted.

Message last modified on Jul 1, 2023 06:28AM