Fixed
Status Update
Comments
da...@google.com <da...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 25369f983e26d758a8a027c84b21f20026637181
Author: Chris Craik <ccraik@google.com>
Date: Mon Jul 12 14:05:36 2021
Update JankCollectionHelper to support S gfxinfo
Fixes: 193260119
Relnote: Fixes FrameTimingMetric to work on Android S beta
Test: ./gradlew bench:integration-tests:macrobenchmark:connectedAndroidTest -P android.testInstrumentationRunnerArguments.class=androidx.benchmark.integration.macrobenchmark.TrivialListScrollBenchmark # On R + S
Still manually cherry-picking changes, as the platform copy of the
file triggers many lint warnings in AndroidX build.
Change-Id: Ib60ccf09fb2fa09f128374140c3657015626dd2c
M benchmark/macro/src/main/java/androidx/benchmark/macro/JankCollectionHelper.java
M benchmark/macro/src/main/java/androidx/benchmark/macro/Metric.kt
https://android-review.googlesource.com/1763870
Branch: androidx-main
commit 25369f983e26d758a8a027c84b21f20026637181
Author: Chris Craik <ccraik@google.com>
Date: Mon Jul 12 14:05:36 2021
Update JankCollectionHelper to support S gfxinfo
Fixes: 193260119
Relnote: Fixes FrameTimingMetric to work on Android S beta
Test: ./gradlew bench:integration-tests:macrobenchmark:connectedAndroidTest -P android.testInstrumentationRunnerArguments.class=androidx.benchmark.integration.macrobenchmark.TrivialListScrollBenchmark # On R + S
Still manually cherry-picking changes, as the platform copy of the
file triggers many lint warnings in AndroidX build.
Change-Id: Ib60ccf09fb2fa09f128374140c3657015626dd2c
M benchmark/macro/src/main/java/androidx/benchmark/macro/JankCollectionHelper.java
M benchmark/macro/src/main/java/androidx/benchmark/macro/Metric.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 6130a90a0d682badb5f4aa0f17c09c0e3468d6c7
Author: elifbilgin <elifbilgin@google.com>
Date: Thu Sep 15 15:32:33 2022
Fixing issue where shadow table names are not included in the .json file output. Issue is resolved by adding @Transient to the shadow table properties.
Bug: 246751839
Test: N/A
Change-Id: I4f83b2d6ead57d5110977c00c46c17601f75627f
M room/room-migration/src/main/java/androidx/room/migration/bundle/FtsEntityBundle.kt
https://android-review.googlesource.com/2218944
Branch: androidx-main
commit 6130a90a0d682badb5f4aa0f17c09c0e3468d6c7
Author: elifbilgin <elifbilgin@google.com>
Date: Thu Sep 15 15:32:33 2022
Fixing issue where shadow table names are not included in the .json file output. Issue is resolved by adding @Transient to the shadow table properties.
Bug: 246751839
Test: N/A
Change-Id: I4f83b2d6ead57d5110977c00c46c17601f75627f
M room/room-migration/src/main/java/androidx/room/migration/bundle/FtsEntityBundle.kt
el...@google.com <el...@google.com>
na...@google.com <na...@google.com> #4
This bug was linked in a change in the following release(s):
androidx.room:room-migration:2.5.0-beta01
Description
Component used:
androidx.room:room-compiler
Version used:
2.5.0-alpha02
,2.5.0-alpha03
Devices/Android versions reproduced on:
Samsung Galaxy S21 / Android 12
I've updated the Room version from
2.4.3
to2.5.0-alpha03
and after the last migration, the JSON generated will once in a while fail withAfter checking out the differences between the last schema file 73.json and the new one, 74.json, apart from the changes I've wanted to make, there's this block:
inside the only ftsVersion block I have. Whatever I write in the migration script doesn't matter, I always get the same issue. If I delete the .json, an identical one regenerates, which works fine the first time but then crashes the second time. What I've found is that if I delete the
SHADOW_TABLE_NAME_SUFFIXES
andshadowTableNames$delegate
blocks from 74.json, I don't get the issue anymore.I've attached a demo app in which I've reproduced the issue, however, I must mention that initially, it worked fine up to the 3rd database version. How I've managed to reproduce the issue on the demo app is as follows: