TextField with readonly set to true can be edited [246909589]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Sep 15, 2022 09:11AM

Jetpack Compose version: 1.2.1

Jetpack Compose component(s) used: androidx.compose.material.TextField

Android Studio Build:Android Studio Chipmunk | 2021.2.1 Build #AI-212.5712.43.2112.8512546, built on April 28, 2022

Kotlin version: 1.7.0

Steps to Reproduce or Code Sample to Reproduce:

1.Run this snippet 2.The TextField is enabled and not readonly for 10 seconds, you can start typing 3.When the 10 seconds have elapsed, the TextField can still be written to using the Virtual Keyboard

Is this a normal behavior? Is there another way to prevent writing to the TextField?

Sample code:

Surface(
                    modifier = Modifier.fillMaxSize(),
                    color = MaterialTheme.colors.background
                ) {
                    var text by remember { mutableStateOf("Hello") }
                    var readOnly by remember {
                        mutableStateOf(false)
                    }
                    LaunchedEffect(Unit) {
                        delay(Duration.seconds(10))
                        readOnly = true
                    }

                    TextField(
                        value = text,
                        onValueChange = { text = it },
                        label = { Text("Label") },
                        readOnly = readOnly,
                        enabled = !readOnly,
                    )
                }

textfield-bug-repro.mp4

1.3 MB

Download

Comments

lp...@google.com <lp...@google.com> Sep 15, 2022 02:21PM

Assigned to an...@google.com.

dm...@gmail.com <dm...@gmail.com> #2Jul 6, 2023 12:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

kl...@google.com <kl...@google.com> #3Jul 18, 2023 07:00PM

Reassigned to kl...@google.com.

I can repro on tip-of-tree as long as readOnly is set to true before the field is focused. If it's set to true while focused, then the field becomes truly read-only.

Probably related to b/289237728.

Message last modified on Jul 18, 2023 07:03PM

kl...@google.com <kl...@google.com> #4Jul 18, 2023 07:02PM

Comment has been deleted.

Message last modified on Jul 18, 2023 07:03PM

kl...@google.com <kl...@google.com> Jul 20, 2023 09:24PM

Accepted by kl...@google.com.

m....@anfe.ma <m....@anfe.ma> #5Jul 24, 2023 03:24PM

For me this issue was introduced when updating from compose UI 1.4.3 to 1.5.0-beta03.

ap...@google.com <ap...@google.com> #6Jul 25, 2023 02:20PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 4ddee46a339123f89b35da23aea4a6a65f6432fd
Author: Zach Klippenstein <klippenstein@google.com>
Date: Thu Jul 20 16:26:04 2023

Fix readonly text fields.

Fixes both BasicTextField and BTF2.

Fixed behavior:
- Keyboard is shown when readOnly is disabled while focused.
- Keyboard will not be shown when focused while readOnly.
- Semantics text actions (set and insert) will no-op when readOnly.

Fixes:

b/246909589

Test: many
Relnote: "Fixed text fields showing keyboard and being editable when
`readOnly` is true. Also fixed the keyboard not showing when
`readOnly` is changed from true to false while focused."
Change-Id: I34a19a80d8f44b10f23db0ca0dd7b43b69311c7c

A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ReadOnlyTextFieldDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldFocusTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldInputServiceIntegrationTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/KeyboardHelper.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/BasicTextField2ImmIntegrationTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/BasicTextField2SemanticsTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/BasicTextField2Test.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text2/input/internal/TextFieldDecoratorModifier.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/TextActionsTest.kt

https://android-review.googlesource.com/2669997

na...@google.com <na...@google.com> #7Aug 10, 2023 03:47PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.6.0-alpha03
androidx.compose.foundation:foundation-android:1.6.0-alpha03
androidx.compose.ui:ui-test:1.6.0-alpha03
androidx.compose.ui:ui-test-android:1.6.0-alpha03

p....@anfe.ma <p....@anfe.ma> #8Aug 16, 2023 03:07PM

It would be great if this fix would be backported to the stable 1.5 versions.

se...@squareup.com <se...@squareup.com> #9Aug 29, 2023 12:08AM

Can this be back-ported to the stable 1.5 version, or is there a known workaround for this issue in Compose 1.5? We've noticed this while upgrading from 1.4.3 to 1.5.0. text fields are unexpectedly triggering the keyboard to appear despite having readOnly set to true. Some of our screens are written with the presumption that the keyboard will never pop up, so the keyboard launch breaks those UIs when the window resizes.

ek...@uber.com <ek...@uber.com> #10Aug 29, 2023 04:54PM

We are having same issue and same question above about pulling it into a new stable 1.5 release so we won't have to skip 1.5 entirely.

kl...@google.com <kl...@google.com> #11Aug 29, 2023 06:21PM

Working on getting this cherry-picked into the next 1.5 release.

pr...@google.com <pr...@google.com> #12Sep 6, 2023 07:56PM