TextField with readonly set to true can be edited [246909589]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Sep 15, 2022 09:11AM

Jetpack Compose version: 1.2.1

Jetpack Compose component(s) used: androidx.compose.material.TextField

Android Studio Build:Android Studio Chipmunk | 2021.2.1 Build #AI-212.5712.43.2112.8512546, built on April 28, 2022

Kotlin version: 1.7.0

Steps to Reproduce or Code Sample to Reproduce:

1.Run this snippet 2.The TextField is enabled and not readonly for 10 seconds, you can start typing 3.When the 10 seconds have elapsed, the TextField can still be written to using the Virtual Keyboard

Is this a normal behavior? Is there another way to prevent writing to the TextField?

Sample code:

Surface(
                    modifier = Modifier.fillMaxSize(),
                    color = MaterialTheme.colors.background
                ) {
                    var text by remember { mutableStateOf("Hello") }
                    var readOnly by remember {
                        mutableStateOf(false)
                    }
                    LaunchedEffect(Unit) {
                        delay(Duration.seconds(10))
                        readOnly = true
                    }

                    TextField(
                        value = text,
                        onValueChange = { text = it },
                        label = { Text("Label") },
                        readOnly = readOnly,
                        enabled = !readOnly,
                    )
                }

textfield-bug-repro.mp4

1.3 MB

Download

Comments

lp...@google.com <lp...@google.com> Sep 15, 2022 02:21PM

Assigned to an...@google.com.

dm...@gmail.com <dm...@gmail.com> #2Jul 6, 2023 12:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c9e90d1e5671b7e6a8880aecbe32bb13f4b37560
Author: Siyamed Sinir <siyamed@google.com>
Date: Thu Oct 31 11:30:30 2019

Remove font related TODOs

- Ability to read font weight from the font

b/143700963

- Support for font collections

b/122476423

- Support for variable fonts

b/143703328

- support for multiple font family

b/127483182

- BaselineShift.lerp

b/143699225

Test: ./gradlew ui:ui-text:test
Test: ./gradlew ui:ui-text:connectedAndroidTest

Bug: 141645236
Bug: 143700963
Bug: 122476423
Bug: 143703328
Bug: 127483182
Bug: 143699225
Change-Id: I4ff001fd1e0fff4cd3aa0c64efae929057e8d5de

M ui/ui-text/api/0.1.0-dev03.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev03.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev03.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/main/java/androidx/ui/text/font/Font.kt
M ui/ui-text/src/main/java/androidx/ui/text/platform/AndroidParagraphHelper.kt
M ui/ui-text/src/main/java/androidx/ui/text/platform/TypefaceAdapter.kt
M ui/ui-text/src/main/java/androidx/ui/text/style/BaselineShift.kt
M ui/ui-text/src/test/java/androidx/ui/text/font/FontFamilyTest.kt
M ui/ui-text/src/test/java/androidx/ui/text/font/FontTest.kt

https://android-review.googlesource.com/1156568

https://goto.google.com/android-sha1/c9e90d1e5671b7e6a8880aecbe32bb13f4b37560

kl...@google.com <kl...@google.com> #3Jul 18, 2023 07:00PM

Reassigned to kl...@google.com.

from dupped ticket

"CSS has font-variation-settings attribute
Also check if there are commonly used settings that we can add to the API.

Note:
Tracking ticket based on

https://docs.google.com/document/d/1MzK83egP-Jghc2ZW8IcIcJkud_vMM7jgDClCv4CkO_c/edit#bookmark=id.nyju92hr2ygw"

Message last modified on Jul 18, 2023 07:03PM

kl...@google.com <kl...@google.com> #4Jul 18, 2023 07:02PM

Comment has been deleted.

Message last modified on Jul 18, 2023 07:03PM

kl...@google.com <kl...@google.com> Jul 20, 2023 09:24PM

Accepted by kl...@google.com.

m....@anfe.ma <m....@anfe.ma> #5Jul 24, 2023 03:24PM

discussion from aosp/1672420

variable font settings can be included during font creation (for Font() functions.)

there are two parts of the story:

This font is weight X
I want to render the text in weight Y (regardless of the font weight)

ap...@google.com <ap...@google.com> #6Jul 25, 2023 02:20PM

Marked as fixed.

important for Material.

na...@google.com <na...@google.com> #7Aug 10, 2023 03:47PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8766bf0012613dfa48fdc969d03bd64217a4460c
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:17:37 2022

Add font variations to Android font constructors

On O+ this will allow configuring font variation settings.

Bug:

b/143703328

Test: ./gradle :compose:ui:ui-text:cAT
Relnote: "Font constructors now accept a list of FontVariation.Setting for configuring variable fonts on O+ devices."
Change-Id: I11a9d69d73429e9a875fd7096a00981a0cbd8a47

M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/testutils/AsyncTestFonts.kt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidFontTest.kt
A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidLoadableFonts.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A testutils/testutils-fonts/src/androidMain/assets/subdirectory/asset_variable_font.ttf
A testutils/testutils-fonts/src/font_ttx/variable_font.ttx
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFont.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/FontFamilyResolverImplTest.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidVariableFontTest.kt
A testutils/testutils-fonts/src/commonMain/resources/font/variable_font.ttf

https://android-review.googlesource.com/2162835

p....@anfe.ma <p....@anfe.ma> #8Aug 16, 2023 03:07PM

Project: platform/frameworks/support
Branch: androidx-main

commit ef1fff276087529659dc11ae29b219fcc2e5c790
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:14:04 2022

FontVariation definition

Bug:

b/143703328

Relnote: "Add FontVariation API for defining and using variable fonts."
Test: ./gradlew :compose:ui:ui-text:test
Change-Id: I3c40c6c8b4cee02cacda9482955ec16587ae62a5

M compose/ui/ui-text/lint-baseline.xml
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/font/FontVariationTest.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2161039

se...@squareup.com <se...@squareup.com> #9Aug 29, 2023 12:08AM

Project: platform/frameworks/support
Branch: androidx-main

commit 80e8419233f7f46dbca44236c11df5a3692030c2
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Aug 03 11:01:22 2022

Add VariableFonts to ResourceFont

Add support on Android API26+

Test: New demo
Test: ./gradlew :com:ui:ui-text:cAT && ./gradlew :com:ui;ui-text:test

Relnote: "Resource Fonts now support setting font variation settings (API 26+)."
Bug:

b/143703328

Change-Id: I900dde1f539e580a66db9c14d389ada691377c91

M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFontLoader.android.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/VariableFontsDemo.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/Font.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/font/ResourceFontVariationSettingsTest.kt

https://android-review.googlesource.com/2172940

ek...@uber.com <ek...@uber.com> #10Aug 29, 2023 04:54PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7ca15e8af5b4d7167667465d7f1a3e6f571526d0
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 10:36:57 2022

Add variable fonts to DeviceFontFamilyNameFont

Relnote: "Variable font support in DeviceFontFamilyNameFont"
Test: ./gradlew :compose:ui:ui-text:cAT
Bug:

b/143703328

Change-Id: Ic1279b2dcb1c29e75b8037791179853a9f828c02

M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidLoadableFonts.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/PlatformTypefaces.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/VariableFontsDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/DeviceFontFamilyNameFont.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/PlatformTypefacesTest.kt
M compose/foundation/foundation/integration-tests/foundation-demos/build.gradle

https://android-review.googlesource.com/2167512

kl...@google.com <kl...@google.com> #11Aug 29, 2023 06:21PM

Bugjuggler: b/241016309

pr...@google.com <pr...@google.com> #12Sep 6, 2023 07:56PM

Hi. I've received your bug and will wait for

b/241016309

to be resolved and then assign the bug to seanmcq@google.com.

Issue 246909589

Description

Issue summary

Comments

lp...@google.com <lp...@google.com> Sep 15, 2022 02:21PM

dm...@gmail.com <dm...@gmail.com> #2Jul 6, 2023 12:38PM

kl...@google.com <kl...@google.com> #3Jul 18, 2023 07:00PM

kl...@google.com <kl...@google.com> #4Jul 18, 2023 07:02PM

kl...@google.com <kl...@google.com> Jul 20, 2023 09:24PM

m....@anfe.ma <m....@anfe.ma> #5Jul 24, 2023 03:24PM

ap...@google.com <ap...@google.com> #6Jul 25, 2023 02:20PM

na...@google.com <na...@google.com> #7Aug 10, 2023 03:47PM

p....@anfe.ma <p....@anfe.ma> #8Aug 16, 2023 03:07PM

se...@squareup.com <se...@squareup.com> #9Aug 29, 2023 12:08AM

ek...@uber.com <ek...@uber.com> #10Aug 29, 2023 04:54PM

kl...@google.com <kl...@google.com> #11Aug 29, 2023 06:21PM

pr...@google.com <pr...@google.com> #12Sep 6, 2023 07:56PM

Add comment

Issue metadata