Fixed
Status Update
Comments
lp...@google.com <lp...@google.com>
dm...@gmail.com <dm...@gmail.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
kl...@google.com <kl...@google.com> #3
kl...@google.com <kl...@google.com> #4
Comment has been deleted.
kl...@google.com <kl...@google.com>
m....@anfe.ma <m....@anfe.ma> #5
For me this issue was introduced when updating from compose UI 1.4.3 to 1.5.0-beta03.
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 4ddee46a339123f89b35da23aea4a6a65f6432fd
Author: Zach Klippenstein <klippenstein@google.com>
Date: Thu Jul 20 16:26:04 2023
Fix readonly text fields.
Fixes both BasicTextField and BTF2.
Fixed behavior:
- Keyboard is shown when readOnly is disabled while focused.
- Keyboard will not be shown when focused while readOnly.
- Semantics text actions (set and insert) will no-op when readOnly.
Fixes: b/246909589
Test: many
Relnote: "Fixed text fields showing keyboard and being editable when
`readOnly` is true. Also fixed the keyboard not showing when
`readOnly` is changed from true to false while focused."
Change-Id: I34a19a80d8f44b10f23db0ca0dd7b43b69311c7c
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ReadOnlyTextFieldDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldFocusTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldInputServiceIntegrationTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/KeyboardHelper.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/BasicTextField2ImmIntegrationTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/BasicTextField2SemanticsTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/BasicTextField2Test.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text2/input/internal/TextFieldDecoratorModifier.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/TextActionsTest.kt
https://android-review.googlesource.com/2669997
Branch: androidx-main
commit 4ddee46a339123f89b35da23aea4a6a65f6432fd
Author: Zach Klippenstein <klippenstein@google.com>
Date: Thu Jul 20 16:26:04 2023
Fix readonly text fields.
Fixes both BasicTextField and BTF2.
Fixed behavior:
- Keyboard is shown when readOnly is disabled while focused.
- Keyboard will not be shown when focused while readOnly.
- Semantics text actions (set and insert) will no-op when readOnly.
Fixes:
Test: many
Relnote: "Fixed text fields showing keyboard and being editable when
`readOnly` is true. Also fixed the keyboard not showing when
`readOnly` is changed from true to false while focused."
Change-Id: I34a19a80d8f44b10f23db0ca0dd7b43b69311c7c
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ReadOnlyTextFieldDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldFocusTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldInputServiceIntegrationTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/KeyboardHelper.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/BasicTextField2ImmIntegrationTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/BasicTextField2SemanticsTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/BasicTextField2Test.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text2/input/internal/TextFieldDecoratorModifier.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/TextActionsTest.kt
na...@google.com <na...@google.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.6.0-alpha03
androidx.compose.foundation:foundation-android:1.6.0-alpha03
androidx.compose.ui:ui-test:1.6.0-alpha03
androidx.compose.ui:ui-test-android:1.6.0-alpha03
p....@anfe.ma <p....@anfe.ma> #8
It would be great if this fix would be backported to the stable 1.5 versions.
se...@squareup.com <se...@squareup.com> #9
Can this be back-ported to the stable 1.5 version, or is there a known workaround for this issue in Compose 1.5? We've noticed this while upgrading from 1.4.3 to 1.5.0. text fields are unexpectedly triggering the keyboard to appear despite having readOnly set to true. Some of our screens are written with the presumption that the keyboard will never pop up, so the keyboard launch breaks those UIs when the window resizes.
ek...@uber.com <ek...@uber.com> #10
We are having same issue and same question above about pulling it into a new stable 1.5 release so we won't have to skip 1.5 entirely.
kl...@google.com <kl...@google.com> #11
Working on getting this cherry-picked into the next 1.5 release.
pr...@google.com <pr...@google.com> #12
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.5.1
androidx.compose.foundation:foundation-android:1.5.1
androidx.compose.ui:ui-test:1.5.1
androidx.compose.ui:ui-test-android:1.5.1
Description
Jetpack Compose version: 1.2.1
Jetpack Compose component(s) used: androidx.compose.material.TextField
Android Studio Build:Android Studio Chipmunk | 2021.2.1 Build #AI-212.5712.43.2112.8512546, built on April 28, 2022
Kotlin version: 1.7.0
Steps to Reproduce or Code Sample to Reproduce:
1.Run this snippet 2.The TextField is enabled and not readonly for 10 seconds, you can start typing 3.When the 10 seconds have elapsed, the TextField can still be written to using the Virtual Keyboard
Is this a normal behavior? Is there another way to prevent writing to the TextField?
Sample code: