TextField with readonly set to true can be edited [246909589]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Sep 15, 2022 09:11AM

Jetpack Compose version: 1.2.1

Jetpack Compose component(s) used: androidx.compose.material.TextField

Android Studio Build:Android Studio Chipmunk | 2021.2.1 Build #AI-212.5712.43.2112.8512546, built on April 28, 2022

Kotlin version: 1.7.0

Steps to Reproduce or Code Sample to Reproduce:

1.Run this snippet 2.The TextField is enabled and not readonly for 10 seconds, you can start typing 3.When the 10 seconds have elapsed, the TextField can still be written to using the Virtual Keyboard

Is this a normal behavior? Is there another way to prevent writing to the TextField?

Sample code:

Surface(
                    modifier = Modifier.fillMaxSize(),
                    color = MaterialTheme.colors.background
                ) {
                    var text by remember { mutableStateOf("Hello") }
                    var readOnly by remember {
                        mutableStateOf(false)
                    }
                    LaunchedEffect(Unit) {
                        delay(Duration.seconds(10))
                        readOnly = true
                    }

                    TextField(
                        value = text,
                        onValueChange = { text = it },
                        label = { Text("Label") },
                        readOnly = readOnly,
                        enabled = !readOnly,
                    )
                }

textfield-bug-repro.mp4

1.3 MB

Download

Comments

lp...@google.com <lp...@google.com> Sep 15, 2022 02:21PM

Assigned to an...@google.com.

dm...@gmail.com <dm...@gmail.com> #2Jul 6, 2023 12:38PM

First of all thanks for this detailed issue.

This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.

The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.

Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.

kl...@google.com <kl...@google.com> #3Jul 18, 2023 07:00PM

Reassigned to kl...@google.com.

If the investigation takes time, would it be possible to revert the surrounding implementation to 1.6.x equivalent?

Or is that option not available?

Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.

Message last modified on Jul 18, 2023 07:03PM

kl...@google.com <kl...@google.com> #4Jul 18, 2023 07:02PM

Comment has been deleted.

Message last modified on Jul 18, 2023 07:03PM

kl...@google.com <kl...@google.com> Jul 20, 2023 09:24PM

Accepted by kl...@google.com.

m....@anfe.ma <m....@anfe.ma> #5Jul 24, 2023 03:24PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <halilibo@google.com>
Link: https://android-review.googlesource.com/3317256

Fix POBox keyboard issue

Expand for full commit details

Fix POBox keyboard issue 
 
Fix: 373743376 
Fix: 329209241 
Test: NullableInputConnectionWrapperTest 
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1

Files:

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt

Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024

ap...@google.com <ap...@google.com> #6Jul 25, 2023 02:20PM

Marked as fixed.

Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.

na...@google.com <na...@google.com> #7Aug 10, 2023 03:47PM

Thank you for fixing the issue, I confirmed the fix was released in version 1.8.0-alpha05.
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.

p....@anfe.ma <p....@anfe.ma> #8Aug 16, 2023 03:07PM

Yes, this fix is planned to be included in a future 1.7.x release.

se...@squareup.com <se...@squareup.com> #9Aug 29, 2023 12:08AM

Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.

ek...@uber.com <ek...@uber.com> #10Aug 29, 2023 04:54PM

We are having same issue and same question above about pulling it into a new stable 1.5 release so we won't have to skip 1.5 entirely.

kl...@google.com <kl...@google.com> #11Aug 29, 2023 06:21PM

Working on getting this cherry-picked into the next 1.5 release.

pr...@google.com <pr...@google.com> #12Sep 6, 2023 07:56PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.5.1
androidx.compose.foundation:foundation-android:1.5.1
androidx.compose.ui:ui-test:1.5.1
androidx.compose.ui:ui-test-android:1.5.1