New Modifier for Text [246960758]

Fixed

Feature Request

Status Update

No update yet.

Description

se...@google.com

created issue #1

Sep 15, 2022 05:36PM

New modifier for Text composable

Comments

se...@google.com <se...@google.com> Sep 15, 2022 05:36PM

Reassigned to se...@google.com.

ap...@google.com <ap...@google.com> #2Dec 20, 2022 12:09AM

First of all thanks for this detailed issue.

This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.

The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.

Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.

ap...@google.com <ap...@google.com> #3Dec 20, 2022 12:16AM

If the investigation takes time, would it be possible to revert the surrounding implementation to 1.6.x equivalent?

Or is that option not available?

Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.

ap...@google.com <ap...@google.com> #4Dec 20, 2022 10:16PM

Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.

Compose 1.7 has a bug that causes ANR when the focus is on EditText. https://issuetracker.google.com/issues/369354336

Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus(). https://issuetracker.google.com/issues/374031296

Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.

In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.

ap...@google.com <ap...@google.com> #5Dec 20, 2022 11:36PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <halilibo@google.com>
Link: https://android-review.googlesource.com/3317256

Fix POBox keyboard issue

Expand for full commit details

Fix POBox keyboard issue 
 
Fix: 373743376 
Fix: 329209241 
Test: NullableInputConnectionWrapperTest 
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1

Files:

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt

Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024

ap...@google.com <ap...@google.com> #6Jan 10, 2023 02:58AM

Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.

ap...@google.com <ap...@google.com> #7Jan 10, 2023 02:58AM

Thank you for fixing the issue, I confirmed the fix was released in version 1.8.0-alpha05.
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.

ap...@google.com <ap...@google.com> #8Jan 10, 2023 02:58AM

Yes, this fix is planned to be included in a future 1.7.x release.

ap...@google.com <ap...@google.com> #9Jan 10, 2023 02:58AM

Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.

ap...@google.com <ap...@google.com> #10Jan 10, 2023 02:58AM

Project: platform/frameworks/support
Branch: androidx-main

commit 9b45a135e82b693385cdf79bd9fbd3d7803dc3c3
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Dec 21 15:17:03 2022

Modifier fixes:

* Selection now delegates onGloballyPositioned correctly
* invalidateDraw is now invalidateLayer (which works)
* Correctly restart when async typefaces resolve

Bug:

b/246960758

Test: ./gradlew :com:found--d-n-s-newtext:cAT
Change-Id: I7918144b56900e582908326556361cc033b967f2

M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/MultiParagraphLayoutCache.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/StaticTextModifier.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/TextInlineContentLayoutDrawModifier.kt

https://android-review.googlesource.com/2366969

ap...@google.com <ap...@google.com> #11Jan 10, 2023 02:58AM

Project: platform/frameworks/support
Branch: androidx-main

commit 325cdef1ab447cc50aeeed75a8b9af7865de23b6
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Dec 21 13:04:06 2022

Copypasta integrate selection with new modifier

This code depends on pointerInput to finalize.

For now, use remember to add lifecycle to node-like
StaticTextSelectionModifierController.

Also fixed typo s/ture/true/ linter found in presubmit

Bug:

b/246960758

Test: ./gradlew :com:found--d-n-s-newtext:cAT
Change-Id: I1992103b5e777a6e3e868080bb50081ee7d89fd7

M compose/foundation/foundation-newtext/build.gradle
A compose/foundation/foundation-newtext/src/androidMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/ActualJvm.kt
A compose/foundation/foundation-newtext/src/androidMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/ContextMenu.android.kt
A compose/foundation/foundation-newtext/src/androidMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/StringHelpers.android.kt
A compose/foundation/foundation-newtext/src/androidMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/TextPointerIcon.android.kt
A compose/foundation/foundation-newtext/src/androidMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/TouchMode.kt
A compose/foundation/foundation-newtext/src/androidMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/AndroidSelectionHandles.android.kt
A compose/foundation/foundation-newtext/src/androidMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/SelectionManager.android.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/TextUsingModifier.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/ContextMenu.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/Expect.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/LongPressTextDragObserver.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/StringHelpers.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/TextLayoutResultProxy.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/TextPointerIcon.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/TouchMode.android.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/MultiWidgetSelectionDelegate.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/Selectable.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/Selection.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/SelectionAdjustment.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/SelectionContainer.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/SelectionHandles.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/SelectionMagnifier.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/SelectionManager.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/SelectionMode.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/SelectionRegistrar.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/SelectionRegistrarImpl.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/SimpleLayout.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/TextPreparedSelection.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/TextSelectionColors.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/TextSelectionDelegate.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/copypasta/selection/TextSelectionMouseDetector.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/StaticTextSelectionModifierController.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/TextInlineContentLayoutDrawModifier.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/TextInlineContentLayoutDrawParams.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionAdjustment.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionMode.kt

https://android-review.googlesource.com/2366929

ap...@google.com <ap...@google.com> #12Jan 10, 2023 02:58AM

Project: platform/frameworks/support
Branch: androidx-main

commit c4a2afae6c6487104d4a930b8165f142cc04389b
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Dec 21 13:38:57 2022

Fix inline content and enable tests

This is feature complete TextUsingModifier

Bug:

b/246960758

Test: ./gradlew :com:found--d-n-s-newtext:cAT
Change-Id: I788ebe18d09d44b2ad784853e1b0e11dc7bfbee3

M compose/foundation/foundation-newtext/src/androidAndroidTest/kotlin/androidx/compose/foundation/newtext/text/CoreTextInlineContentTest.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/AnnotatedStringResolveInlineContent.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/MultiParagraphLayoutCache.kt

https://android-review.googlesource.com/2366889

ap...@google.com <ap...@google.com> #13Jan 11, 2023 08:12PM

Project: platform/frameworks/support
Branch: androidx-main

commit cd4c15184eedd3ccb6136ccb1ba2c8ab53f6d9b1
Author: Sean McQuillan <seanmcq@google.com>
Date: Mon Jan 09 18:52:04 2023

AnnotatedString now stores internal nullable lists

This avoids allocations during all map/sort etc operations when empty.

In Composition this saves two allocs for Text("Ok")

// before
300 allocs
// after
298 allocs

Test: :com:ui:ui-text:cAT :com:ui:ui-text:test
Test: bench
Bug:

b/246960758

Change-Id: I5a0cd09e174a4e6d0842a1480b1cb55bfb0ea767

M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidAccessibilitySpannableString.android.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/AnnotatedString.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
M compose/ui/ui-text/src/jvmMain/kotlin/androidx/compose/ui/text/JvmAnnotatedString.jvm.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/AnnotatedStringBuilderTest.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/AnnotatedStringTest.kt

https://android-review.googlesource.com/2380668

ap...@google.com <ap...@google.com> #14Jan 11, 2023 08:12PM

Project: platform/frameworks/support
Branch: androidx-main

commit 383a62d168407ffee3590928cbe651cc87e0de80
Author: Sean McQuillan <seanmcq@google.com>
Date: Mon Jan 09 17:04:21 2023

Remove OnGloballyPositioned overhead from TextUsingBenchmark

This does not hit any profiled benchmarks, but will reduce the overall
cost of Text on a screen.

Test: bench
Bug:

b/246960758

Change-Id: Ic41a58bf39f02eca7b5bca998893093623ab05bf

M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/TextUsingModifier.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/SelectableStaticTextModifier.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/StaticTextModifier.kt

https://android-review.googlesource.com/2380666

ap...@google.com <ap...@google.com> #15Jan 12, 2023 03:38PM

Project: platform/frameworks/support
Branch: androidx-main

commit ba0972437dc77a2da386c15f98093cf0028ae188
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jan 11 17:20:01 2023

Rename modifier classes in preparation for String|AnnotatedString

Bug:

b/246960758

Change-Id: Ifa262aa01150b0cea5373881ccb51d9498ae2d2e

M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/SelectableTextAnnotatedStringElement.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/SelectableTextAnnotatedStringNode.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/TextAnnotatedStringElement.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/TextAnnotatedStringNode.kt

https://android-review.googlesource.com/2385533

ap...@google.com <ap...@google.com> #16Jan 12, 2023 03:38PM

Project: platform/frameworks/support
Branch: androidx-main

commit c33f346f6403266ee3fd76e34a0a9da749175310
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jan 11 14:59:05 2023

Refactor StaticTextModifier to avoid params alloc

Instead, element directly mutates node.

LayoutCache became mutable as well.

// after
Connected to process 29220 on device 'google-pixel_3a_xl-8C1AX00FLZ'.

154,779 ns 127 allocs trace ModifierAllAppsSetText.recomposeOnly[size=2]
871,749 ns 297 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=2]
110,276 ns 126 allocs trace ModifierAllAppsSetText.recomposeOnly[size=16]
724,428 ns 296 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=16]
60,532 ns 126 allocs trace ModifierAllAppsSetText.recomposeOnly[size=32]
487,778 ns 296 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=32]
58,389 ns 126 allocs trace ModifierAllAppsSetText.recomposeOnly[size=64]
545,027 ns 323 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=64]

// before
171,664 ns 128 allocs trace ModifierAllAppsSetText.recomposeOnly[size=2]
1,149,593 ns 299 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=2]
118,190 ns 127 allocs trace ModifierAllAppsSetText.recomposeOnly[size=16]
813,664 ns 298 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=16]
59,823 ns 127 allocs trace ModifierAllAppsSetText.recomposeOnly[size=32]
541,924 ns 298 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=32]
57,761 ns 127 allocs trace ModifierAllAppsSetText.recomposeOnly[size=64]
575,203 ns 324 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=64]

Bug:

b/246960758

Test: ./gradlew :com:found:found-d-n-s-newtext:test cAT
Change-Id: Id83cb48cfcf4f9d5017d7045d3babeeb3fbe6f3e

M compose/foundation/foundation-newtext/src/androidAndroidTest/kotlin/androidx/compose/foundation/newtext/text/modifiers/MultiParagraphLayoutCacheTest.kt
M compose/foundation/foundation-newtext/src/androidAndroidTest/kotlin/androidx/compose/foundation/newtext/text/modifiers/MultiParagraphLayoutCacheWidthWithLetterSpacingTest.kt
M compose/foundation/foundation-newtext/src/androidAndroidTest/kotlin/androidx/compose/foundation/newtext/text/modifiers/TextLayoutResultIntegrationTest.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/TextUsingModifier.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/MinMaxLinesCoercer.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/MultiParagraphLayoutCache.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/SelectableStaticTextModifier.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/SelectableTextAnnotatedStringElement.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/SelectionController.kt
D compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/StaticTextLayoutDrawParams.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/StaticTextModifier.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/TextAnnotatedStringElement.kt
M compose/foundation/foundation-newtext/src/test/kotlin/androidx/compose/foundation/newtext/text/modifiers/MultiParagraphLayoutCacheTest.kt
D compose/foundation/foundation-newtext/src/test/kotlin/androidx/compose/foundation/newtext/text/modifiers/StaticTextLayouDrawParamsTest.kt

https://android-review.googlesource.com/2385532

ap...@google.com <ap...@google.com> #17Jan 17, 2023 10:25PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9e1aa8ac0bf298ea252b9251930211d4a83a8dd5
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Jan 12 13:05:47 2023

Split String to a optimized path

Jump directly to Paragraph, skipping MultiParagraph

/// before
155,091 ns 127 allocs trace ModifierAllAppsSetText.recomposeOnly[size=2]
1,202,912 ns 297 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=2]
110,556 ns 126 allocs trace ModifierAllAppsSetText.recomposeOnly[size=16]
722,395 ns 296 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=16]
59,376 ns 126 allocs trace ModifierAllAppsSetText.recomposeOnly[size=32]
558,085 ns 296 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=32]
58,667 ns 126 allocs trace ModifierAllAppsSetText.recomposeOnly[size=64]
618,217 ns 322 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=64]

/// after
154,641 ns 126 allocs trace ModifierAllAppsSetText.recomposeOnly[size=2]
836,262 ns 269 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=2]
111,169 ns 125 allocs trace ModifierAllAppsSetText.recomposeOnly[size=16]
639,055 ns 268 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=16]
59,712 ns 125 allocs trace ModifierAllAppsSetText.recomposeOnly[size=32]
469,161 ns 268 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=32]
58,248 ns 125 allocs trace ModifierAllAppsSetText.recomposeOnly[size=64]
522,301 ns 294 allocs trace ModifierAllAppsSetText.recomposeMeasureLayout[size=64]

Bug:

b/246960758

Test: ./gradlew :com:found:found-d-n-s-newtext:cAT test
Change-Id: I39dc3eaa3e2ba585d6a57b804e6d6da3aa973966

M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/TextUsingModifier.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/ParagraphLayoutCache.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/TextStringSimpleElement.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/TextStringSimpleNode.kt

https://android-review.googlesource.com/2386898

se...@google.com <se...@google.com> Feb 17, 2023 09:03PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #18Mar 23, 2023 05:35PM

Project: platform/frameworks/support
Branch: androidx-main

commit 90f4c99038ccfcfd3f004bc54b666b936de0dda2
Author: Sean McQuillan <seanmcq@google.com>
Date: Tue Mar 21 13:16:22 2023

Modifier based Text now correctly computes maxLines

Allow Paragaraph to decide maxLines for static text, like old BasicText.

Bug:

b/246960758

Test: :com:found:found:cAT
Change-Id: Iba8e03806a7a69cf7558bb1a966f0c080d2288d1

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCacheTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/ParagraphLayoutCacheTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MinLinesConstrainer.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCache.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/ParagraphLayoutCache.kt

https://android-review.googlesource.com/2500945

ap...@google.com <ap...@google.com> #19Mar 23, 2023 05:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3c50497658bbee90a40a88a3647ba1c485782d48
Author: Sean McQuillan <seanmcq@google.com>
Date: Mon Mar 20 14:23:18 2023

Enable the new Modifier-backed Text by default

Bug:

b/246960758

Test: cAT

Change-Id: Iada234d046dffb92e45c1a910f6976aa1dd339cf

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicText.kt

https://android-review.googlesource.com/2498396

se...@google.com <se...@google.com> Mar 23, 2023 06:09PM

Marked as fixed.

na...@google.com <na...@google.com> #20Apr 5, 2023 06:28PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.5.0-alpha02

ap...@google.com <ap...@google.com> #21Apr 27, 2023 03:03PM

Project: platform/frameworks/support
Branch: androidx-main

commit a79c4d456ce18733d152c08a72781f84af8bb8e0
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Apr 26 13:42:00 2023

Remove old text stack, stabilizing Text for 1.5 release.

This removes the old text stack completely, in preparation for the 1.5 release.

Bug:

b/246960758

Test: ./gradle :com:found:found:[test|cAT]
Relnote: "New text stack is newly stable in 1.5."
Relnote: "NewTextRendering1_5 configuration option is removed"
Change-Id: Id5f40ede246efd5679fde7500a7f90e2b6faa7d9

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/TextUsingModifierMinMaxLinesTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/BasicTextSemanticsTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleNodeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/AnnotatedStringResolveInlineContent.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicText.kt
D compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextDelegate.kt
D compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextUsingModifier.kt
D compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextControllerTest.kt
D compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextSelectionLongPressDragTest.kt
D compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextStateTest.kt
M compose/integration-tests/demos/src/main/java/androidx/compose/integration/demos/DemoApp.kt
M tv/tv-material/src/main/java/androidx/tv/material3/Text.kt

https://android-review.googlesource.com/2566214

pr...@google.com <pr...@google.com> #22Jun 8, 2023 01:31AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha07

Issue 246960758

Description

Issue summary

Comments

se...@google.com <se...@google.com> Sep 15, 2022 05:36PM

ap...@google.com <ap...@google.com> #2Dec 20, 2022 12:09AM

ap...@google.com <ap...@google.com> #3Dec 20, 2022 12:16AM

ap...@google.com <ap...@google.com> #4Dec 20, 2022 10:16PM

ap...@google.com <ap...@google.com> #5Dec 20, 2022 11:36PM

ap...@google.com <ap...@google.com> #6Jan 10, 2023 02:58AM

ap...@google.com <ap...@google.com> #7Jan 10, 2023 02:58AM

ap...@google.com <ap...@google.com> #8Jan 10, 2023 02:58AM

ap...@google.com <ap...@google.com> #9Jan 10, 2023 02:58AM

ap...@google.com <ap...@google.com> #10Jan 10, 2023 02:58AM

ap...@google.com <ap...@google.com> #11Jan 10, 2023 02:58AM

ap...@google.com <ap...@google.com> #12Jan 10, 2023 02:58AM

ap...@google.com <ap...@google.com> #13Jan 11, 2023 08:12PM

ap...@google.com <ap...@google.com> #14Jan 11, 2023 08:12PM

ap...@google.com <ap...@google.com> #15Jan 12, 2023 03:38PM

ap...@google.com <ap...@google.com> #16Jan 12, 2023 03:38PM

ap...@google.com <ap...@google.com> #17Jan 17, 2023 10:25PM

se...@google.com <se...@google.com> Feb 17, 2023 09:03PM

ap...@google.com <ap...@google.com> #18Mar 23, 2023 05:35PM

ap...@google.com <ap...@google.com> #19Mar 23, 2023 05:37PM

se...@google.com <se...@google.com> Mar 23, 2023 06:09PM

na...@google.com <na...@google.com> #20Apr 5, 2023 06:28PM

ap...@google.com <ap...@google.com> #21Apr 27, 2023 03:03PM

pr...@google.com <pr...@google.com> #22Jun 8, 2023 01:31AM

Add comment

Issue metadata