IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit a330c0d3bcdd41326f37968a60e6084ad4a2e32c
Author: Chet Haase <chet@google.com>
Date:   Wed Jul 05 07:26:46 2023

    Convert APIs using PointF to use Float instead
   
    PointF is a convenient mechanism for passing around x.y values
    representing 2D points. But there are downsides, including:
    - Converting to PointF: You may not have the data in PointF form
    to begin with, so using an API which takes PointF requires converting
    the data  to that form (including allocating a PointF object every time)
    - Mutability: Point structures can be mutated internally, causing
    unpredictability in what that mutation means. Should the library
    react to those changes? Ignore them? Do defensive copies (requiring
    even more allocations)? Using primitive types like Float make the
    behavior more obvious (by making the data inherently immutable).
    - Allocations: Whenever we use object types, there are necessarily
    allocations on the Java heap for them. This puts pressure on the GC
    at both allocation and collection time. Given the amount of points
    being passed around (especially at morph creation time, when curves
    are being split and created), this causes a lot of PointF objects to
    be allocated (even temporarily). Using Float avoids that problem.
   
    Also fixed bug with unclosed paths causing discontinuity at the
    start/end point.
   
    Bug: 276466399
    Bug: 290254314
    Test: integration and unit tests pass
    Relnote: PointF parameters changed to Float pairs
    Change-Id: Id4705d27c7be31b26ade8186b99fffe2e2f8450e

M       graphics/graphics-shapes/api/current.txt
M       graphics/graphics-shapes/api/restricted_current.txt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicShapeTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonMeasureTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/RoundedPolygonTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/ShapesTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/TestUtils.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Cubic.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/CubicShape.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FeatureMapping.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FloatMapping.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Morph.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/PolygonMeasure.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/RoundedPolygon.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Shapes.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Utils.kt
M       graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/DebugDraw.kt
M       graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/ShapeEditor.kt
M       graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/MaterialShapes.kt

https://android-review.googlesource.com/2649119

PointF was the main (possibly only) mutability issue, marking this as fixed

Project: platform/frameworks/support
Branch: androidx-main

commit caa9b867e0e4c4573e3b1b5deae61c7266f6a4d8
Author: Sean McQuillan <seanmcq@google.com>
Date:   Thu Apr 27 14:47:49 2023

    Add color: () -> Color override to BasicText
   
    This allows
    1. Text to set color without merging TextStyle
    2. Apps to animate Color efficiently, skipping to draw
   
    % speedups:
    SetText.recompose: 2.3% min, 4.5% max 2.6% median
    LazyList changed text: 1.9% min, 3.9% max, 1.6% median
   
    Bug: b/246961787
    Test: ./gradlew :com:found:found:cAT
    Test: ./gradlew :com:found:found:test
    Relnote: "Add color prameter to BasicText to allow efficiently animating or setting text color."
    Change-Id: Iffd88c4c2de7f6922add66b1fc46bdff8853c3f6

M       compose/compiler/compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/TargetAnnotationsTransformTests.kt
M       compose/foundation/foundation/api/current.txt
M       compose/foundation/foundation/api/public_plus_experimental_current.txt
M       compose/foundation/foundation/api/restricted_current.txt
M       compose/foundation/foundation/benchmark/src/androidTest/java/androidx/compose/foundation/benchmark/text/lazyhosted/TextLazyReuse.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/MemoryAllocs.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextAnimationDemo.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/BasicTextScreenshotTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/NodeInvalidationTestParent.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringNodeInvalidationTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleNodeInvalidationTest.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicText.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/SelectableTextAnnotatedStringElement.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/SelectableTextAnnotatedStringNode.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringElement.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringNode.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleElement.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleNode.kt
M       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/BasicTextPaparazziTest.kt
M       compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/TextTest.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt
M       compose/ui/ui-graphics/api/current.txt
M       compose/ui/ui-graphics/api/public_plus_experimental_current.txt
M       compose/ui/ui-graphics/api/restricted_current.txt
M       compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Color.kt
M       compose/ui/ui-text/api/current.txt
M       compose/ui/ui-text/api/public_plus_experimental_current.txt
M       compose/ui/ui-text/api/restricted_current.txt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/SpanStyle.kt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextStyle.kt
M       tv/tv-material/src/androidTest/java/androidx/tv/material3/TextTest.kt

https://android-review.googlesource.com/2568972

Project: platform/frameworks/support
Branch: androidx-main

commit c54f8ca1a95ee55cf69722cb441b240599e18eb3
Author: Sean McQuillan <seanmcq@google.com>
Date:   Fri Apr 28 15:57:41 2023

    Add brush: () -> Brush override to BasicText
   
    This allows for more efficiently animating brush when using BasicText.
   
    Bug: b/246961787
    Test: ./gradlew :com:found:found:cAT
    Test: ./gradlew :com:found:found:test
    Relnote: "Add brush, alpha prameter to BasicText to allow efficiently animating or setting text brush."
    Relnote: "Define box-free lambda types for Float, Double, Long, Int, Short in :ui:ui-unit"
   
    Change-Id: I6f18d24248b890d7c1fd4d0a2fac1c49918b2f2b

M       compose/foundation/foundation/api/current.txt
M       compose/foundation/foundation/api/public_plus_experimental_current.txt
M       compose/foundation/foundation/api/restricted_current.txt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextAnimationDemo.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/NodeInvalidationTestParent.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringNodeInvalidationTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleNodeInvalidationTest.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicText.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/SelectableTextAnnotatedStringElement.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/SelectableTextAnnotatedStringNode.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringElement.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringNode.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleElement.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleNode.kt
M       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/BasicTextPaparazziTest.kt
M       compose/ui/ui-unit/api/current.txt
M       compose/ui/ui-unit/api/public_plus_experimental_current.txt
M       compose/ui/ui-unit/api/restricted_current.txt
A       compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/UnboxedLambdas.kt

https://android-review.googlesource.com/2573493

Project: platform/frameworks/support
Branch: androidx-main

commit 689dcf6365ae412fbd1c7bc7280fb10b30496bdd
Author: Sean McQuillan <seanmcq@google.com>
Date:   Mon May 01 15:34:45 2023

    Add perf notes to Text composable body
   
    Each line is micro-optimized, document rationale.
   
    Bug: b/246961787
    Test: n/a is comemnt
    Change-Id: I357cd8c8256c86896b61ae1e5058986936930989

M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt

https://android-review.googlesource.com/2574811

Project: platform/frameworks/support
Branch: androidx-main

commit db9de4e9b8f0c2e8b0c6ad695140ddfe5b8216b0
Author: Sean McQuillan <seanmcq@google.com>
Date:   Tue Apr 25 15:25:25 2023

    Apply merged text style optimization to wear
   
    Bug: b/246961787
    Test: n/a
    Change-Id: I747d9056af14622d049ca5f31ba27f4e262bb3da

M       wear/compose/compose-material-core/src/commonMain/kotlin/androidx/wear/compose/materialcore/Text.kt

https://android-review.googlesource.com/2563650