Identify and iterate on execution cost of Text in LazyList [246961787]

Fixed

Bug

Status Update

No update yet.

Description

se...@google.com

created issue #1

Sep 15, 2022 05:41PM

Explore performance options in LazyList usage.

Add subtickets for optimization options.

Comments

se...@google.com <se...@google.com> Sep 15, 2022 05:41PM

Reassigned to se...@google.com.

ap...@google.com <ap...@google.com> #2Mar 27, 2023 07:47PM

Project: platform/frameworks/support
Branch: androidx-main

commit 01d820c31ac0d096d3e23e9559367eba89b71eca
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Mar 23 13:48:43 2023

Emulate LazyList reuse behavior to profile Text

Bug:

b/246961787

Test: is a test

Change-Id: I46d6b93e75ed99c6f6603aa914c895a4acb4b3d2

A compose/foundation/foundation/benchmark/src/androidTest/java/androidx/compose/foundation/benchmark/text/lazyhosted/TextLazyReuse.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/MemoryAllocs.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt

https://android-review.googlesource.com/2506019

ap...@google.com <ap...@google.com> #3Apr 26, 2023 07:44PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0e1073c4c181967a4473e6363d6adb703d4aad47
Author: Sean McQuillan <seanmcq@google.com>
Date: Tue Apr 25 15:22:17 2023

Apply text merge optimization to tv

Bug:

b/246961787

Test: n/a
Change-Id: Ifcbeeebe6a817b794641d9575ae03e33e4b6dc8b

M tv/tv-material/build.gradle
M tv/tv-material/src/main/java/androidx/tv/material3/Text.kt

https://android-review.googlesource.com/2563418

ap...@google.com <ap...@google.com> #4Apr 26, 2023 07:44PM

Project: platform/frameworks/support
Branch: androidx-main

commit b4846e5f0dd7d6f85d61b0d8f84fa5a575a7951d
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Apr 20 08:08:05 2023

Optimize TextStyle.merge

This reduces the overhead introduced by Text() composable which is primarily responsible for merging the incoming text styles.

// after
71,190 ns 0 allocs trace TextLazyReuseChangedText.draw
627,212 ns 143 allocs trace TextLazyReuseChangedText.recomposeOnly
698,883 ns 146 allocs trace TextLazyReuseChangedText.recomposeMeasureLayout
73,877 ns 0 allocs trace TextLazyReuseChangedText.draw
634,369 ns 143 allocs trace TextLazyReuseChangedText.recomposeOnly
730,594 ns 147 allocs trace TextLazyReuseChangedText.recomposeMeasureLayout

// before
73,887 ns 0 allocs trace TextLazyReuseSameText.draw
638,475 ns 146 allocs trace TextLazyReuseSameText.recomposeOnly
769,742 ns 148 allocs trace TextLazyReuseSameText.recomposeMeasureLayout
72,858 ns 0 allocs trace TextLazyReuseChangedText.draw
652,566 ns 146 allocs trace TextLazyReuseChangedText.recomposeOnly
805,109 ns 150 allocs trace TextLazyReuseChangedText.recomposeMeasureLayout

Bug:

b/246961787

Test: ./gradlew :ui:ui-text:test :ui:ui-text:cAT
Relnote: "Added optimized TextStyle.merge(...) with full parameter list."

Change-Id: Iad23419809af1c7405ba9a9d42569521e7647034

M compose/foundation/foundation/benchmark/src/androidTest/java/androidx/compose/foundation/benchmark/text/lazyhosted/TextLazyReuse.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/MemoryAllocs.kt
M compose/material/material/build.gradle
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt
M compose/material3/material3/build.gradle
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Text.kt
M compose/runtime/runtime/src/commonTest/kotlin/androidx/compose/runtime/GroupSizeValidationTests.kt
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/ParagraphStyle.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/SpanStyle.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextStyle.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextStyleTest.kt

https://android-review.googlesource.com/2551110

ap...@google.com <ap...@google.com> #5Apr 29, 2023 01:43AM

Project: platform/frameworks/support
Branch: androidx-main

commit caa9b867e0e4c4573e3b1b5deae61c7266f6a4d8
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Apr 27 14:47:49 2023

Add color: () -> Color override to BasicText

This allows
1. Text to set color without merging TextStyle
2. Apps to animate Color efficiently, skipping to draw

% speedups:
SetText.recompose: 2.3% min, 4.5% max 2.6% median
LazyList changed text: 1.9% min, 3.9% max, 1.6% median

Bug:

b/246961787

Test: ./gradlew :com:found:found:cAT
Test: ./gradlew :com:found:found:test
Relnote: "Add color prameter to BasicText to allow efficiently animating or setting text color."
Change-Id: Iffd88c4c2de7f6922add66b1fc46bdff8853c3f6

M compose/compiler/compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/TargetAnnotationsTransformTests.kt
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/benchmark/src/androidTest/java/androidx/compose/foundation/benchmark/text/lazyhosted/TextLazyReuse.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/MemoryAllocs.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextAnimationDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/BasicTextScreenshotTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/NodeInvalidationTestParent.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringNodeInvalidationTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleNodeInvalidationTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicText.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/SelectableTextAnnotatedStringElement.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/SelectableTextAnnotatedStringNode.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringElement.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringNode.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleElement.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleNode.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/BasicTextPaparazziTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/TextTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt
M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/public_plus_experimental_current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Color.kt
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/SpanStyle.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextStyle.kt
M tv/tv-material/src/androidTest/java/androidx/tv/material3/TextTest.kt

https://android-review.googlesource.com/2568972

ap...@google.com <ap...@google.com> #6Apr 29, 2023 02:04AM

Project: platform/frameworks/support
Branch: androidx-main

commit c54f8ca1a95ee55cf69722cb441b240599e18eb3
Author: Sean McQuillan <seanmcq@google.com>
Date: Fri Apr 28 15:57:41 2023

Add brush: () -> Brush override to BasicText

This allows for more efficiently animating brush when using BasicText.

Bug:

b/246961787

Test: ./gradlew :com:found:found:cAT
Test: ./gradlew :com:found:found:test
Relnote: "Add brush, alpha prameter to BasicText to allow efficiently animating or setting text brush."
Relnote: "Define box-free lambda types for Float, Double, Long, Int, Short in :ui:ui-unit"

Change-Id: I6f18d24248b890d7c1fd4d0a2fac1c49918b2f2b

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextAnimationDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/NodeInvalidationTestParent.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringNodeInvalidationTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleNodeInvalidationTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicText.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/SelectableTextAnnotatedStringElement.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/SelectableTextAnnotatedStringNode.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringElement.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringNode.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleElement.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleNode.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/BasicTextPaparazziTest.kt
M compose/ui/ui-unit/api/current.txt
M compose/ui/ui-unit/api/public_plus_experimental_current.txt
M compose/ui/ui-unit/api/restricted_current.txt
A compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/UnboxedLambdas.kt

https://android-review.googlesource.com/2573493

ap...@google.com <ap...@google.com> #7May 2, 2023 08:30PM

Project: platform/frameworks/support
Branch: androidx-main

commit 689dcf6365ae412fbd1c7bc7280fb10b30496bdd
Author: Sean McQuillan <seanmcq@google.com>
Date: Mon May 01 15:34:45 2023

Add perf notes to Text composable body

Each line is micro-optimized, document rationale.

Bug:

b/246961787

Test: n/a is comemnt
Change-Id: I357cd8c8256c86896b61ae1e5058986936930989

M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt

https://android-review.googlesource.com/2574811

ap...@google.com <ap...@google.com> #8May 3, 2023 02:57PM

Project: platform/frameworks/support
Branch: androidx-main

commit db9de4e9b8f0c2e8b0c6ad695140ddfe5b8216b0
Author: Sean McQuillan <seanmcq@google.com>
Date: Tue Apr 25 15:25:25 2023

Apply merged text style optimization to wear

Bug:

b/246961787

Test: n/a
Change-Id: I747d9056af14622d049ca5f31ba27f4e262bb3da

M wear/compose/compose-material-core/src/commonMain/kotlin/androidx/wear/compose/materialcore/Text.kt

https://android-review.googlesource.com/2563650

se...@google.com <se...@google.com> May 25, 2023 03:07PM

Marked as fixed.

pr...@google.com <pr...@google.com> #9Jun 8, 2023 01:30AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha07

Issue 246961787

Description

Issue summary

Comments

se...@google.com <se...@google.com> Sep 15, 2022 05:41PM

ap...@google.com <ap...@google.com> #2Mar 27, 2023 07:47PM

ap...@google.com <ap...@google.com> #3Apr 26, 2023 07:44PM

ap...@google.com <ap...@google.com> #4Apr 26, 2023 07:44PM

ap...@google.com <ap...@google.com> #5Apr 29, 2023 01:43AM

ap...@google.com <ap...@google.com> #6Apr 29, 2023 02:04AM

ap...@google.com <ap...@google.com> #7May 2, 2023 08:30PM

ap...@google.com <ap...@google.com> #8May 3, 2023 02:57PM

se...@google.com <se...@google.com> May 25, 2023 03:07PM

pr...@google.com <pr...@google.com> #9Jun 8, 2023 01:30AM

Add comment

Issue metadata