Status Update
No update yet.
Comments
se...@google.com
Branch: androidx-master-dev
commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020
Semantics no-op cleanups
Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:
- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".
- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)
- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)
Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."
Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc
M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt
se...@google.com
Pixel 6 TP1A
se...@google.com
Context from dupin@ introduced with VF in ag/13832548
It looks like we are missing specializations there. Rod can you advise?
ny...@google.com
google-sans* and google-sans-text* differ only in 'opsz' and that is expected. Both the styles/variations are part of GoogleSans-Regular.ttf.
Can you compare 'G' in google-sans-medium and google-sans-text-medium? That should give us an idea if the right variation is being rendered.
cs...@google.com
The Google Sans to Google Sans Text variable font style transition is defined on the opsz axis and takes place at the 17/18 transition point (>= 18 is GS, < 18 is GST). There are indeed letterform changes along the opsz axis transition. The easiest one to use for GS vs. GST comparisons is the upper case G (U+0047). It has a round logo form in GS and a more condensed shape with a spur on the right side heading down to the baseline in GST. The configurations in
The axis values for GS Text Medium weight should be:
<axis tag="GRAD" stylevalue="0"/>
<axis tag="opsz" stylevalue="17.0"/>
<axis tag="wght" stylevalue="500"/>
and use the GoogleSans-Regular.ttf variable font for Roman and GoogleSans-Italic.ttf variable font for Italic. It looks like they are properly defined for google-sans-text-medium in the fonts_customization.xml file that you linked in
Is the concern here that you are seeing file paths that suggest you are using "Google Sans" rather than "Google Sans Text", or that you are seeing text formatted with the "Google Sans" style rather than the "Google Sans Text" style?
se...@google.com
Ack. Thank you for the explination.
I've confirmed the font renders correctly.
se...@google.com
Attached screenshot of basic Compose app
Column {
Text(
text = "GGGGGG google-sans",
fontSize = 60.sp,
fontFamily = FontFamily(
Font(
DeviceFontFamilyName("google-sans"),
)
)
)
Text(
text = "GGGGG google-sans-text",
fontSize = 60.sp,
fontFamily = FontFamily(
Font(
DeviceFontFamilyName("google-sans-text"),
)
)
)
}
se...@google.com
Font file
se...@google.com
Same result for google-sans-text-medium
Text(
text = "GGGGG google-sans-text-medium",
fontSize = 60.sp,
fontFamily = FontFamily(
Font(
DeviceFontFamilyName("google-sans-text-medium"),
)
)
)
pa...@google.com
pa...@google.com
se...@google.com
I've confirmed on Pixel 6 that "google-sans-text-medium" loads a GS text font - see attached.
se...@google.com
Can you get a minimal repro for this one? It looks likely that it could just be using the wrong font at that application.
se...@google.com
Reproduced by loading in background. Appears related to DeviceFontFamilyName variation setting from a background thread leaking somehow.
se...@google.com
For Google Sans Text please specialize the opsz when loading it.
You can either
- Disable load-time font variation settings
@OptIn(ExperimentalTextApi::class)
val GoogleSansText500Medium = Font(
DeviceFontFamilyName("google-sans-text-medium"),
weight = FontWeight.W500,
variationSettings = FontVariation.Settings() /* don't specialize font variation, leaving opsz alone */
)
- Intentionally specialize the font variation settings, including explicit opsz
@OptIn(ExperimentalTextApi::class)
val GoogleSansText500Medium = Font(
DeviceFontFamilyName("google-sans-text-medium"),
weight = FontWeight.W500,
variationSettings = FontVariation.Settings(
FontWeight.W500,
FontStyle.Companion.Normal,
// opsz <=17f for Google Sans Text
// opsz >=18f for Google Sans
FontVariation.Setting("opsz", 17f)
)
)
What's going on
When opsz is not provided, the default behavior of specializing variation settings to (Weight Style) causes opsz to be reset to the default value, which is "Google Sans"
By explicitly skipping variation settings, or setting opsz you're ensuring that either (1) the system loaded typeface or (2) the desired specialization is used exactly.
ap...@google.com
Branch: androidx-main
commit e273cfae8eb87e327dfa09d488f8343a2ba98221
Author: Sean McQuillan <seanmcq@google.com>
Date: Fri Sep 23 13:14:14 2022
DeviceFontFamilyName does not set VariationSettings by default
Removed automtic fontVariationSettings from DefaultFontFamilyName based fonts as they caused weird behavior when specializing fonts from system.
1. `wght` would be set on all fonts in a font family, effectively making weight dispatch a no-op
2. XML-defined axis restrictions e.g. to `opsz` that made the same font file display multiple Types were clobbered, causing the "wrong font" to display.
Added warning to developer that they shuold configure all necessary axis if setting to not-default.
Bug:
Test: ./gradlew :com:ui:ui-text:cAT
Relnote: "DeviceFontFamilyName fonts will not configure `wght` and `ital` variation settings by default, instead using platform setting for loaded Typeface."
Change-Id: Ia7a6db95a402e7528d977ec67b4ed3992bdb7a5d
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/DeviceFontFamilyNameFontTest.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/DeviceFontFamilyNameFont.kt
na...@google.com
This bug was linked in a change in the following release(s):
androidx.compose.ui:ui-text:1.3.0-rc01
Description
adb pull /product/etc/fonts_customization.xml
shows "google-sans-text-medium" contains GoogleSans-Regular.ttf . Should this be GoogleSansText-Regular.ttf instead?