Status Update
Comments
se...@google.com <se...@google.com> #2
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
se...@google.com <se...@google.com> #3
se...@google.com <se...@google.com> #4
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ny...@google.com <ny...@google.com> #5
google-sans* and google-sans-text* differ only in 'opsz' and that is expected. Both the styles/variations are part of GoogleSans-Regular.ttf.
Can you compare 'G' in google-sans-medium and google-sans-text-medium? That should give us an idea if the right variation is being rendered.
cs...@google.com <cs...@google.com> #6
The Google Sans to Google Sans Text variable font style transition is defined on the opsz axis and takes place at the 17/18 transition point (>= 18 is GS, < 18 is GST). There are indeed letterform changes along the opsz axis transition. The easiest one to use for GS vs. GST comparisons is the upper case G
(U+0047). It has a round logo form in GS and a more condensed shape with a spur on the right side heading down to the baseline in GST. The configurations in
The axis values for GS Text Medium weight should be:
<axis tag="GRAD" stylevalue="0"/>
<axis tag="opsz" stylevalue="17.0"/>
<axis tag="wght" stylevalue="500"/>
and use the GoogleSans-Regular.ttf
variable font for Roman and GoogleSans-Italic.ttf
variable font for Italic. It looks like they are properly defined for google-sans-text-medium
in the fonts_customization.xml
file that you linked in
Is the concern here that you are seeing file paths that suggest you are using "Google Sans" rather than "Google Sans Text", or that you are seeing text formatted with the "Google Sans" style rather than the "Google Sans Text" style?
se...@google.com <se...@google.com> #7
Ack. Thank you for the explination.
I've confirmed the font renders correctly.
se...@google.com <se...@google.com> #8
Attached screenshot of basic Compose app
Column {
Text(
text = "GGGGGG google-sans",
fontSize = 60.sp,
fontFamily = FontFamily(
Font(
DeviceFontFamilyName("google-sans"),
)
)
)
Text(
text = "GGGGG google-sans-text",
fontSize = 60.sp,
fontFamily = FontFamily(
Font(
DeviceFontFamilyName("google-sans-text"),
)
)
)
}
se...@google.com <se...@google.com> #9
Font file
se...@google.com <se...@google.com> #10
Same result for google-sans-text-medium
Text(
text = "GGGGG google-sans-text-medium",
fontSize = 60.sp,
fontFamily = FontFamily(
Font(
DeviceFontFamilyName("google-sans-text-medium"),
)
)
)
pa...@google.com <pa...@google.com> #11
pa...@google.com <pa...@google.com>
se...@google.com <se...@google.com> #12
I've confirmed on Pixel 6 that "google-sans-text-medium" loads a GS text font - see attached.
se...@google.com <se...@google.com> #13
Can you get a minimal repro for this one? It looks likely that it could just be using the wrong font at that application.
se...@google.com <se...@google.com> #14
Reproduced by loading in background. Appears related to DeviceFontFamilyName variation setting from a background thread leaking somehow.
se...@google.com <se...@google.com> #15
For Google Sans Text please specialize the opsz
when loading it.
You can either
- Disable load-time font variation settings
@OptIn(ExperimentalTextApi::class)
val GoogleSansText500Medium = Font(
DeviceFontFamilyName("google-sans-text-medium"),
weight = FontWeight.W500,
variationSettings = FontVariation.Settings() /* don't specialize font variation, leaving opsz alone */
)
- Intentionally specialize the font variation settings, including explicit opsz
@OptIn(ExperimentalTextApi::class)
val GoogleSansText500Medium = Font(
DeviceFontFamilyName("google-sans-text-medium"),
weight = FontWeight.W500,
variationSettings = FontVariation.Settings(
FontWeight.W500,
FontStyle.Companion.Normal,
// opsz <=17f for Google Sans Text
// opsz >=18f for Google Sans
FontVariation.Setting("opsz", 17f)
)
)
What's going on
When opsz
is not provided, the default behavior of specializing variation settings to (Weight Style) causes opsz
to be reset to the default value, which is "Google Sans"
By explicitly skipping variation settings, or setting opsz
you're ensuring that either (1) the system loaded typeface or (2) the desired specialization is used exactly.
ap...@google.com <ap...@google.com> #16
Branch: androidx-main
commit e273cfae8eb87e327dfa09d488f8343a2ba98221
Author: Sean McQuillan <seanmcq@google.com>
Date: Fri Sep 23 13:14:14 2022
DeviceFontFamilyName does not set VariationSettings by default
Removed automtic fontVariationSettings from DefaultFontFamilyName based fonts as they caused weird behavior when specializing fonts from system.
1. `wght` would be set on all fonts in a font family, effectively making weight dispatch a no-op
2. XML-defined axis restrictions e.g. to `opsz` that made the same font file display multiple Types were clobbered, causing the "wrong font" to display.
Added warning to developer that they shuold configure all necessary axis if setting to not-default.
Bug:
Test: ./gradlew :com:ui:ui-text:cAT
Relnote: "DeviceFontFamilyName fonts will not configure `wght` and `ital` variation settings by default, instead using platform setting for loaded Typeface."
Change-Id: Ia7a6db95a402e7528d977ec67b4ed3992bdb7a5d
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/DeviceFontFamilyNameFontTest.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/DeviceFontFamilyNameFont.kt
na...@google.com <na...@google.com> #17
This bug was linked in a change in the following release(s):
androidx.compose.ui:ui-text:1.3.0-rc01
Description
adb pull /product/etc/fonts_customization.xml
shows "google-sans-text-medium" contains GoogleSans-Regular.ttf . Should this be GoogleSansText-Regular.ttf instead?