Status Update
Comments
se...@google.com <se...@google.com> #2
First of all thanks for this detailed issue.
This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7
. I will look into this.
The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection
and InputMethodManager
documentation. However, this is understandable since TextView
implementation was also not respecting the behavior that is expected from Editors.
Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection
. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.
se...@google.com <se...@google.com> #3
Or is that option not available?
Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.
se...@google.com <se...@google.com> #4
Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.
Compose 1.7 has a bug that causes ANR when the focus is on EditText.
Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus().
Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.
In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.
ny...@google.com <ny...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <
Link:
Fix POBox keyboard issue
Expand for full commit details
Fix POBox keyboard issue
Fix: 373743376
Fix: 329209241
Test: NullableInputConnectionWrapperTest
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1
Files:
- M
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
- M
compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt
Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024
cs...@google.com <cs...@google.com> #6
Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.
se...@google.com <se...@google.com> #7
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.
se...@google.com <se...@google.com> #8
Yes, this fix is planned to be included in a future 1.7.x
release.
se...@google.com <se...@google.com> #9
Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.
se...@google.com <se...@google.com> #10
Same result for google-sans-text-medium
Text(
text = "GGGGG google-sans-text-medium",
fontSize = 60.sp,
fontFamily = FontFamily(
Font(
DeviceFontFamilyName("google-sans-text-medium"),
)
)
)
pa...@google.com <pa...@google.com> #11
pa...@google.com <pa...@google.com>
se...@google.com <se...@google.com> #12
I've confirmed on Pixel 6 that "google-sans-text-medium" loads a GS text font - see attached.
se...@google.com <se...@google.com> #13
Can you get a minimal repro for this one? It looks likely that it could just be using the wrong font at that application.
se...@google.com <se...@google.com> #14
Reproduced by loading in background. Appears related to DeviceFontFamilyName variation setting from a background thread leaking somehow.
se...@google.com <se...@google.com> #15
For Google Sans Text please specialize the opsz
when loading it.
You can either
- Disable load-time font variation settings
@OptIn(ExperimentalTextApi::class)
val GoogleSansText500Medium = Font(
DeviceFontFamilyName("google-sans-text-medium"),
weight = FontWeight.W500,
variationSettings = FontVariation.Settings() /* don't specialize font variation, leaving opsz alone */
)
- Intentionally specialize the font variation settings, including explicit opsz
@OptIn(ExperimentalTextApi::class)
val GoogleSansText500Medium = Font(
DeviceFontFamilyName("google-sans-text-medium"),
weight = FontWeight.W500,
variationSettings = FontVariation.Settings(
FontWeight.W500,
FontStyle.Companion.Normal,
// opsz <=17f for Google Sans Text
// opsz >=18f for Google Sans
FontVariation.Setting("opsz", 17f)
)
)
What's going on
When opsz
is not provided, the default behavior of specializing variation settings to (Weight Style) causes opsz
to be reset to the default value, which is "Google Sans"
By explicitly skipping variation settings, or setting opsz
you're ensuring that either (1) the system loaded typeface or (2) the desired specialization is used exactly.
ap...@google.com <ap...@google.com> #16
Branch: androidx-main
commit e273cfae8eb87e327dfa09d488f8343a2ba98221
Author: Sean McQuillan <seanmcq@google.com>
Date: Fri Sep 23 13:14:14 2022
DeviceFontFamilyName does not set VariationSettings by default
Removed automtic fontVariationSettings from DefaultFontFamilyName based fonts as they caused weird behavior when specializing fonts from system.
1. `wght` would be set on all fonts in a font family, effectively making weight dispatch a no-op
2. XML-defined axis restrictions e.g. to `opsz` that made the same font file display multiple Types were clobbered, causing the "wrong font" to display.
Added warning to developer that they shuold configure all necessary axis if setting to not-default.
Bug:
Test: ./gradlew :com:ui:ui-text:cAT
Relnote: "DeviceFontFamilyName fonts will not configure `wght` and `ital` variation settings by default, instead using platform setting for loaded Typeface."
Change-Id: Ia7a6db95a402e7528d977ec67b4ed3992bdb7a5d
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/DeviceFontFamilyNameFontTest.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/DeviceFontFamilyNameFont.kt
na...@google.com <na...@google.com> #17
This bug was linked in a change in the following release(s):
androidx.compose.ui:ui-text:1.3.0-rc01
Description
adb pull /product/etc/fonts_customization.xml
shows "google-sans-text-medium" contains GoogleSans-Regular.ttf . Should this be GoogleSansText-Regular.ttf instead?