ResourceType lint check is not working for kotlin sources [247025215]

Fixed

Bug

Status Update

No update yet.

Description

ga...@linecorp.com

created issue #1

Sep 16, 2022 02:04AM

DESCRIBE THE ISSUE IN DETAIL:
I'm trying to update minSdk to 26,
and want to fix issues related with behavior change of resource compiler on my app.

For java source codes, lint checker raise ResourceType error,
but for kotlin source codes, lint checker did not raise any error.

STEPS TO REPRODUCE:

clone ResourceType_lint_checker branch from https://github.com/ganadist/VersionCodeDemo

git clone https://github.com/ganadist/VersionCodeDemo -b ResourceType_lint_checker

perform lint checker on command line

cd VersionCodeDemo
./gradlew :app:lintDevelopDebug

Check lint result that lint raise error for TextViewUtil1.java file only, and did not raise error for TextViewUtil2.kt file

app/src/main/java/com/example/myapplication/TextViewUtil1.java:8: Error: Comparing resource types (@StringRes) other than equality is dangerous and usually wrong;  some resource types set top bit which turns the value negative [ResourceType]
      if (resId > 0) {
          ~~~~~~~~~

 Explanation for issues of type "ResourceType":
 Ensures that resource id's passed to APIs are of the right type; for
 example, calling Resources.getColor(R.string.name) is wrong.

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: Any
Version of Gradle Plugin: 7.2.2 or 7.3.0
Version of Gradle: 7.5
Version of Java: OpenJDK 11 / 17
OS: Any

Comments

dy...@google.com <dy...@google.com> Sep 16, 2022 02:09AM

Assigned to an...@google.com.

ba...@google.com <ba...@google.com> Sep 19, 2022 03:43AM

Reassigned to ba...@google.com.

ba...@google.com <ba...@google.com> Sep 20, 2022 11:19PM

Reassigned to bl...@google.com.

bl...@google.com <bl...@google.com> Sep 21, 2022 10:56PM

Accepted by bl...@google.com.

bl...@google.com <bl...@google.com> Sep 22, 2022 09:35PM

Marked as fixed.

ga...@linecorp.com <ga...@linecorp.com> #2Sep 22, 2022 11:00PM

The reason this has not been seen before now is that JDK-8272564 was done for JDK-18 and that it also require min API level 28. The reason the Espresso library expose this is that (most likely) internal Google build tools have JDK-8272564 applied generating invoke-interface on Object methods.

bl...@google.com <bl...@google.com> #3Sep 22, 2022 11:47PM

Project: r8
Branch: main

commit 6041b16a28b5966e6975340c03261c4fef61b794
Author: Søren Gjesse <sgjesse@google.com>
Date: Thu Mar 02 14:39:27 2023

Also apply the rewriting for JDK-8272564 up to Andorid R

Fixes:

b/271408544

Change-Id: I240de7d301677668b9c13b3b49c7b7951e6434b6

M src/main/java/com/android/tools/r8/utils/InternalOptions.java

https://r8-review.googlesource.com/76861

ga...@linecorp.com <ga...@linecorp.com> #4Sep 23, 2022 08:49AM

Project: r8
Branch: main

commit 9e5692c8ce91b3ea3f4199740b41d57c097c9947
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:40:44 2023

Fix test after changing API level for rewriting of JDK-8272564

Bug:

b/271408544

Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653

M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java

https://r8-review.googlesource.com/76885