ResourceType lint check is not working for kotlin sources [247025215]

Fixed

Bug

Status Update

No update yet.

Description

ga...@linecorp.com

created issue #1

Sep 16, 2022 02:04AM

DESCRIBE THE ISSUE IN DETAIL:
I'm trying to update minSdk to 26,
and want to fix issues related with behavior change of resource compiler on my app.

For java source codes, lint checker raise ResourceType error,
but for kotlin source codes, lint checker did not raise any error.

STEPS TO REPRODUCE:

clone ResourceType_lint_checker branch from https://github.com/ganadist/VersionCodeDemo

git clone https://github.com/ganadist/VersionCodeDemo -b ResourceType_lint_checker

perform lint checker on command line

cd VersionCodeDemo
./gradlew :app:lintDevelopDebug

Check lint result that lint raise error for TextViewUtil1.java file only, and did not raise error for TextViewUtil2.kt file

app/src/main/java/com/example/myapplication/TextViewUtil1.java:8: Error: Comparing resource types (@StringRes) other than equality is dangerous and usually wrong;  some resource types set top bit which turns the value negative [ResourceType]
      if (resId > 0) {
          ~~~~~~~~~

 Explanation for issues of type "ResourceType":
 Ensures that resource id's passed to APIs are of the right type; for
 example, calling Resources.getColor(R.string.name) is wrong.

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: Any
Version of Gradle Plugin: 7.2.2 or 7.3.0
Version of Gradle: 7.5
Version of Java: OpenJDK 11 / 17
OS: Any

Comments

dy...@google.com <dy...@google.com> Sep 16, 2022 02:09AM

Assigned to an...@google.com.

ba...@google.com <ba...@google.com> Sep 19, 2022 03:43AM

Reassigned to ba...@google.com.

ba...@google.com <ba...@google.com> Sep 20, 2022 11:19PM

Reassigned to bl...@google.com.

bl...@google.com <bl...@google.com> Sep 21, 2022 10:56PM

Accepted by bl...@google.com.

bl...@google.com <bl...@google.com> Sep 22, 2022 09:35PM

Marked as fixed.

ga...@linecorp.com <ga...@linecorp.com> #2Sep 22, 2022 11:00PM

Thanks for fixing this issue.

It seems this issue was fixed at https://android.googlesource.com/platform/tools/base/+/8654cf2fb and applied on mirror-goog-studio-main branch.

Is it possible to apply this on stable branch?

bl...@google.com <bl...@google.com> #3Sep 22, 2022 11:47PM

Thanks for reporting this issue - we can cherry-pick the fix to Electric Eel Beta 2 or 3.

ga...@linecorp.com <ga...@linecorp.com> #4Sep 23, 2022 08:49AM

FYI:
I created a gradle project to add workaround for AGP 7.3/Dolphin
And applied https://github.com/ganadist/VersionCodeDemo/commit/42ba1512 on ResourceType_lint_checker branch.

And lint can raise errors as intended.

> Task :app:lintDevelopDebug FAILED
app/src/main/java/com/example/myapplication/TextViewUtil1.java:8: Error: Comparing resource types (@StringRes) other than equality is dangerous and usually wrong;  some resource types set top bit which turns the value negative [ResourceType]
        if (resId > 0) {
            ~~~~~~~~~
app/src/main/java/com/example/myapplication/TextViewUtil2.kt:8: Error: Comparing resource types (@StringRes) other than equality is dangerous and usually wrong;  some resource types set top bit which turns the value negative [ResourceType]
        if (resId > 0) {
            ~~~~~~~~~

   Explanation for issues of type "ResourceType":
   Ensures that resource id's passed to APIs are of the right type; for
   example, calling Resources.getColor(R.string.name) is wrong.