AGP 7.3.0 breaks gradle sync for gradle platform projects [247066500]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Sep 16, 2022 11:10AM

as soon as any subproject consumes a gradle platform project android studio gradle sync will fail with

nresolved module dependency (...) Neither the source set nor the artifact property was populated by the Android Gradle plugin.

this is a regression, it worked fine in all versions prior to 7.3.0.

Comments

ma...@gmail.com <ma...@gmail.com> #2Sep 16, 2022 12:14PM

The reason this has not been seen before now is that JDK-8272564 was done for JDK-18 and that it also require min API level 28. The reason the Espresso library expose this is that (most likely) internal Google build tools have JDK-8272564 applied generating invoke-interface on Object methods.

ma...@gmail.com <ma...@gmail.com> #3Sep 16, 2022 03:10PM

Project: r8
Branch: main

commit 6041b16a28b5966e6975340c03261c4fef61b794
Author: Søren Gjesse <sgjesse@google.com>
Date: Thu Mar 02 14:39:27 2023

Also apply the rewriting for JDK-8272564 up to Andorid R

Fixes:

b/271408544

Change-Id: I240de7d301677668b9c13b3b49c7b7951e6434b6

M src/main/java/com/android/tools/r8/utils/InternalOptions.java

https://r8-review.googlesource.com/76861

al...@raiffeisen.ru <al...@raiffeisen.ru> #4Sep 16, 2022 03:34PM

Project: r8
Branch: main

commit 9e5692c8ce91b3ea3f4199740b41d57c097c9947
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:40:44 2023

Fix test after changing API level for rewriting of JDK-8272564

Bug:

b/271408544

Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653

M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java

https://r8-review.googlesource.com/76885

ra...@google.com <ra...@google.com> Sep 16, 2022 10:06PM

Assigned to an...@google.com.

ag...@gmail.com <ag...@gmail.com> #5Sep 19, 2022 02:56AM

Project: r8
Branch: 8.0

commit 875ac43330d4404d3c481d7395368ec19defff9d
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:43:48 2023

Version 8.0.33

Bug:

b/271408544

Change-Id: I675869c3c03cce5a0e7b367981e79e47ad1048ec

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/76888

Message last modified on Sep 19, 2022 03:10AM

je...@google.com <je...@google.com> Sep 19, 2022 03:52PM

Reassigned to so...@google.com.

so...@google.com <so...@google.com> #6Sep 20, 2022 03:35PM

Project: r8
Branch: 8.0

commit 7b9dea5b4c29b5aa9dde2e4a7db4cb28b68c9caf
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:43:32 2023

Fix test after changing API level for rewriting of JDK-8272564

Bug:

b/271408544

Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653

M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java

https://r8-review.googlesource.com/76887

iv...@adevinta.com <iv...@adevinta.com> #7Sep 20, 2022 05:34PM

Project: r8
Branch: 8.0

commit 2a7c539ec35668c77b0eacb27612d7a5d8a2d11a
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:43:21 2023

Also apply the rewriting for JDK-8272564 up to Andorid R

Bug:

b/271408544

Change-Id: I240de7d301677668b9c13b3b49c7b7951e6434b6

M src/main/java/com/android/tools/r8/utils/InternalOptions.java

https://r8-review.googlesource.com/76886

ga...@google.com <ga...@google.com> #8Sep 21, 2022 10:05AM

Reassigned to ga...@google.com.

Project: r8
Branch: 4.0

commit a53fc28f4b588c1e7c0df8c36faf9559292b1d0f
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:44:54 2023

Version 4.0.55

Bug:

b/271408544

Change-Id: I9dceedf684646380d8cff6f7af2eb3bcbd610a72

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/76891

Message last modified on Sep 21, 2022 10:08AM

ga...@google.com <ga...@google.com> #9Sep 21, 2022 03:55PM

Project: r8
Branch: 4.0

commit ce3a4742ffec584560975df35ddae726ebdad65e
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:44:41 2023

Fix test after changing API level for rewriting of JDK-8272564

Bug:

b/271408544

Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653

M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java

https://r8-review.googlesource.com/76890

Message last modified on Sep 21, 2022 04:13PM

ga...@google.com <ga...@google.com> #10Sep 21, 2022 06:20PM

Marked as fixed.

Project: r8
Branch: 4.0

commit 608e9673999593f6c107570c7cd1df6d55e20c3a
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:44:31 2023

Also apply the rewriting for JDK-8272564 up to Andorid R

Bug:

b/271408544

Change-Id: I240de7d301677668b9c13b3b49c7b7951e6434b6

M src/main/java/com/android/tools/r8/utils/InternalOptions.java

https://r8-review.googlesource.com/76889

[Deleted User] <[Deleted User]> #11Oct 4, 2022 07:06PM

Project: r8
Branch: 3.3

commit eac71359fb9cb7aff95a249d63470f266063733b
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:47:59 2023

Version 3.3.91

Bug:

b/271408544

Change-Id: Ie3a0ef7343ed24225c2053278399d98646a683bf

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/76894

ga...@google.com <ga...@google.com> #12Oct 4, 2022 10:05PM

Project: r8
Branch: 3.3

commit d4e177e2634ad9732828160d1d9215a6a5507cb9
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:47:48 2023

Fix test after changing API level for rewriting of JDK-8272564

Bug:

b/271408544

Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653

M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java

https://r8-review.googlesource.com/76893

sa...@gmail.com <sa...@gmail.com> #13Dec 22, 2022 02:13AM

Project: r8
Branch: 3.3

commit 57a11e5142249bde710d4a92c87d0b7612d0328a
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:47:37 2023

Also apply the rewriting for JDK-8272564 up to Andorid R

Bug:

b/271408544

Change-Id: I240de7d301677668b9c13b3b49c7b7951e6434b6

M src/main/java/com/android/tools/r8/utils/InternalOptions.java

https://r8-review.googlesource.com/76892

va...@gmail.com <va...@gmail.com> #14Dec 27, 2022 05:36AM

b/271408544

Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653

M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java

https://r8-review.googlesource.com/76887

Issue 247066500

Description

Issue summary

Comments

ma...@gmail.com <ma...@gmail.com> #2Sep 16, 2022 12:14PM

ma...@gmail.com <ma...@gmail.com> #3Sep 16, 2022 03:10PM

al...@raiffeisen.ru <al...@raiffeisen.ru> #4Sep 16, 2022 03:34PM

ra...@google.com <ra...@google.com> Sep 16, 2022 10:06PM

ag...@gmail.com <ag...@gmail.com> #5Sep 19, 2022 02:56AM

je...@google.com <je...@google.com> Sep 19, 2022 03:52PM

so...@google.com <so...@google.com> #6Sep 20, 2022 03:35PM

iv...@adevinta.com <iv...@adevinta.com> #7Sep 20, 2022 05:34PM

ga...@google.com <ga...@google.com> #8Sep 21, 2022 10:05AM

ga...@google.com <ga...@google.com> #9Sep 21, 2022 03:55PM

ga...@google.com <ga...@google.com> #10Sep 21, 2022 06:20PM

[Deleted User] <[Deleted User]> #11Oct 4, 2022 07:06PM

ga...@google.com <ga...@google.com> #12Oct 4, 2022 10:05PM

sa...@gmail.com <sa...@gmail.com> #13Dec 22, 2022 02:13AM

va...@gmail.com <va...@gmail.com> #14Dec 27, 2022 05:36AM

Add comment

Issue metadata