AGP 7.3.0 breaks gradle sync for gradle platform projects [247066500]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Sep 16, 2022 11:10AM

as soon as any subproject consumes a gradle platform project android studio gradle sync will fail with

nresolved module dependency (...) Neither the source set nor the artifact property was populated by the Android Gradle plugin.

this is a regression, it worked fine in all versions prior to 7.3.0.

Comments

ma...@gmail.com <ma...@gmail.com> #2Sep 16, 2022 12:14PM

Thank you for the report and the supplied dump with the reproduction. I can confirm that the NPE is also present on HEAD, and I will look into it.

Quite a few of the class files in the dump has malformed inner-class attribute, where R8 reports e.g.:

Info in /tmp/tmpo67ucguh/program.jar:ofifmwrrhhmodsc/ψξψξψξξ.class:
Malformed inner-class attribute:
	outerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ
	innerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ$ψξξψξξξ
	innerName: ψξψξψξξ$ψξξψξξξ

These are ignored, so they should not be the reason for the NPE, but something to also look into.

ma...@gmail.com <ma...@gmail.com> #3Sep 16, 2022 03:10PM

Project: r8
Branch: main

commit e59500ca4445f5fb5d2ccc1114acbf66df11d196
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:55 2023

Insert patched frame instructions in the right place

Fixes:

b/274337639

Change-Id: Iae204ed529f9af5bf5fa3eaacba45128dfa6fd9e

M src/main/java/com/android/tools/r8/graph/LazyCfCode.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77390

al...@raiffeisen.ru <al...@raiffeisen.ru> #4Sep 16, 2022 03:34PM

Project: r8
Branch: main

commit 780c2e83c8c033e7594d61894fa1b3dbcad6630b
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:13 2023

Add reproduction of

b/274337639

Bug:

b/274337639

Change-Id: I7573883d6a649eed47b10d7bf0cdea2e11710268

M build.gradle
M src/main/java/com/android/tools/r8/cf/code/frame/UninitializedNew.java
A src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77389

ra...@google.com <ra...@google.com> Sep 16, 2022 10:06PM

Assigned to an...@google.com.

ag...@gmail.com <ag...@gmail.com> #5Sep 19, 2022 02:56AM

I will backport this to the 8.0 and 4.0 branches.

Message last modified on Sep 19, 2022 03:10AM

je...@google.com <je...@google.com> Sep 19, 2022 03:52PM

Reassigned to so...@google.com.

so...@google.com <so...@google.com> #6Sep 20, 2022 03:35PM

Thank you very much for taking a look at this!

Is this fix related to the nullpointer or the malformed inner-class attributes ?

Do you have a separated ticket for it? Could you share it?

iv...@adevinta.com <iv...@adevinta.com> #7Sep 20, 2022 05:34PM

Project: r8
Branch: 4.0

commit 6edb00fb23e41b28d4794cfa69d706d5c5aa3fba
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:55:01 2023

Version 4.0.56

Bug:

b/274337639

Change-Id: I88a20fc922ce892d38fa3a34f9a3f1f4714354ae

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77447

ga...@google.com <ga...@google.com> #8Sep 21, 2022 10:05AM

Reassigned to ga...@google.com.

Project: r8
Branch: 4.0

commit d9215af3b02f64d1207b9ebd63a6925229307b9d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:50 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77446

Message last modified on Sep 21, 2022 10:08AM

ga...@google.com <ga...@google.com> #9Sep 21, 2022 03:55PM

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77445

Message last modified on Sep 21, 2022 04:13PM

ga...@google.com <ga...@google.com> #10Sep 21, 2022 06:20PM

Marked as fixed.

Project: r8
Branch: 8.0

commit 6686e7dffea83ea894438b496c065d0a18cda206
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:53:01 2023

Version 8.0.37

Bug:

b/274337639

Change-Id: I43a723a94638088d921cd3fb6e22ef6e41f07d5f

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77444

[Deleted User] <[Deleted User]> #11Oct 4, 2022 07:06PM

Project: r8
Branch: 8.0

commit 57f55fb70aa678a61f9c7ff1826fbc695faeac7d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:52:27 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77443

ga...@google.com <ga...@google.com> #12Oct 4, 2022 10:05PM

Project: r8
Branch: 8.0

commit cd00c053222b06bb27fdd90bbed56af9c9ef0744
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:51:57 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77442

sa...@gmail.com <sa...@gmail.com> #13Dec 22, 2022 02:13AM

b/274337639

https://r8-review.googlesource.com/77446

va...@gmail.com <va...@gmail.com> #14Dec 27, 2022 05:36AM

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77445

Issue 247066500

Description

Issue summary

Comments

ma...@gmail.com <ma...@gmail.com> #2Sep 16, 2022 12:14PM

ma...@gmail.com <ma...@gmail.com> #3Sep 16, 2022 03:10PM

al...@raiffeisen.ru <al...@raiffeisen.ru> #4Sep 16, 2022 03:34PM

ra...@google.com <ra...@google.com> Sep 16, 2022 10:06PM

ag...@gmail.com <ag...@gmail.com> #5Sep 19, 2022 02:56AM

je...@google.com <je...@google.com> Sep 19, 2022 03:52PM

so...@google.com <so...@google.com> #6Sep 20, 2022 03:35PM

iv...@adevinta.com <iv...@adevinta.com> #7Sep 20, 2022 05:34PM

ga...@google.com <ga...@google.com> #8Sep 21, 2022 10:05AM

ga...@google.com <ga...@google.com> #9Sep 21, 2022 03:55PM

ga...@google.com <ga...@google.com> #10Sep 21, 2022 06:20PM

[Deleted User] <[Deleted User]> #11Oct 4, 2022 07:06PM

ga...@google.com <ga...@google.com> #12Oct 4, 2022 10:05PM

sa...@gmail.com <sa...@gmail.com> #13Dec 22, 2022 02:13AM

va...@gmail.com <va...@gmail.com> #14Dec 27, 2022 05:36AM

Add comment

Issue metadata