AGP tries to add kotlinOptions.freeCompilerArgs on task execution phase [247544167]

Fixed

Bug

Status Update

No update yet.

Description

eg...@gmail.com

created issue #1

Sep 19, 2022 04:03PM

Kotlin Gradle plugin 1.8.0 was migrated to expose compiler options with Gradle properties API. This API prohibits inputs modification on Gradle execution phase.

kgpUtils.kt#addComposeArgsToKotlinCompile method adds additional arguments to kotlinOptions.freeCompilerArgs in task doFirst action.

With KGP 1.8.0 this will produce warning message in build log and in next major versions it fill fail the build.

Comments

ri...@google.com <ri...@google.com> Sep 20, 2022 10:30AM

Assigned to an...@google.com.

ga...@google.com <ga...@google.com> #2Sep 20, 2022 04:19PM

Reassigned to hu...@google.com.

Some things to work out before making the annotations type-use:

Determine guidelines for type nullability in public API
Determine rules for when type nullability can change in public API
Confirm that intellij nullability lint works as expected for type-use nullability annotations
Test what the impact would be on existing arrays (due to ambiguities of type-use annotations on arrays)
Confirm usage of type-use androidx.annotation.NonNull/Nullable in metalava won't break anything for platform

hu...@google.com <hu...@google.com> #3Sep 23, 2022 01:54PM

Marked as fixed.

Plan for making the annotations type-use: https://docs.google.com/document/d/1tNqV9Dgtii6wvulm8emjs0bwgSL3Fwf3F4LFXfVeyTU/edit

Issue 247544167

Description

Issue summary

Comments

ri...@google.com <ri...@google.com> Sep 20, 2022 10:30AM

ga...@google.com <ga...@google.com> #2Sep 20, 2022 04:19PM

hu...@google.com <hu...@google.com> #3Sep 23, 2022 01:54PM

Add comment

Issue metadata