IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit 6a0521fe7d56c07bcb9010cf8d15ed14fe73fd74
Author: Ralston Da Silva <ralu@google.com>
Date:   Mon Nov 28 15:36:51 2022

    Remember FocusRequester used by CoreTextField
   
    While writing tests as part of aosp/2286277 I noticed some
    intermittent crashes in CoreTextField. I tracked this to a
    focus requester that was not remembered.
   
    Bug: 247708726
    Test: ./gradlew compose:f:f:cC -P android.testInstrumentationRunnerArguments.package=androidx.compose.foundation.foundation.CoreTextFieldFocusTest
    Change-Id: Ic26f9abcb978c68ca2dc58fe1cc3c9999f520e0d

A       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldFocusTest.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt

https://android-review.googlesource.com/2320970

Project: platform/frameworks/support
Branch: androidx-main

commit 92d3c662f9b1f404c980a06c5e59fa000d5ad237
Author: Ralston Da Silva <ralu@google.com>
Date:   Tue Sep 27 02:04:29 2022

    Migrate focus modifiers to Modifier.Node
   
    This CL is a result of squashing all the commits
    from the topic:
    https://android-review.googlesource.com/q/topic:%22Migrate+focus+to+Modifer.Node%22
   
    Here are some highlights of this CL
    - FocusModifier is replaced by FocusTargetNode
    - FocusProperties are implemented using Modifier.Node
    - FocusEvents are powered by a backing FocusEventNode
    - FocusRequesters find the focusTarget using the new
      Modifier.Node APIs
    - KeyInputEvents and RotaryScrollEvents are routed using
      a common FocusAwareInputNode
    - We use the Modifier.Node APIs to find the current value of
      The BeyondBoundsLayout modifier local that is needed when
      focus search is traversing through lazy lists.
   
    Bug: 247708726
    Bug: 255352203
    Bug: 253043481
    Bug: 247716483
    Bug: 247708726
    Bug: 254529934
    Bug: 251840112
    Bug: 251859987
    Bug: 257141589
    Test: ./gradlew compose:ui:ui:cC -P android.testInstrumentationRunnerArguments.package=androidx.compose.ui.focus
    Relnote: FocusRequesterModifier is deprecated in favor of FocusRequesterNode
    Change-Id: I7f4d7a99aa42f7f3e4f49d034f8358a41ed42d0f

M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/FocusableTest.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
M       compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/FloatingActionButtonScreenshotTest.kt
M       compose/ui/ui-util/api/current.txt
M       compose/ui/ui-util/api/public_plus_experimental_current.txt
M       compose/ui/ui-util/api/restricted_current.txt
M       compose/ui/ui-util/src/commonMain/kotlin/androidx/compose/ui/util/ListUtils.kt
M       compose/ui/ui/api/current.ignore
M       compose/ui/ui/api/current.txt
M       compose/ui/ui/api/public_plus_experimental_current.txt
M       compose/ui/ui/api/restricted_current.ignore
M       compose/ui/ui/api/restricted_current.txt
M       compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/ConditionalFocusabilityDemo.kt
M       compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/LazyListChildFocusDemos.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/CaptureFocusTest.kt
D       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/ClearFocusTest.kt
A       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/CombinedFocusModifierNodeTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/CustomFocusTraversalTest.kt
D       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/DeactivatedFocusPropertiesTest.kt
D       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FindFocusableChildrenTest.kt
D       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FindParentFocusNodeTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusAggregationTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusChangedTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusEventCountTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusManagerCompositionLocalTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusRequesterTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusTargetAttachDetachTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusTestUtils.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FreeFocusTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/OneDimensionalFocusSearchNextTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/OneDimensionalFocusSearchPreviousTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/RequestFocusTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/ReusedFocusRequesterCaptureFocusTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/ReusedFocusRequesterFreeFocusTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/focus/FocusAwareEventPropagationTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/key/ProcessKeyInputTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/HitPathTrackerTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/rotary/RotaryScrollEventTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/Helpers.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/node/DelegatableNodeTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/node/InvalidateSubtreeTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/node/NodeCoordinatorInitializationTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/node/ObserverNodeTest.kt
M       compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
M       compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/ComposedModifier.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/BeyondBoundsLayout.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusChangedModifier.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusEventModifier.kt
A       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusInvalidationManager.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusManager.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusModifier.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusOrderModifier.kt
A       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusOwner.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusProperties.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusRequester.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusRequesterModifier.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusState.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTransactions.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTraversal.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/OneDimensionalFocusSearch.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusSearch.kt
D       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/focus/FocusAwareInputModifier.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/key/KeyInputModifier.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/rotary/RotaryInputModifier.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/rotary/RotaryScrollEvent.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/BackwardsCompatNode.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/DelegatableNode.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/NodeChain.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/NodeKind.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/CompositionLocals.kt
M       compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.desktop.kt
M       compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/SkiaBasedOwner.skiko.kt
D       compose/ui/ui/src/test/kotlin/androidx/compose/ui/focus/FocusManagerTest.kt
M       compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
M       compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/ModifierLocalConsumerEntityTest.kt

https://android-review.googlesource.com/2286277

Project: platform/frameworks/support
Branch: androidx-main

commit 5dcede6849274f2098211982e7a99e313b3c240f
Author: Ralston Da Silva <ralu@google.com>
Date:   Thu Jan 05 12:16:16 2023

    Focus Modifier.Node cleanup
   
    During aosp/2286277 we didn't rename any files so that
    we could have a good diff for code review. This CL is
    a refactor with some file name changes. It doesn't
    change any of the existing logic.
   
    Bug: 247708726
    Test: ./gradlew compose:ui:ui:cC -P android.testInstrumentationRunnerArguments.package=androidx.compose.ui.focus
    Relnote: N/A
    Change-Id: Idcc21eeb99e1423dcc85bb97d7948cbf47ee705e

M       compose/ui/ui/api/current.txt
M       compose/ui/ui/api/public_plus_experimental_current.txt
M       compose/ui/ui/api/restricted_current.txt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusChangedModifier.kt
A       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusDirection.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusEventModifier.kt
A       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusEventModifierNode.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusManager.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusModifier.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusOrderModifier.kt
A       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusOwnerImpl.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusProperties.kt
A       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusPropertiesModifierNode.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusRequesterModifier.kt
A       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusRequesterModifierNode.kt
A       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTargetModifierNode.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTraversal.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusSearch.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/key/KeyInputModifier.kt
A       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/key/KeyInputModifierNode.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/rotary/RotaryInputModifier.kt
A       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/rotary/RotaryInputModifierNode.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/BackwardsCompatNode.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/NodeKind.kt

https://android-review.googlesource.com/2376860