NavigationUI's onNavDestinationSelected() should log when it doesn't handle a MenuItem [247730357]

Fixed

Bug

Status Update

No update yet.

Description

sh...@gmail.com

created issue #1

Sep 20, 2022 09:55AM

Steps to reproduce the problem (including sample code if appropriate).
- Import enclosed TestBottomNav.zip to Android Studio and run
- Click Dashboard or Notification item on BottomNavigationView.
What happened.

There is no response after clicking tab item, meanwhile there is no related exception messages printed in Logcat.

This abnormal behaviour was intentional made on my part, just to amplify the problem. To fix it, go to app/src/main/res/menu/bottom_nav_menu.xml, change every android:id starts with Navigation to navigation will be fine.

What you think the correct behavior should be.

NavigationUI should not ate the exception message with a simple false return. This will drive novice developers crazy to find out the problem. See here and here. We should not design API from the perspective of "everyone knows why", and it is also inconsistent with Google's strong advocacy of Jetpack for novice developers over these years.

Is this a security related issue? Yes/No

No.

TestBottomNav.zip

346 KB

Download

Comments

sh...@gmail.com <sh...@gmail.com> #2Sep 20, 2022 10:49AM

since these are in public API (:/) we need to do this in 1.2

il...@google.com <il...@google.com> Oct 18, 2022 08:41PM

Assigned to jb...@google.com.

jb...@google.com <jb...@google.com> #3Oct 20, 2022 10:59PM

Reassigned to cl...@google.com.

since it is already marked as deprecated, we can probably do it by now.

ap...@google.com <ap...@google.com> #4Nov 1, 2022 07:16PM

Opening diff shortly

il...@google.com <il...@google.com> #5Nov 1, 2022 07:21PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

na...@google.com <na...@google.com> #6Nov 9, 2022 06:28PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-ui:2.6.0-alpha04

Issue 247730357