NavigationUI's onNavDestinationSelected() should log when it doesn't handle a MenuItem [247730357]

Fixed

Bug

Status Update

No update yet.

Description

sh...@gmail.com

created issue #1

Sep 20, 2022 09:55AM

Steps to reproduce the problem (including sample code if appropriate).
- Import enclosed TestBottomNav.zip to Android Studio and run
- Click Dashboard or Notification item on BottomNavigationView.
What happened.

There is no response after clicking tab item, meanwhile there is no related exception messages printed in Logcat.

This abnormal behaviour was intentional made on my part, just to amplify the problem. To fix it, go to app/src/main/res/menu/bottom_nav_menu.xml, change every android:id starts with Navigation to navigation will be fine.

What you think the correct behavior should be.

NavigationUI should not ate the exception message with a simple false return. This will drive novice developers crazy to find out the problem. See here and here. We should not design API from the perspective of "everyone knows why", and it is also inconsistent with Google's strong advocacy of Jetpack for novice developers over these years.

Is this a security related issue? Yes/No

No.

TestBottomNav.zip

346 KB

Download

Comments

sh...@gmail.com <sh...@gmail.com> #2Sep 20, 2022 10:49AM

Nested scrolling works partially (as per

http://b/122818889). Let's discuss if we need full support and if so make sure it works.

il...@google.com <il...@google.com> Oct 18, 2022 08:41PM

Assigned to jb...@google.com.

jb...@google.com <jb...@google.com> #3Oct 20, 2022 10:59PM

Reassigned to cl...@google.com.

Hi!

What is 'partially' exactly?
How do I see it?
Thanks!

ap...@google.com <ap...@google.com> #4Nov 1, 2022 07:16PM

As of now:
- Nesting scroll views with a scroll direction perpendicular to the ViewPager2's orientation inside ViewPager2 works
- Nesting scroll views with a scroll direction parallel to the ViewPager2's orientation inside ViewPager2 does not work

il...@google.com <il...@google.com> #5Nov 1, 2022 07:21PM

Marked as fixed.

Horizontal ViewPager2 not correctly working into a vertical RecyclerView
Set a setNestedScrollingEnabled to the RecyclerView into the ViewPager2 (across reflection) resolves the problem

na...@google.com <na...@google.com> #6Nov 9, 2022 06:28PM

ageevvalentin@gmail.com, could you provide a sample app? I'd like to learn more about the circumstances that cause the problem; putting a clean ViewPager2 inside a clean RecyclerView seems to work fine, so there must be other factors involved.

Issue 247730357