IssueTracker

Hi Doudera,

Thank you for reporting this issue. It is working as intended. This is because the state of CameraControl follows Camera. Once the Camera is closed, all settings will be restored, just like the settings of the focus area and zoom level. The app can restore the torch state by resetting torch at the time of activity onResume.

Hi Doudera, Thank you for the detail description. It sounds like some problem in the code. I will investigate it more.

From the log, it shows the camera state

-> open -> enable torch -> close -> open

The torch was gone because it restarted the camera.

It needs to investigate more about why it open/close so frequently.

In CameraXBasic, it looks like the "cameraProvider.unbindAll()" call in CameraFragment.bindCameraUseCases() method will cause the camera close.

Since camera operation is in another thread, a timing causes the enableTorch() failed because the camera is in closed state at that moment.

It can be detected by checking the returned ListenableFuture result from cameraControl.enableTorch()

020-03-29 12:34:56.139 4946-4946/com.android.example.cameraxbasic E/CameraXBasic: enableTorch
2020-03-29 12:34:56.225 4946-5035/com.android.example.cameraxbasic D/Camera: Transitioning camera internal state: OPENED --> CLOSING
2020-03-29 12:34:56.226 4946-4946/com.android.example.cameraxbasic E/CameraXBasic: enableTorch fail by java.util.concurrent.ExecutionException: androidx.camera.core.CameraControl$OperationCanceledException: Camera is not active.
    java.util.concurrent.ExecutionException: androidx.camera.core.CameraControl$OperationCanceledException: Camera is not active.
        at androidx.concurrent.futures.AbstractResolvableFuture.getDoneValue(AbstractResolvableFuture.java:518)
        at androidx.concurrent.futures.AbstractResolvableFuture.get(AbstractResolvableFuture.java:475)
        at androidx.concurrent.futures.CallbackToFutureAdapter$SafeFuture.get(CallbackToFutureAdapter.java:199)
        at com.android.example.cameraxbasic.fragments.CameraFragment$bindCameraUseCases$1$2$1.run(CameraFragment.kt:310)
        at android.os.Handler.handleCallback(Handler.java:907)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:216)
        at android.app.ActivityThread.main(ActivityThread.java:7476)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:549)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:968)
     Caused by: androidx.camera.core.CameraControl$OperationCanceledException: Camera is not active.
        at androidx.camera.camera2.internal.TorchControl.setActive(TorchControl.java:112)
        at androidx.camera.camera2.internal.Camera2CameraControl.setActive(Camera2CameraControl.java:135)
        at androidx.camera.camera2.internal.Camera2CameraImpl.tryRemoveOnlineUseCases(Camera2CameraImpl.java:727)
        at androidx.camera.camera2.internal.Camera2CameraImpl.lambda$removeOnlineUseCase$13$Camera2CameraImpl(Camera2CameraImpl.java:699)
        at androidx.camera.camera2.internal.-$$Lambda$Camera2CameraImpl$5wc8VkOCNW87m5eLEZfzgWUl-nY.run(Unknown Source:4)
        at android.os.Handler.handleCallback(Handler.java:907)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:216)
        at android.os.HandlerThread.run(HandlerThread.java:67)

It is a defect that CameraX should guarantee the order of the camera request.

Another topic is that why camera will be closed when resuming the CameraFragment.

CameraX is lifecycle aware, if UseCases is bound and pause/resume the page, CameraX will restart those UseCases automatically. So actually it doesn't have to unbind and rebind those UseCases. Unbind and rebind UseCases causes it open camera twice and meet this timing issue. In CameraXBasic, it will unbind and rebind UseCases in onViewCreated().

It is easier to be done in an Activity, just put the bindToLifecycle(...) code in the Activity.onCreate(). For Fragment, maybe Fragment.onAttach() is something like Activity.onCreate, but not pretty sure if it is practical. Or alternatively, it has to unbind all use case in a paired callback such like Fragment.onDestroyView() to prevent Camera from being automatically opened when resuming.

I understand.

Is there a way to tell if the snapshot includes the changes from aosp/2227317 in https://androidx.dev/snapshots/builds?

mmm, yeah, seems like there is no information about it there. I'll let you know which build includes it.

Thank you for all the help.

I'll test it out as soon at it's available and update here.

Build 9098985 and newer has the change.

I've verified the changes in I9686ba0810e4444b41ae7d638a6b8db3943da8cb improved the performance of the workers being executed. I tested using the sample project and our app to confirm.

I updated the sample project to show how to pull from the snapshot repository.

Will the changes in I9686ba0810e4444b41ae7d638a6b8db3943da8cb be included in the next alpha build? I was hoping to update the WorkManager since it's required for compatibility with targeting Android SDK 31.

Thank you for the support.

Yeah, it will be included in the next release, which is 2.8.0-beta01.

This bug was linked in a change in the following release(s):

• androidx.work:work-runtime:2.8.0-beta01

Thank you!

FYI, I get an error in Room DB with this version: androidx.work:work-runtime:2.8.0-beta01

See error below

# code block
[ERROR] [system.err] /home/eoinzy/workspace/android/myapp/data/build/generated/source/kapt/debug/com/myapp/data/MyAppDatabase_Impl.java:188: error: onCreate(SupportSQLiteDatabase) in <anonymous com.myapp.data.MyAppDatabase_Impl$1> cannot override onCreate(SupportSQLiteDatabase) in Delegate
[ERROR] [system.err]       protected void onCreate(SupportSQLiteDatabase _db) {
[ERROR] [system.err]                      ^
[ERROR] [system.err]   attempting to assign weaker access privileges; was public
[ERROR] [system.err] /home/eoinzy/workspace/android/myapp/data/build/generated/source/kapt/debug/com/myapp/data/MyAppDatabase_Impl.java:218: error: onValidateSchema(SupportSQLiteDatabase) in <anonymous com.myapp.data.MyAppDatabase_Impl$1> cannot override onValidateSchema(SupportSQLiteDatabase) in Delegate
[ERROR] [system.err]       protected RoomOpenHelper.ValidationResult onValidateSchema(SupportSQLiteDatabase _db) {
[ERROR] [system.err]                                                 ^
[ERROR] [system.err]   attempting to assign weaker access privileges; was public
[ERROR] [system.err] 2 errors

The issue isn't present in androidx.work:work-runtime:2.8.0-alpha04

Re comment#17: it looks like you have a version skew issue, what version of room-compiler and room-runtime do you have declared in your project? Can you try using the latest 2.5.0-beta01? I think what is happening is that work-runtime is using a newer version of room-runtime than the one declared in your project but room-compiler is not being updated to match that version as it should be.

Yes, that's exactly the issue. Using 2.5.0-beta01 seems to fix it. Apologies for the false alarm.