Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 1b1aff5c19b657883eb1d657767284a733542c8d
Author: Chris Craik <ccraik@google.com>
Date: Tue Dec 08 17:14:43 2020
Add trace() and traceAsync() lazy string variants, and fix try usage
Test: TraceTestKt
Fixes: 175233952
Fixes: 247066503
Relnote: "Add trace() and traceAsync() variants with lazy string
and cookie computation. Also now correctly skips Trace.end if
Trace.begin throws."
Unable to easily test the try/finally fix, as the incorrect extra end
event only occurs for synchronous events (Trace.endSection), which
doesn't have a unique label or cookie param to validate.
Change-Id: I314210e79d91f7e71140208c61c8672591aef88b
M tracing/tracing-ktx/api/current.txt
M tracing/tracing-ktx/src/androidTest/java/androidx/tracing/TraceTestKt.kt
M tracing/tracing-ktx/api/restricted_current.txt
M tracing/tracing-ktx/api/public_plus_experimental_current.txt
M tracing/tracing-ktx/src/main/java/androidx/tracing/Trace.kt
https://android-review.googlesource.com/2227300
Branch: androidx-main
commit 1b1aff5c19b657883eb1d657767284a733542c8d
Author: Chris Craik <ccraik@google.com>
Date: Tue Dec 08 17:14:43 2020
Add trace() and traceAsync() lazy string variants, and fix try usage
Test: TraceTestKt
Fixes: 175233952
Fixes: 247066503
Relnote: "Add trace() and traceAsync() variants with lazy string
and cookie computation. Also now correctly skips Trace.end if
Trace.begin throws."
Unable to easily test the try/finally fix, as the incorrect extra end
event only occurs for synchronous events (Trace.endSection), which
doesn't have a unique label or cookie param to validate.
Change-Id: I314210e79d91f7e71140208c61c8672591aef88b
M tracing/tracing-ktx/api/current.txt
M tracing/tracing-ktx/src/androidTest/java/androidx/tracing/TraceTestKt.kt
M tracing/tracing-ktx/api/restricted_current.txt
M tracing/tracing-ktx/api/public_plus_experimental_current.txt
M tracing/tracing-ktx/src/main/java/androidx/tracing/Trace.kt
pr...@google.com <pr...@google.com> #3
This bug was linked in a change in the following release(s):
androidx.tracing:tracing-ktx:1.2.0-alpha01
Description
It's unnecessary, as we never intend pass the blocks down into other functions, and non-local returns may be helpful.