Verified
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Fixed in r1313.
ap...@google.com <ap...@google.com> #3
[Empty comment from Monorail migration]
ap...@google.com <ap...@google.com> #4
[Empty comment from Monorail migration]
ap...@google.com <ap...@google.com> #5
ap...@google.com <ap...@google.com> #6
Project: r8
Branch: 4.0
commit 8667680870d12d832ffc08aebddd8be520b35b74
Author: Ian Zerny <zerny@google.com>
Date: Mon Sep 26 11:38:58 2022
Regression test for removing default constructor.
Bug: b/248473941
Bug: b/247054688
Change-Id: Ia179d79e0d1261c82e7121aaa4086a13824b23e2
A src/test/java/com/android/tools/r8/shaking/forceproguardcompatibility/defaultctor/KeepClassMembersDefaultCtorTest.java
https://r8-review.googlesource.com/71724
Branch: 4.0
commit 8667680870d12d832ffc08aebddd8be520b35b74
Author: Ian Zerny <zerny@google.com>
Date: Mon Sep 26 11:38:58 2022
Regression test for removing default constructor.
Bug:
Bug:
Change-Id: Ia179d79e0d1261c82e7121aaa4086a13824b23e2
A src/test/java/com/android/tools/r8/shaking/forceproguardcompatibility/defaultctor/KeepClassMembersDefaultCtorTest.java
ap...@google.com <ap...@google.com> #7
Project: r8
Branch: 3.3
commit 007b645a73a89e0285924facc8c4c511efdc585b
Author: Ian Zerny <zerny@google.com>
Date: Mon Sep 26 11:35:06 2022
Version 3.3.81
Bug: b/247054688
Bug: b/248473941
Change-Id: I1710f7a4d22e66f9282fb8d5a20ac9bc8d5644ea
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/71723
Branch: 3.3
commit 007b645a73a89e0285924facc8c4c511efdc585b
Author: Ian Zerny <zerny@google.com>
Date: Mon Sep 26 11:35:06 2022
Version 3.3.81
Bug:
Bug:
Change-Id: I1710f7a4d22e66f9282fb8d5a20ac9bc8d5644ea
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #8
Project: r8
Branch: 3.3
commit c6bd011d91d6230f30e8fe925afdc8880a0a584e
Author: Ian Zerny <zerny@google.com>
Date: Mon Sep 26 11:34:47 2022
Don't implicitly keep default constructors for keepclassmembers.
This change also disallows optimizing implicitly kept initializers
which was also an oversight as the callsite info for them is
incomplete.
Bug: b/248473941
Bug: b/247054688
Change-Id: I80d5afde0642d7061684551b30a295b0b5fcde93
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/test/java/com/android/tools/r8/shaking/forceproguardcompatibility/defaultctor/KeepClassMembersDefaultCtorTest.java
A src/test/java/com/android/tools/r8/shaking/forceproguardcompatibility/defaultctor/KeepClassesWithMembersDefaultCtorTest.java
https://r8-review.googlesource.com/71722
Branch: 3.3
commit c6bd011d91d6230f30e8fe925afdc8880a0a584e
Author: Ian Zerny <zerny@google.com>
Date: Mon Sep 26 11:34:47 2022
Don't implicitly keep default constructors for keepclassmembers.
This change also disallows optimizing implicitly kept initializers
which was also an oversight as the callsite info for them is
incomplete.
Bug:
Bug:
Change-Id: I80d5afde0642d7061684551b30a295b0b5fcde93
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/test/java/com/android/tools/r8/shaking/forceproguardcompatibility/defaultctor/KeepClassMembersDefaultCtorTest.java
A src/test/java/com/android/tools/r8/shaking/forceproguardcompatibility/defaultctor/KeepClassesWithMembersDefaultCtorTest.java
ap...@google.com <ap...@google.com> #9
Project: r8
Branch: 3.3
commit e321b451f76ae1b2f9a7694ec512b95c4788d0bb
Author: Ian Zerny <zerny@google.com>
Date: Mon Sep 26 11:32:02 2022
Regression test for removing default constructor.
Bug: b/248473941
Bug: b/247054688
Change-Id: Ia179d79e0d1261c82e7121aaa4086a13824b23e2
A src/test/java/com/android/tools/r8/shaking/forceproguardcompatibility/defaultctor/KeepClassMembersDefaultCtorTest.java
https://r8-review.googlesource.com/71721
Branch: 3.3
commit e321b451f76ae1b2f9a7694ec512b95c4788d0bb
Author: Ian Zerny <zerny@google.com>
Date: Mon Sep 26 11:32:02 2022
Regression test for removing default constructor.
Bug:
Bug:
Change-Id: Ia179d79e0d1261c82e7121aaa4086a13824b23e2
A src/test/java/com/android/tools/r8/shaking/forceproguardcompatibility/defaultctor/KeepClassMembersDefaultCtorTest.java
ap...@google.com <ap...@google.com> #10
Project: r8
Branch: 4.0
commit 0cd1cf28ffb9bb1739b6c90ad6868da18eb82d23
Author: Ian Zerny <zerny@google.com>
Date: Mon Sep 26 11:39:06 2022
Don't implicitly keep default constructors for keepclassmembers.
This change also disallows optimizing implicitly kept initializers
which was also an oversight as the callsite info for them is
incomplete.
Bug: b/248473941
Bug: b/247054688
Change-Id: I80d5afde0642d7061684551b30a295b0b5fcde93
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/test/java/com/android/tools/r8/shaking/forceproguardcompatibility/defaultctor/KeepClassMembersDefaultCtorTest.java
A src/test/java/com/android/tools/r8/shaking/forceproguardcompatibility/defaultctor/KeepClassesWithMembersDefaultCtorTest.java
https://r8-review.googlesource.com/71725
Branch: 4.0
commit 0cd1cf28ffb9bb1739b6c90ad6868da18eb82d23
Author: Ian Zerny <zerny@google.com>
Date: Mon Sep 26 11:39:06 2022
Don't implicitly keep default constructors for keepclassmembers.
This change also disallows optimizing implicitly kept initializers
which was also an oversight as the callsite info for them is
incomplete.
Bug:
Bug:
Change-Id: I80d5afde0642d7061684551b30a295b0b5fcde93
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/test/java/com/android/tools/r8/shaking/forceproguardcompatibility/defaultctor/KeepClassMembersDefaultCtorTest.java
A src/test/java/com/android/tools/r8/shaking/forceproguardcompatibility/defaultctor/KeepClassesWithMembersDefaultCtorTest.java
ap...@google.com <ap...@google.com> #11
Project: r8
Branch: 4.0
commit 8667680870d12d832ffc08aebddd8be520b35b74
Author: Ian Zerny <zerny@google.com>
Date: Mon Sep 26 11:38:58 2022
Regression test for removing default constructor.
Bug: b/248473941
Bug: b/247054688
Change-Id: Ia179d79e0d1261c82e7121aaa4086a13824b23e2
A src/test/java/com/android/tools/r8/shaking/forceproguardcompatibility/defaultctor/KeepClassMembersDefaultCtorTest.java
https://r8-review.googlesource.com/71724
Branch: 4.0
commit 8667680870d12d832ffc08aebddd8be520b35b74
Author: Ian Zerny <zerny@google.com>
Date: Mon Sep 26 11:38:58 2022
Regression test for removing default constructor.
Bug:
Bug:
Change-Id: Ia179d79e0d1261c82e7121aaa4086a13824b23e2
A src/test/java/com/android/tools/r8/shaking/forceproguardcompatibility/defaultctor/KeepClassMembersDefaultCtorTest.java
Description
In some cases PG does remove default constructors, e.g. for uses of
keepclassmembers
. R8 should too.