Fixed
Status Update
Comments
uc...@google.com <uc...@google.com>
tn...@google.com <tn...@google.com>
tn...@google.com <tn...@google.com> #2
As I understand it, we need to migrate namespace definitions both from AndroidManifest.xml
and from implicit definitions from applicationId
/ testApplicationId
? Is that right? So an 8.0 project would have a
namespace <n>
testNamespace <tn>
where <n> is taken from AndroidManifest.xml
package
definitions if present, and applicationId
if not, and <tn>
is testApplicationId
if present and <n>.test
if not?
va...@gmail.com <va...@gmail.com> #3
Sorry for the confusion. AGP would change how it computes the namespace for the androidTest variant. All the Upgrade assistant would need to do is update the source code for the import of the R
class.
Description
The following code:
Gets flagged by lint:
While yes, I do not call
close()
on the returnedInputStream
, I use okio to a buffered source, on which I call Kotlin'suse
which does call close and bubbles up all the way from the buffered source to the initialInputStream
.Would it be possible to detect that the return statement of
inputStream
is chained by something which is then using Kotlin'suse
which does call at the endclose
?