Compose runtime 1.3.0-beta03 throws ArrayIndexOutOfBoundsException [249076084]

Assigned

Bug

Status Update

No update yet.

Description

lo...@gmail.com

created issue #1

Sep 26, 2022 03:54PM

After upgrading to compose 1.3.0-beta03, my app started crashing. After investigating the issue, I was able to reproduce it in a minimal example which you can find here: https://github.com/ln-12/compose-1.3.0-crash-example

For me, it is only happening with the AlertDialog component.

Jetpack Compose version: 1.3.0-beta03
Jetpack Compose component used: runtime
Android Studio Build: Build #AI-213.7172.25.2113.9014738
Kotlin version: 1.7.10

Steps to Reproduce or Code Sample to Reproduce:

Use produceState to create a simple state which changes
Make a dialog which is dependent on that change
The app crashes when the state changes

Stack trace (if applicable):

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.example.compose_130_test, PID: 13079
    java.lang.ArrayIndexOutOfBoundsException: length=0; index=1
        at androidx.compose.runtime.SlotTableKt.containsMark(SlotTable.kt:3181)
        at androidx.compose.runtime.SlotTableKt.access$containsMark(SlotTable.kt:1)
        at androidx.compose.runtime.SlotTable.containsMark(SlotTable.kt:357)
        at androidx.compose.runtime.ComposerImpl.reportAllMovableContent(Composer.kt:3640)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent$reportGroup(Composer.kt:3553)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent$reportGroup(Composer.kt:3579)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent$reportGroup(Composer.kt:3579)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent$reportGroup(Composer.kt:3579)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent$reportGroup(Composer.kt:3579)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent(Composer.kt:3593)
        at androidx.compose.runtime.ComposerImpl.recordDelete(Composer.kt:3482)
        at androidx.compose.runtime.ComposerImpl.end(Composer.kt:2277)
        at androidx.compose.runtime.ComposerImpl.endRestartGroup(Composer.kt:2786)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
        at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:145)
        at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2375)
        at androidx.compose.runtime.ComposerImpl.skipToGroupEnd(Composer.kt:2666)
        at androidx.compose.material.MaterialThemeKt.MaterialTheme(MaterialTheme.kt:85)
        at com.example.compose_130_test.ui.theme.ThemeKt.Compose_130_testTheme(Theme.kt:41)
        at com.example.compose_130_test.ui.theme.ThemeKt$Compose_130_testTheme$1.invoke(Unknown Source:10)
        at com.example.compose_130_test.ui.theme.ThemeKt$Compose_130_testTheme$1.invoke(Unknown Source:10)
        at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:145)
        at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2375)
        at androidx.compose.runtime.ComposerImpl.skipToGroupEnd(Composer.kt:2666)
        at androidx.compose.ui.platform.AbstractComposeView$ensureCompositionCreated$1.invoke(ComposeView.android.kt:250)
        at androidx.compose.ui.platform.AbstractComposeView$ensureCompositionCreated$1.invoke(ComposeView.android.kt:249)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:107)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
        at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:228)
        at androidx.compose.ui.platform.CompositionLocalsKt.ProvideCommonCompositionLocals(CompositionLocals.kt:177)
        at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$3.invoke(AndroidCompositionLocals.android.kt:123)
        at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$3.invoke(AndroidCompositionLocals.android.kt:122)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:107)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
        at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:228)
        at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt.ProvideAndroidCompositionLocals(AndroidCompositionLocals.android.kt:114)
        at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$4.invoke(Unknown Source:8)
        at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$4.invoke(Unknown Source:10)
        at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:145)
E/AndroidRuntime:     at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2375)
        at androidx.compose.runtime.ComposerImpl.skipCurrentGroup(Composer.kt:2643)
        at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:3260)
        at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:3238)
        at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
        at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
        at androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3238)
        at androidx.compose.runtime.ComposerImpl.recompose$runtime_release(Composer.kt:3203)
        at androidx.compose.runtime.CompositionImpl.recompose(Composition.kt:771)
        at androidx.compose.runtime.Recomposer.performRecompose(Recomposer.kt:1031)
        at androidx.compose.runtime.Recomposer.access$performRecompose(Recomposer.kt:125)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:534)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:503)
        at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:34)
        at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
        at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1229)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1239)
        at android.view.Choreographer.doCallbacks(Choreographer.java:899)
        at android.view.Choreographer.doFrame(Choreographer.java:827)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1214)
        at android.os.Handler.handleCallback(Handler.java:942)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7898)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
    	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.runtime.PausableMonotonicFrameClock@fb588db, androidx.compose.ui.platform.MotionDurationScaleImpl@4602f78, StandaloneCoroutine{Cancelling}@a3af651, AndroidUiDispatcher@5cdbeb6]

Comments

an...@google.com <an...@google.com> Sep 26, 2022 04:39PM

Reassigned to ch...@google.com.

ap...@google.com <ap...@google.com> #2Sep 28, 2022 09:38PM

Marked as fixed.

Also spent a good chunk of time debugging memory leaks in our apps and discovered the same thing. Upgraded all the way to `compose:1.3.0-alpha03` and `activity-compose:1.6.0-beta01` with the same leaks.

lo...@gmail.com <lo...@gmail.com> #3Sep 29, 2022 07:29AM

This is a significant issue. Every app that integrates compose with an Activity will leak that Activity.

We automated a test to switch back and forth to an Activity for about 15 minutes. Attached screenshots of our results.

170 Leaks for referencing compose `setContentView` inside an Activity.

ch...@google.com <ch...@google.com> #4Sep 29, 2022 05:33PM

To workaround, we switched to Compose Navigation, which uses a single Activity. -

https://developer.android.com/jetpack/compose/navigation

We ran the same automated test switch back and forth between screens for about 15 mins. Attached screenshots of our results.

0 Leaks.

ns...@gmail.com <ns...@gmail.com> #5Oct 3, 2022 09:32PM

Are there any updates on this issue?

Our app relies on a lot of interop with ComposeView, and this leak has been causing issues and slowing down our integration with Compose.

Any help is much appreciated!

ch...@google.com <ch...@google.com> #6Oct 4, 2022 05:07PM

Status: Assigned (reopened)

This is a huge bug and the memory keeps growing

na...@google.com <na...@google.com> #7Oct 5, 2022 05:14PM

Do we know if this is fixed in Compose 1.3.0 or 1.3.1 ? Has anyone (or OP) tried repro-ing with those versions yet?

Thanks

ns...@gmail.com <ns...@gmail.com> #8Oct 11, 2022 01:34PM

FWIW, just tried to repro the leaks with Compose + Compose Compiler 1.3.1 and the leaks seem to have stopped.

Would love confirmation about this being fixed in 1.3.1 just to be sure.