Compose runtime 1.3.0-beta03 throws ArrayIndexOutOfBoundsException [249076084]

Assigned

Bug

Status Update

No update yet.

Description

lo...@gmail.com

created issue #1

Sep 26, 2022 03:54PM

After upgrading to compose 1.3.0-beta03, my app started crashing. After investigating the issue, I was able to reproduce it in a minimal example which you can find here: https://github.com/ln-12/compose-1.3.0-crash-example

For me, it is only happening with the AlertDialog component.

Jetpack Compose version: 1.3.0-beta03
Jetpack Compose component used: runtime
Android Studio Build: Build #AI-213.7172.25.2113.9014738
Kotlin version: 1.7.10

Steps to Reproduce or Code Sample to Reproduce:

Use produceState to create a simple state which changes
Make a dialog which is dependent on that change
The app crashes when the state changes

Stack trace (if applicable):

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.example.compose_130_test, PID: 13079
    java.lang.ArrayIndexOutOfBoundsException: length=0; index=1
        at androidx.compose.runtime.SlotTableKt.containsMark(SlotTable.kt:3181)
        at androidx.compose.runtime.SlotTableKt.access$containsMark(SlotTable.kt:1)
        at androidx.compose.runtime.SlotTable.containsMark(SlotTable.kt:357)
        at androidx.compose.runtime.ComposerImpl.reportAllMovableContent(Composer.kt:3640)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent$reportGroup(Composer.kt:3553)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent$reportGroup(Composer.kt:3579)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent$reportGroup(Composer.kt:3579)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent$reportGroup(Composer.kt:3579)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent$reportGroup(Composer.kt:3579)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent(Composer.kt:3593)
        at androidx.compose.runtime.ComposerImpl.recordDelete(Composer.kt:3482)
        at androidx.compose.runtime.ComposerImpl.end(Composer.kt:2277)
        at androidx.compose.runtime.ComposerImpl.endRestartGroup(Composer.kt:2786)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
        at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:145)
        at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2375)
        at androidx.compose.runtime.ComposerImpl.skipToGroupEnd(Composer.kt:2666)
        at androidx.compose.material.MaterialThemeKt.MaterialTheme(MaterialTheme.kt:85)
        at com.example.compose_130_test.ui.theme.ThemeKt.Compose_130_testTheme(Theme.kt:41)
        at com.example.compose_130_test.ui.theme.ThemeKt$Compose_130_testTheme$1.invoke(Unknown Source:10)
        at com.example.compose_130_test.ui.theme.ThemeKt$Compose_130_testTheme$1.invoke(Unknown Source:10)
        at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:145)
        at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2375)
        at androidx.compose.runtime.ComposerImpl.skipToGroupEnd(Composer.kt:2666)
        at androidx.compose.ui.platform.AbstractComposeView$ensureCompositionCreated$1.invoke(ComposeView.android.kt:250)
        at androidx.compose.ui.platform.AbstractComposeView$ensureCompositionCreated$1.invoke(ComposeView.android.kt:249)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:107)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
        at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:228)
        at androidx.compose.ui.platform.CompositionLocalsKt.ProvideCommonCompositionLocals(CompositionLocals.kt:177)
        at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$3.invoke(AndroidCompositionLocals.android.kt:123)
        at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$3.invoke(AndroidCompositionLocals.android.kt:122)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:107)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
        at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:228)
        at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt.ProvideAndroidCompositionLocals(AndroidCompositionLocals.android.kt:114)
        at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$4.invoke(Unknown Source:8)
        at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$4.invoke(Unknown Source:10)
        at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:145)
E/AndroidRuntime:     at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2375)
        at androidx.compose.runtime.ComposerImpl.skipCurrentGroup(Composer.kt:2643)
        at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:3260)
        at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:3238)
        at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
        at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
        at androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3238)
        at androidx.compose.runtime.ComposerImpl.recompose$runtime_release(Composer.kt:3203)
        at androidx.compose.runtime.CompositionImpl.recompose(Composition.kt:771)
        at androidx.compose.runtime.Recomposer.performRecompose(Recomposer.kt:1031)
        at androidx.compose.runtime.Recomposer.access$performRecompose(Recomposer.kt:125)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:534)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:503)
        at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:34)
        at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
        at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1229)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1239)
        at android.view.Choreographer.doCallbacks(Choreographer.java:899)
        at android.view.Choreographer.doFrame(Choreographer.java:827)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1214)
        at android.os.Handler.handleCallback(Handler.java:942)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7898)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
    	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.runtime.PausableMonotonicFrameClock@fb588db, androidx.compose.ui.platform.MotionDurationScaleImpl@4602f78, StandaloneCoroutine{Cancelling}@a3af651, AndroidUiDispatcher@5cdbeb6]

Comments

an...@google.com <an...@google.com> Sep 26, 2022 04:39PM

Reassigned to ch...@google.com.

ap...@google.com <ap...@google.com> #2Sep 28, 2022 09:38PM

Marked as fixed.

Hi Nick!

TextField currently have no skinning, borders etc, and it let's the API users (i.e. FilledTextField) to define those. Even though hint (placeholder) is a common TextField feature, material had animations etc on that feature which made us believe that it highly depends on the design system to provide the hint, and foundation should ideally be independent of the design system.

Previously we had only 2 Textfield implementations, 1 on material, 1 in core. If that structured did hold, I would recommend against adding the placeholder to core.TextField. However now we have 3 of them :)

I added nona, matvei and lpf to the ticket to get their opinions.

lo...@gmail.com <lo...@gmail.com> #3Sep 29, 2022 07:29AM

I agree with Siyamed's analysis here, the implementation of a placeholder is evidently something specific to a design system. If you aren't using the Material implementation of a text field, it seems reasonable for you to need to build your own placeholder implementation - I think there is too much complexity and room for customization with transitions etc for it to be possible to build a generic version that is flexible enough to support all use cases.

ch...@google.com <ch...@google.com> #4Sep 29, 2022 05:33PM

Yes, I agree. Maybe we should add a sample to the documentation so that developers have something to begin with when they need to develop their own?

ns...@gmail.com <ns...@gmail.com> #5Oct 3, 2022 09:32PM

Adding a sample makes sense to me. I thought we previously had it but right now I couldn't find it.

Nick does it sound good to you as well?

ch...@google.com <ch...@google.com> #6Oct 4, 2022 05:07PM

Status: Assigned (reopened)

I'm not sure I agree that it depends upon design system; I can see many users wanting a simple placeholder that appears when no text is entered and disappears otherwise. Correctly implementing could be complex to correctly synchronize alignment, lines height, cursor etc. I see the benefit of having this in a library function that we can update etc.

Also asking many developers to implement this or directly copy a sample seems to be an indication the we should provide it?

Would we consider a PlaceholderTextField in foundation?

na...@google.com <na...@google.com> #7Oct 5, 2022 05:14PM

My 5 cents: I don't feel strongly about either of two sides, to be honest. I think we need to observe more and make a decision later.

I'm strongly against PlusOneFeature components in foundaiton, so I don't think PlaceholderTextField is a good component to have.

However, Nick's concerns make total sense to me, so I imagine we could end up with some placeholder api in foundation, but I'm not sure what is it now.

Anastasia, let's keep an eye on what we have in MaterialTextFields and maybe it will make sense to extract some placeholder functionality to the foundation version

ns...@gmail.com <ns...@gmail.com> #8Oct 11, 2022 01:34PM

I have ~strong opinions but I agree that we can observe more.

PlaceholderTextField sounds like a good idea, increases the API surface to manage. If we can have TextFieldPlaceholder in a way that you still need to add a TextField inside without carrying all the parameters of TextField, that makes more sense to me.

TextFieldPlaceHolder(placeholder api, content = TextField())

instead of

PlaceHolderTextField(placeholder api, all the TextField arguments...)