Compose runtime 1.3.0-beta03 throws ArrayIndexOutOfBoundsException [249076084]

Assigned

Bug

Status Update

No update yet.

Description

lo...@gmail.com

created issue #1

Sep 26, 2022 03:54PM

After upgrading to compose 1.3.0-beta03, my app started crashing. After investigating the issue, I was able to reproduce it in a minimal example which you can find here: https://github.com/ln-12/compose-1.3.0-crash-example

For me, it is only happening with the AlertDialog component.

Jetpack Compose version: 1.3.0-beta03
Jetpack Compose component used: runtime
Android Studio Build: Build #AI-213.7172.25.2113.9014738
Kotlin version: 1.7.10

Steps to Reproduce or Code Sample to Reproduce:

Use produceState to create a simple state which changes
Make a dialog which is dependent on that change
The app crashes when the state changes

Stack trace (if applicable):

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.example.compose_130_test, PID: 13079
    java.lang.ArrayIndexOutOfBoundsException: length=0; index=1
        at androidx.compose.runtime.SlotTableKt.containsMark(SlotTable.kt:3181)
        at androidx.compose.runtime.SlotTableKt.access$containsMark(SlotTable.kt:1)
        at androidx.compose.runtime.SlotTable.containsMark(SlotTable.kt:357)
        at androidx.compose.runtime.ComposerImpl.reportAllMovableContent(Composer.kt:3640)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent$reportGroup(Composer.kt:3553)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent$reportGroup(Composer.kt:3579)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent$reportGroup(Composer.kt:3579)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent$reportGroup(Composer.kt:3579)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent$reportGroup(Composer.kt:3579)
        at androidx.compose.runtime.ComposerImpl.reportFreeMovableContent(Composer.kt:3593)
        at androidx.compose.runtime.ComposerImpl.recordDelete(Composer.kt:3482)
        at androidx.compose.runtime.ComposerImpl.end(Composer.kt:2277)
        at androidx.compose.runtime.ComposerImpl.endRestartGroup(Composer.kt:2786)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
        at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:145)
        at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2375)
        at androidx.compose.runtime.ComposerImpl.skipToGroupEnd(Composer.kt:2666)
        at androidx.compose.material.MaterialThemeKt.MaterialTheme(MaterialTheme.kt:85)
        at com.example.compose_130_test.ui.theme.ThemeKt.Compose_130_testTheme(Theme.kt:41)
        at com.example.compose_130_test.ui.theme.ThemeKt$Compose_130_testTheme$1.invoke(Unknown Source:10)
        at com.example.compose_130_test.ui.theme.ThemeKt$Compose_130_testTheme$1.invoke(Unknown Source:10)
        at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:145)
        at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2375)
        at androidx.compose.runtime.ComposerImpl.skipToGroupEnd(Composer.kt:2666)
        at androidx.compose.ui.platform.AbstractComposeView$ensureCompositionCreated$1.invoke(ComposeView.android.kt:250)
        at androidx.compose.ui.platform.AbstractComposeView$ensureCompositionCreated$1.invoke(ComposeView.android.kt:249)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:107)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
        at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:228)
        at androidx.compose.ui.platform.CompositionLocalsKt.ProvideCommonCompositionLocals(CompositionLocals.kt:177)
        at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$3.invoke(AndroidCompositionLocals.android.kt:123)
        at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$3.invoke(AndroidCompositionLocals.android.kt:122)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:107)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
        at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:228)
        at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt.ProvideAndroidCompositionLocals(AndroidCompositionLocals.android.kt:114)
        at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$4.invoke(Unknown Source:8)
        at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$4.invoke(Unknown Source:10)
        at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:145)
E/AndroidRuntime:     at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2375)
        at androidx.compose.runtime.ComposerImpl.skipCurrentGroup(Composer.kt:2643)
        at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:3260)
        at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:3238)
        at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
        at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
        at androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3238)
        at androidx.compose.runtime.ComposerImpl.recompose$runtime_release(Composer.kt:3203)
        at androidx.compose.runtime.CompositionImpl.recompose(Composition.kt:771)
        at androidx.compose.runtime.Recomposer.performRecompose(Recomposer.kt:1031)
        at androidx.compose.runtime.Recomposer.access$performRecompose(Recomposer.kt:125)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:534)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:503)
        at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:34)
        at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
        at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1229)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1239)
        at android.view.Choreographer.doCallbacks(Choreographer.java:899)
        at android.view.Choreographer.doFrame(Choreographer.java:827)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1214)
        at android.os.Handler.handleCallback(Handler.java:942)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7898)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
    	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.runtime.PausableMonotonicFrameClock@fb588db, androidx.compose.ui.platform.MotionDurationScaleImpl@4602f78, StandaloneCoroutine{Cancelling}@a3af651, AndroidUiDispatcher@5cdbeb6]

Comments

an...@google.com <an...@google.com> Sep 26, 2022 04:39PM

Reassigned to ch...@google.com.

ap...@google.com <ap...@google.com> #2Sep 28, 2022 09:38PM

Marked as fixed.

This is currently also affecting a TextField as it has a blinking cursor. This means any text field that is on the screen will block our synchronization.

lo...@gmail.com <lo...@gmail.com> #3Sep 29, 2022 07:29AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ba279a0fd4cb3df553cc80cfec23353fba8c0411
Author: Jelle Fresen <jellefresen@google.com>
Date: Wed Jun 10 15:07:39 2020

Disable blinking cursor in tests by default

The blinking cursor is a poster child example of an infinite animation.
As long as we don't have a solution in place to properly deal with
infinite animations, we disable the blinking cursor in tests to avoid
tests from timing out just because there is a TextField that has focus
in the test.

I moved the TextField tests for the cursor to a separate test class, so
we can explicitly enable (and manually control) the blinking cursor for
thoses tests.

Bug: 151940543
Test: ./gradlew ui:ui-foundation:cC ui:ui-material:cC ui:ui-test:cC
Change-Id: I12984b8f43f6b587aa5cd9aabeaea96309e9086b

M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/SoftwareKeyboardTest.kt
A ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldCursorTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldOnValueChangeTextFieldValueTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/TextField.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/FilledTextFieldTest.kt
M ui/ui-test/api/0.1.0-dev14.txt
M ui/ui-test/api/api_lint.ignore
M ui/ui-test/api/current.txt
M ui/ui-test/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-test/api/public_plus_experimental_current.txt
M ui/ui-test/api/restricted_0.1.0-dev14.txt
M ui/ui-test/api/restricted_current.txt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/ComposeTestRule.kt
M ui/ui-test/src/main/java/androidx/ui/test/android/AndroidComposeTestRule.kt

https://android-review.googlesource.com/1329004

https://goto.google.com/android-sha1/ba279a0fd4cb3df553cc80cfec23353fba8c0411

ch...@google.com <ch...@google.com> #4Sep 29, 2022 05:33PM

This bug was referenced by a recent CL that changed the Android API surface area.

The Android API Council <

http://go/android-api-council> regularly reviews API changes for
consistency and sustainability, and we've just added this bug to our hotlist of pending reviews.
We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out
if you'd like us to review it sooner.

CHANGES TO ui/ui-test/api/current.txt

http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.test

http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.test.ComposeTestRuleKt

http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.test.android

http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.test.android.AndroidComposeTestCaseSetup

http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.test.android.AndroidComposeTestRuleKt

CHANGES TO ui/ui-test/api/public_plus_experimental_current.txt

http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.test

http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.test.ComposeTestRuleKt

http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.test.android

http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.test.android.AndroidComposeTestCaseSetup

http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.test.android.AndroidComposeTestRuleKt

The links above may take several days to start working. Generated from

http://go/support-current.txt/ba279a0fd4cb3df553cc80cfec23353fba8c0411

[Gerrit:

http://android-review.googlesource.com/1329004]
[API-Approvers:pavlis@google.com]

[LIBRARY_API_REVIEW_TAG:ui/ui-test/api/0.1.0-dev14.txt]

ns...@gmail.com <ns...@gmail.com> #5Oct 3, 2022 09:32PM

Hi Jelle. Is this fixed or is there still more work to do? Thanks!

ch...@google.com <ch...@google.com> #6Oct 4, 2022 05:07PM

Status: Assigned (reopened)

Hi Jelle. Can you please update this by eod Tues so that we can close the iteration. Thanks.

na...@google.com <na...@google.com> #7Oct 5, 2022 05:14PM

Sorry, removed it from the dev14 hotlist

ns...@gmail.com <ns...@gmail.com> #8Oct 11, 2022 01:34PM

A workaround that can be used if you encounter this problem in one of your tests, is to pause the clock at the beginning of the test and advance it manually whenever you need to move forward in the animations that are currently running:

@get:Rule
val composeTestRule = createComposeRule()
val clockTestRule get() = composeTestRule.clockTestRule

@Test
fun test() {
  clockTestRule.pauseClock()
  // ...
  runOnIdle {
    clockTestRule.advanceClock(1000)
  }
  // ...
}