Reset compilation without reinstall [249143766]

Fixed

Bug

Status Update

No update yet.

Description

cc...@google.com

created issue #1

Sep 26, 2022 08:17PM

See b/230518212 and b/230665435

Comments

cc...@google.com <cc...@google.com> #2Sep 28, 2022 10:34PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Oct 28, 2022 03:44PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 7c275cf935cf13bb319a7af0a0e1c87bcb493f32
Author: Chris Craik <ccraik@google.com>
Date: Thu Oct 20 17:27:34 2022

Reset Compilation cleanly, without reinstall

Fixes: 249143766
Test: CompilationConsistencyBenchmark
Test: CompilationModeTest
Relnote: " No longer uninstall and reinstall target app to reset
compilation. With further investigation, the sole reason this was
necessary was to reset shader state, which has been fixed
separately. Now the target app remains installed, even without root,
without affecting app data. "

Change-Id: I8405b59a85e04f9ae3eeee0e3eecedcc47241e02

M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/CompilationMode.kt
A compose/integration-tests/macrobenchmark/src/androidTest/java/androidx/compose/integration/macrobenchmark/CompilationConsistencyBenchmark.kt

https://android-review.googlesource.com/2264162

cc...@google.com <cc...@google.com> #4Oct 31, 2022 10:42PM

Status: Assigned (reopened)

The change to no longer use command pkg compile --reset has made baseline profiles and warmup iterations much closer than before, for example:

CompilationMode.Full + None aren't affected, so it looks like profiles aren't getting cleared as we'd expect them to.

ji...@google.com <ji...@google.com> #5Nov 1, 2022 01:45PM

This is WAI. Neither delete-dexopt nor compile -f -m verify touches any profile. They should only change the compilation state. We intentionally keep the profiles so that they can be used again on the next compile -m speed-profile. If you would like to clear profiles, please use compile --reset.

ap...@google.com <ap...@google.com> #6Nov 2, 2022 01:02AM

Project: platform/frameworks/support
Branch: androidx-main

commit 85512318758266d73a60c2fe74960387827068e5
Author: Chris Craik <ccraik@google.com>
Date: Tue Nov 01 15:56:03 2022

Revert "Reset Compilation cleanly, without reinstall"

Bug:249143766
Fixes:256693133
Test: BaselineProfileRuleTest

Resetting compilation without reinstall will need to wait for API 34,
as there's no way to clear the reference profile for any methods
already compiled.

A follow up should use --reset on API 34, and consider skipping
--reset for Full / None, as it shouldn't be necessary.

Note that this revert leaves the kdoc changes in place.

This reverts commit 7c275cf935cf13bb319a7af0a0e1c87bcb493f32.

Change-Id: I5719feb75876b450402009a9cb529c2a79c7cf2b

M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/CompilationMode.kt
D compose/integration-tests/macrobenchmark/src/androidTest/java/androidx/compose/integration/macrobenchmark/CompilationConsistencyBenchmark.kt

https://android-review.googlesource.com/2282121

ap...@google.com <ap...@google.com> #7Feb 8, 2023 11:08PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 89b4c45ba74dfb3eb7a702c4534140074e8f3cd5
Author: Chris Craik <ccraik@google.com>
Date: Wed Feb 08 13:41:13 2023

Support cmd package compile --reset on Android 14

Fixes: 249143766
Test: TrivialStartupBenchmark
Test: CompilationModeTest
Relnote: "On Android 14+, Macrobenchmark no longer reinstalls target
applications to reset compilation state, thanks to a new platform
feature. Previously it was necessary to have a rooted device, or to
deal with all application state (e.g. login) being removed before each
benchmark runs."

Also adds clarifying error to internal legacy metric failure occurring
on Android 14.

Change-Id: I9b08cfecc36735d057b388e75d1c9b50b53ed083

M benchmark/benchmark-macro/build.gradle
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/CompilationMode.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt

https://android-review.googlesource.com/2427952

na...@google.com <na...@google.com> #8Feb 22, 2023 07:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-macro:1.2.0-alpha10