Fixed
Status Update
No update yet.
Comments
il...@google.com
yr...@google.com
Yigit, do you have time to fix it?
reemission of the same liveData is racy
reemission of the same liveData is racy
ap...@google.com
yea i'll take it.
il...@google.com
Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.
na...@google.com
just emitting same live data reproduces the issue.
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
al...@gmail.com
Comment has been deleted.
fv...@gmail.com
Comment has been deleted.
fv...@gmail.com
Comment has been deleted.
fv...@gmail.com
Comment has been deleted.
ar...@gmail.com
I didn't approve of any of this on my device can you please remove
al...@gmail.com
J
al...@gmail.com
J
al...@gmail.com
G
al...@gmail.com
H
al...@gmail.com
H
al...@gmail.com
U
al...@gmail.com
Y
al...@gmail.com
Y
al...@gmail.com
6j
al...@gmail.com
Y
Description
Component used: Activity
Version used: 1.6.0
Devices/Android versions reproduced on: Samsung Galaxy S20+ Android 12 (with August 2022 Google Play system update, photo picker is confirmed working)
For
ActivityResultContracts.PickMultipleVisualMedia, you useInteger.MAX_VALUEas an overload for the maximum number of items the photo picker is able to select for versions Android 12 and below (asMediaStore.getPickImagesMaxLimit()is only available forTIRAMISUand above).However, using this value causes the photo picker to not be able to start/be launched.
I tried changing the
maxItemsvalue to another value (I tried 100) and the photo picker started to work.