Upgrade assistant does not handle settings plugin [249325631]

Fixed

Bug

Status Update

No update yet.

Description

xa...@google.com

created issue #1

Sep 27, 2022 06:57PM

If you have a project with the settings plugin applied, and the assistant has to upgrade your project, it will not change the version of the settings plugin.

I had a project with using 7.4.0-alpha02 in build file and in settings.gradle, and it triggered a forced upgrade when opening with Flamingo Canary 2.

The assistant changed the version of the app and library plugin in build.gradle but left settings.gradle untouched.

The content of that file had this section:

plugins {
    id 'com.android.settings' version '7.4.0-alpha02'
}

Comments

xo...@google.com <xo...@google.com> Sep 28, 2022 09:31AM

Accepted by xo...@google.com.

xo...@google.com <xo...@google.com> #2Sep 30, 2022 04:17PM

Status: Assigned (reopened)

I have submitted a fix for this for Flamingo. Should we cherry-pick it to Electric Eel?

xa...@google.com <xa...@google.com> #3Oct 28, 2022 08:35PM

isn't the settings new in 7.4? I think the migration from non-stable version is unfortunate but less of an issue.

If we have project with stable settings plugin in 7.3 that's more a problem and we should cherry-pick.

xo...@google.com <xo...@google.com> #4Oct 31, 2022 09:36AM

I don't know of any projects with settings plugins in 7.3, but note that if we don't have it in the Electric Eel sources we will be unable to upgrade e.g. 7.4.0 to 7.4.1.

xa...@google.com <xa...@google.com> #5Oct 31, 2022 04:01PM

Can you point me to the change that fix this in F so that we can see if we can safely take it in EE?

xo...@google.com <xo...@google.com> #6Nov 1, 2022 09:50AM

The changes are the top two commits visible at https://android.googlesource.com/platform/tools/adt/idea/+log?s=b04142b4b0d78feda92760bd1e84afa21982c6bb

xo...@google.com <xo...@google.com> Nov 1, 2022 04:11PM

Marked as fixed.

ha...@gmail.com <ha...@gmail.com> #7Dec 15, 2022 01:17AM

=-\
;uytyujiuoilklkiuyk,iuy