Wrong onActivityResult data dispatch by FragmentManager default mStartActivityForResult launcher [249519359]

Fixed

Bug

Status Update

No update yet.

Description

jv...@gmail.com

created issue #1

Sep 28, 2022 04:41PM

Component used:

- **androix.fragment**: `androidx.fragment:fragment:1.3.6`
- **androix.activity**: `androidx.activity:activity:1.2.4`

Devices/Android versions reproduced on: Samsung Galaxy S10 Lite

**Issue**

When multiple activities are launched sequentially from a fragment using the deprecated API `Fragment.startActivityForResult`, the order of launch is well defined but the calls back to `Fragment.onActivityResult` get messed up when all the started activities `setResult` and finish.

As it can be noticed in the logs below, `ResultActivity1` is started with `requestCode=1111` and `ResultActivity2` with `requestCode=2222`, but when both activities set result and dismiss, `onActivityResult` is called with `ResultActivity2` but `requestCode` of `ResultActivity1` and the same for `ResultActivity1`.

```
17:17:52.050 E startActivityForResult: me.jansv.ari.ResultActivity1{requestCode=1111}
17:17:52.187 E startActivityForResult: me.jansv.ari.ResultActivity2{requestCode=2222}
17:17:57.055 E onActivityResult: requestCode=1111, resultCode=-1, extras={ResultActivity2=ResultActivity2.value}
17:17:57.055 E onActivityResult: requestCode=2222, resultCode=-1, extras={ResultActivity1=ResultActivity1.value}
```

**Steps to reproduce**

Using the sample project, click rapidly and in order buttons `Activity 1` and `Activity 2`, then click `Set Result 2` followed by `Set Result 1`.

This is possible in the context of translucent activities that allow click-through or when some delay at starting the first activity allows the click on the second button to trigger.

**Potential cause**

When `Fragment.startActivityForResult` is called, it [register](

https://github.com/androidx/androidx/blob/androidx-main/fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java#L2821-L2822) in a queue, launch meta which includes the `requestCode` but when is time to dispatch `Fragment.onActivityResult`, is [taken](

https://github.com/androidx/androidx/blob/androidx-main/fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java#L2684) from the queue, the meta's according launch order, which might not correlate with the intent actually calling `onActivityResult`.

This means that if the state of the queue is something like: `{meta{requestCode=1111}, meta{requestCode=2222}}` for sequential launch of `ResultActivity1`, `ResultActivity2`. If `ResultActivity2` set result first, then, we'll endup with `meta{requestCode=1111}` and `ActivityResult` from `ResultActivity2`.

sample-project.zip

379 KB

Download

logs.png

137 KB

View

Download

Comments

jb...@google.com <jb...@google.com> #2Sep 28, 2022 05:19PM

Seems to be a DNS problem with systems that have 'obtain DNS server address automatically'. Changed my system to a manual setting and the browser etc now work. SDK 2.2 didn't seem to mind the auto setting though.

jv...@gmail.com <jv...@gmail.com> #3Sep 28, 2022 05:28PM

Could you please describe how/where you changed your system to a manual setting?

Message last modified on Sep 28, 2022 05:29PM

il...@google.com <il...@google.com> Nov 8, 2022 09:09PM

Assigned to sa...@google.com.

an...@immobiliare.it <an...@immobiliare.it> #4Dec 1, 2022 08:26AM

Based on its date, this issue was originally reported before Android 2.3. Because of the many changes that existed in Android 4.x compared to previous versions, it's very likely that this issue doesn't exist in recent versions of Android like 4.2.2 or newer. Because of the high likelihood that this issue is obsolete, it is getting closed automatically by a script, without a human looking at it in detail. If the issue still exists on a Nexus 4 or Nexus 7 running Android 4.2.2 and is not related to Google applications, please open a new report accordingly.

sa...@google.com <sa...@google.com> Apr 27, 2023 03:54AM

Accepted by sa...@google.com.

ap...@google.com <ap...@google.com> #5Apr 27, 2023 10:06PM

Marked as fixed.

java.lang.IllegalArgumentException: Unable to locate adb
at com.android.tools.idea.run.editor.DeployTargetPickerDialog.<init>(DeployTargetPickerDialog.java:144)
at com.android.tools.idea.run.editor.ShowChooserTargetProvider.showPrompt(ShowChooserTargetProvider.java:113)
at com.android.tools.idea.run.AndroidRunConfigurationBase.getDeployTarget(AndroidRunConfigurationBase.java:600)
at com.android.tools.idea.run.AndroidRunConfigurationBase.doGetState(AndroidRunConfigurationBase.java:281)
at com.android.tools.idea.run.AndroidRunConfigurationBase.getState(AndroidRunConfigurationBase.java:241)
at com.intellij.execution.runners.ExecutionEnvironment.getState(ExecutionEnvironment.java:158)
at com.intellij.execution.runners.BaseProgramRunner.execute(BaseProgramRunner.java:55)
at com.intellij.execution.runners.BaseProgramRunner.execute(BaseProgramRunner.java:50)
at com.intellij.execution.ProgramRunnerUtil.executeConfigurationAsync(ProgramRunnerUtil.java:92)
at com.intellij.execution.ProgramRunnerUtil.executeConfiguration(ProgramRunnerUtil.java:41)
at com.intellij.execution.impl.ExecutionManagerImpl.restart(ExecutionManagerImpl.java:93)
at com.intellij.execution.impl.ExecutionManagerImpl.access$300(ExecutionManagerImpl.java:44)
at com.intellij.execution.impl.ExecutionManagerImpl$3.run(ExecutionManagerImpl.java:442)
at com.intellij.util.concurrency.QueueProcessor.runSafely(QueueProcessor.java:232)
at com.intellij.util.Alarm$Request.runSafely(Alarm.java:356)
at com.intellij.util.Alarm$Request.run(Alarm.java:343)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at com.intellij.util.concurrency.SchedulingWrapper$MyScheduledFutureTask.run(SchedulingWrapper.java:228)
at com.intellij.openapi.application.TransactionGuardImpl$2.run(TransactionGuardImpl.java:315)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.doRun(LaterInvocator.java:435)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.runNextEvent(LaterInvocator.java:419)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.run(LaterInvocator.java:403)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:762)
at java.awt.EventQueue.access$500(EventQueue.java:98)
at java.awt.EventQueue$3.run(EventQueue.java:715)
at java.awt.EventQueue$3.run(EventQueue.java:709)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:732)
at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:755)
at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:704)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:391)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

il...@google.com <il...@google.com> #6Apr 28, 2023 09:17PM

voilà ce qu'on m'affiche lorsque j’exécute mon programme

il...@google.com <il...@google.com> #7Apr 28, 2023 09:17PM

je ne vois pas comment résoudre ce problème. svp aidez moi

na...@google.com <na...@google.com> #8May 10, 2023 07:09PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.fragment:fragment:1.6.0-rc01