Broken version constraint in androidx.lifecycle:lifecycle-viewmodel [249686765]

Fixed

Bug

Status Update

No update yet.

Description

da...@google.com

created issue #1

Sep 29, 2022 07:35AM

Component used:lifecycle-viewmodel

Version used: 2.6.0-alpha02

In this bug, version constraints were introduced in lifecycle dependencies to help reduce the likelihood of having conflicting lifecycle versions on the classpath.

It appears however, that the constraints in the latest version of lifecycle-viewmodel itself introduces a version conflict.

Running the gradle dependencies command on a module containing it yields the following:

+--- project :app (*)
+--- androidx.activity:activity-compose:1.3.1
|    +--- androidx.activity:activity-ktx:1.3.1
|    |    +--- androidx.activity:activity:1.3.1
|    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
|    |    |    +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
|    |    |    +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.6.0-alpha02 (*)
|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.6.0-alpha02
|    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 (*)
|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:{androidx.LibraryVersions.LIFECYCLE} -> 2.3.1 (c)
|    |    |    |    \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.0-alpha02 (c)

In this line

androidx.lifecycle:lifecycle-viewmodel-ktx:{androidx.LibraryVersions.LIFECYCLE} -> 2.3.1 (c)

lifecycle-viewmodel-ktx has a version constraint to 2.3.1.

The result is, in any project with the following lines added to their app dependencies:

    implementation "androidx.lifecycle:lifecycle-viewmodel:2.6.0-alpha02"
    implementation "androidx.lifecycle:lifecycle-livedata-ktx:2.6.0-alpha02"

Will see the following build failure:

Execution failed for task ':app:checkDebugDuplicateClasses'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable
   > Duplicate class androidx.lifecycle.ViewModelLazy found in modules lifecycle-viewmodel-2.6.0-alpha02-runtime (androidx.lifecycle:lifecycle-viewmodel:2.6.0-alpha02) and lifecycle-viewmodel-ktx-2.3.1-runtime (androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1)
     Duplicate class androidx.lifecycle.ViewTreeViewModelKt found in modules lifecycle-viewmodel-2.6.0-alpha02-runtime (androidx.lifecycle:lifecycle-viewmodel:2.6.0-alpha02) and lifecycle-viewmodel-ktx-2.3.1-runtime (androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1)

Comments

il...@google.com <il...@google.com> Sep 29, 2022 06:32PM

Assigned to sa...@google.com.

il...@google.com <il...@google.com> Sep 29, 2022 10:47PM

Status: Won't Fix (Infeasible)

il...@google.com <il...@google.com> Sep 30, 2022 03:24PM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #2Oct 5, 2022 07:23PM

Jeremy, is this still an issue? I think the problem was that you had two transitions targeting the same View for the same action (e.g. two Slide() transitions).

il...@google.com <il...@google.com> #3Oct 14, 2022 08:30PM

Marked as fixed.

I have a similar issue with plain AnimatorSet:

set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()

doesn't play animation in resume().

na...@google.com <na...@google.com> #4Oct 24, 2022 01:37PM

Should clarify that if I filter out setCurrentPlayTime(0) (or replace it with setCurrentPlayTime(1)) it works well.

Also even with setCurrentPlayTime(0), onAnimationEnd is notified with correct delay (as if the animation has played).

Issue 249686765