[M3] TopAppBar colors [249688556]

Fixed

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Sep 29, 2022 07:40AM

Jetpack Compose version: 1.3 B3 / 4 Jetpack Compose component used: M3

The fix https://issuetracker.google.com/issues/245575782 was not applied to MediumTopAppBarand LargeTopAppBar.

It is necessary to properly change colors on those as only the first row of the topbar have the proper color now the rest have the surface one.

Comments

sg...@google.com <sg...@google.com> Sep 29, 2022 09:05AM

Reassigned to sg...@google.com.

sg...@google.com <sg...@google.com> Oct 12, 2022 11:32PM

Accepted by sg...@google.com.

ap...@google.com <ap...@google.com> #2Oct 13, 2022 04:35PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

sg...@google.com <sg...@google.com> Oct 13, 2022 04:35PM

Marked as fixed.

to...@gmail.com <to...@gmail.com> #3Oct 13, 2022 06:31PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

Message last modified on Oct 13, 2022 06:32PM

sg...@google.com <sg...@google.com> #4Oct 13, 2022 09:32PM

This will be out on 1.1.0-alpha01.

de...@gmail.com <de...@gmail.com> #5Oct 13, 2022 09:35PM

Rly? So the upcoming stable 1.0.0 will be unusable for a lot of people...?

si...@gmail.com <si...@gmail.com> #6Oct 17, 2022 09:00AM

So we have to wait for version 1.1.0-alpha01 for this simple fix. Basically making the M3 useless for developers... nice!

to...@gmail.com <to...@gmail.com> #7Oct 17, 2022 09:02AM

Alpha1 will be out at the same time as the final as they usually do.

The only real question for me that allows alpha in prod, is that I hope that 1.1 won't be pinned to compose UI 1.4 and still allow 1.3.

sg...@google.com <sg...@google.com> #8Oct 19, 2022 09:19PM

We understand the urgency, but please note that the top app bar is still marked as experimental, so changes should always be expected until we remove this mark :)

Also, there is a chance we will release a 1.3.1 bug-fix release. If that happens, this will be cherry-picked into an equivalent Material3 1.0.1.

Cheers.

to...@gmail.com <to...@gmail.com> #9Oct 24, 2022 02:40PM

Ok so M3 1.1 is tied to Compose 1.4 :( And this fix did not make it to 1.1 A1 will be in A2 :(

na...@google.com <na...@google.com> #10Nov 9, 2022 06:28PM