IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date:   Wed Sep 18 16:55:49 2019

    Change the way to detect mismatch between POJO and query
   
    This fixes cursor mismatch warnings with expandProjection.
   
    Bug: 140759491
    Test: QueryMethodProcessorTest
    Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M       room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

  The following changes were cherrypicked through Coastguard (https://android-build.googleplex.com/coastguard/)
  Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
  Created: 2019-10-14 17:23:42.610596+00:00
  Changes: aosp/1123258
 

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date:   Thu Apr 16 16:47:05 2020

    Re-factor how errors are dismissed when query is re-written
   
    This CL changes how we handle errors/warnings if query is
    re-written.
    There was a bug in expandProjection where we would report warnings
    for things that Room already fixes automatically (b/140759491).
    The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
    solved it by deferring validating of columns until after re-write
    decision is made. Unfortunately, this required changing PojoRowAdapter
    to have a dummy mapping until it is validating, make it hard to use
    as it does have a non-null mapping which is not useful.
   
    This CL partially reverts that change and instead rely on the log
    deferring logic we have in Context. This way, we don't need to break
    the stability of PojoRowAdapter while still having the ability to
    drop warnings that room fixes. This will also play nicer when we
    have different query re-writing options that can use more information
    about the query results.
   
    Bug: 153387066
    Bug: 140759491
    Test: existing tests pass
    Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M       room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

Project: platform/frameworks/support
Branch: androidx-main

commit e59d4c20268f10741b4bfb0d939884704659043c
Author: Abhijith Nair <abhijithnair@google.com>
Date:   Tue Oct 25 13:58:31 2022

    Unhide ProcessGlobalConfig APIs
   
    Along with unhiding the APIs, the API files are also updated.
   
    Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
    Bug: 250553687
    Relnote: "Add ProcessGlobalConfig enabling users to set process global
    config prior to loading WebView."
   
    Change-Id: I7c0e0e42e91efe45f16e66afead7b9e52240bfe4

M       webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/ProcessGlobalConfigActivityTestAppTest.java
M       webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/WebkitTestHelpers.java
M       webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/ProcessGlobalConfigActivity.java
M       webkit/webkit/api/current.txt
M       webkit/webkit/api/public_plus_experimental_current.txt
M       webkit/webkit/api/restricted_current.txt
M       webkit/webkit/src/main/java/androidx/webkit/ProcessGlobalConfig.java
M       webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java
M       webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java
M       webkit/webkit/src/main/java/androidx/webkit/internal/WebViewFeatureInternal.java

https://android-review.googlesource.com/2268927

Project: platform/frameworks/support
Branch: androidx-main

commit d1b0ecf7a695406a3a88da9a5f6c6b1859b784a9
Author: Abhijith Nair <abhijithnair@google.com>
Date:   Tue Nov 01 18:07:17 2022

    Rename the WebView manifest key name
   
    Rename SET_DATA_DIRECTORY_SUFFIX:DEV to
    STARTUP_FEATURE_SET_DATA_DIRECTORY_SUFFIX
   
   
    Change-Id: Id2a0a29a3cbc6972bbf285836cd13e8d2af7fd3d
    Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
    Bug: 250553687

M       webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java

https://android-review.googlesource.com/2280854

Project: platform/frameworks/support
Branch: androidx-main

commit 531fd4f5db9931f8d6899c79082ece40a5cc0e3c
Author: Abhijith Nair <abhijithnair@google.com>
Date:   Mon Jan 30 18:15:05 2023

    Refactor ProcessGlobalActivity in testapp
   
    Since there are multiple features we would need to test within
    Process Global Config, this CL adds a level of nesting where Process
    Global Config activity displays a set of feature specific activties.
   
    Test: "./gradlew :webkit:integration-tests:testapp:connectedCheck --info
    -Pandroid.testInstrumentationRunnerArguments.class=com.example.androidx.webkit.ProcessGlobalConfigActivityTestAppTest"
    Bug: 250553687
   
    Change-Id: I6e4123aefec34fbb24c260a66a2e3dbbc43556bc

M       webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/ProcessGlobalConfigActivityTestAppTest.java
M       webkit/integration-tests/testapp/src/main/AndroidManifest.xml
A       webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/DataDirectorySuffixActivity.java
M       webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/ProcessGlobalConfigActivity.java
M       webkit/integration-tests/testapp/src/main/res/layout/activity_data_directory_config.xml
M       webkit/integration-tests/testapp/src/main/res/values/donottranslate-strings.xml

https://android-review.googlesource.com/2411326

Project: platform/frameworks/support
Branch: androidx-main

commit d61774ca31b0e93f9fe67eae948c14da3b9ed3c3
Author: Abhijith Nair <abhijithnair@google.com>
Date:   Mon Jan 30 17:40:39 2023

    Add ProcessGlobalConfig setDirectoryBasePath()
   
    This CL adds ProcessGlobalConfig#setDirectoryBasePath(Context, String,
    String) method.
    This API enables users to specify data and cache directory base paths
    that should be used by WebView and tells WebView not to use the defaults.
   
    A feature string has been added to check if the underlying WebView
    supports the feature.
   
    Testapp has been updated to exercise the new API and an integration test
    has been added to test against the new Activity.
   
    Related Chromium CL: https://crrev.com/c/4225963
   
    Bug: 250553687
    Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
    Change-Id: I45111b6ec6f3cc0b614479ca37a42acdbeb5d83d

M       webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/ProcessGlobalConfigActivityTestAppTest.java
M       webkit/integration-tests/testapp/src/main/AndroidManifest.xml
M       webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/DataDirectorySuffixActivity.java
A       webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/DirectoryBasePathActivity.java
M       webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/ProcessGlobalConfigActivity.java
M       webkit/integration-tests/testapp/src/main/res/values/donottranslate-strings.xml
M       webkit/webkit/src/main/java/androidx/webkit/ProcessGlobalConfig.java
M       webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java
M       webkit/webkit/src/main/java/androidx/webkit/internal/StartupApiFeature.java
M       webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java
M       webkit/webkit/src/main/java/androidx/webkit/internal/WebViewFeatureInternal.java

https://android-review.googlesource.com/2426541

Project: platform/frameworks/support
Branch: androidx-main

commit bcebef0a174188b46023a81b0b2b436b416b66e2
Author: Abhijith Nair <abhijithnair@google.com>
Date:   Fri Feb 17 16:23:44 2023

    Unhide ProcessGlobalConfig#setDirectoryBasePath()
   
    API files are also updated.
   
    Relnote: "Add ProcessGlobalConfig#setDirectoryBasePath(String, String) API"
    Bug: 250553687
    Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
    Change-Id: Ibd1a165dd2739b652b26d3c5f2cfe773cb7eb386

M       webkit/webkit/api/current.txt
M       webkit/webkit/api/public_plus_experimental_current.txt
M       webkit/webkit/api/restricted_current.txt
M       webkit/webkit/src/main/java/androidx/webkit/ProcessGlobalConfig.java
M       webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java

https://android-review.googlesource.com/2443580

Project: platform/frameworks/support
Branch: androidx-main

commit 59e4bef48c9472debc8e8a418155977c81896e5a
Author: Abhijith Nair <abhijithnair@google.com>
Date:   Wed Mar 01 18:49:22 2023

    Rename the WebView manifest key name
   
    Rename STARTUP_FEATURE_SET_DIRECTORY_BASE_PATH:DEV
    to STARTUP_FEATURE_SET_DIRECTORY_BASE_PATH
   
    Change-Id: I33a366dd64b1a63a6b39a9122749009cae37fde9
    Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
    Bug: 250553687

M       webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java

https://android-review.googlesource.com/2464551