WebView Process Global Config [250553687]

Fixed

Feature

Status Update

No update yet.

Description

ab...@google.com

created issue #1

Oct 3, 2022 12:00PM

This is a tracking bug.

DD: go/wv-process-wide-config

Comments

ab...@google.com <ab...@google.com> #2Oct 3, 2022 12:01PM

Accepted by ab...@google.com.

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

ab...@google.com <ab...@google.com> #3Oct 3, 2022 12:36PM

Great! Thanks a lot, I'll look for the live updates soon!

ap...@google.com <ap...@google.com> #4Oct 25, 2022 12:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit a0fc2a2e7b8c8c09e36202915d836e67c3312253
Author: Abhijith Nair <abhijithnair@google.com>
Date: Mon Oct 03 13:11:02 2022

Add test for ProcessGlobalConfigActivity

Test ensures that there exists a data directory present on the device
with the name specified using `setDataDirectorySuffix(String, Context)`.

Bug: 250553687
Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
Change-Id: Ic1391ac6527fa78464ed4c9f685a067d6dcb3dc1

A webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/ProcessGlobalConfigActivityTestAppTest.java
M webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/WebkitTestHelpers.java
M webkit/integration-tests/testapp/src/main/AndroidManifest.xml
M webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/ProcessGlobalConfigActivity.java
A webkit/integration-tests/testapp/src/main/res/layout/activity_process_global_config.xml
M webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java

https://android-review.googlesource.com/2239836

ap...@google.com <ap...@google.com> #5Nov 1, 2022 05:48PM

Project: platform/frameworks/support
Branch: androidx-main

commit e59d4c20268f10741b4bfb0d939884704659043c
Author: Abhijith Nair <abhijithnair@google.com>
Date: Tue Oct 25 13:58:31 2022

Unhide ProcessGlobalConfig APIs

Along with unhiding the APIs, the API files are also updated.

Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
Bug: 250553687
Relnote: "Add ProcessGlobalConfig enabling users to set process global
config prior to loading WebView."

Change-Id: I7c0e0e42e91efe45f16e66afead7b9e52240bfe4

M webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/ProcessGlobalConfigActivityTestAppTest.java
M webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/WebkitTestHelpers.java
M webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/ProcessGlobalConfigActivity.java
M webkit/webkit/api/current.txt
M webkit/webkit/api/public_plus_experimental_current.txt
M webkit/webkit/api/restricted_current.txt
M webkit/webkit/src/main/java/androidx/webkit/ProcessGlobalConfig.java
M webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java
M webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java
M webkit/webkit/src/main/java/androidx/webkit/internal/WebViewFeatureInternal.java

https://android-review.googlesource.com/2268927

ap...@google.com <ap...@google.com> #6Nov 1, 2022 06:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit d1b0ecf7a695406a3a88da9a5f6c6b1859b784a9
Author: Abhijith Nair <abhijithnair@google.com>
Date: Tue Nov 01 18:07:17 2022

Rename the WebView manifest key name

Rename SET_DATA_DIRECTORY_SUFFIX:DEV to
STARTUP_FEATURE_SET_DATA_DIRECTORY_SUFFIX

Change-Id: Id2a0a29a3cbc6972bbf285836cd13e8d2af7fd3d
Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
Bug: 250553687

M webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java

https://android-review.googlesource.com/2280854

ap...@google.com <ap...@google.com> #7Feb 9, 2023 02:08PM

Project: platform/frameworks/support
Branch: androidx-main

commit 531fd4f5db9931f8d6899c79082ece40a5cc0e3c
Author: Abhijith Nair <abhijithnair@google.com>
Date: Mon Jan 30 18:15:05 2023

Refactor ProcessGlobalActivity in testapp

Since there are multiple features we would need to test within
Process Global Config, this CL adds a level of nesting where Process
Global Config activity displays a set of feature specific activties.

Test: "./gradlew :webkit:integration-tests:testapp:connectedCheck --info
-Pandroid.testInstrumentationRunnerArguments.class=com.example.androidx.webkit.ProcessGlobalConfigActivityTestAppTest"
Bug: 250553687

Change-Id: I6e4123aefec34fbb24c260a66a2e3dbbc43556bc

M webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/ProcessGlobalConfigActivityTestAppTest.java
M webkit/integration-tests/testapp/src/main/AndroidManifest.xml
A webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/DataDirectorySuffixActivity.java
M webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/ProcessGlobalConfigActivity.java
M webkit/integration-tests/testapp/src/main/res/layout/activity_data_directory_config.xml
M webkit/integration-tests/testapp/src/main/res/values/donottranslate-strings.xml

https://android-review.googlesource.com/2411326

ap...@google.com <ap...@google.com> #8Feb 17, 2023 11:57AM

Project: platform/frameworks/support
Branch: androidx-main

commit d61774ca31b0e93f9fe67eae948c14da3b9ed3c3
Author: Abhijith Nair <abhijithnair@google.com>
Date: Mon Jan 30 17:40:39 2023

Add ProcessGlobalConfig setDirectoryBasePath()

This CL adds ProcessGlobalConfig#setDirectoryBasePath(Context, String,
String) method.
This API enables users to specify data and cache directory base paths
that should be used by WebView and tells WebView not to use the defaults.

A feature string has been added to check if the underlying WebView
supports the feature.

Testapp has been updated to exercise the new API and an integration test
has been added to test against the new Activity.

Related Chromium CL:

https://crrev.com/c/4225963

Bug: 250553687
Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
Change-Id: I45111b6ec6f3cc0b614479ca37a42acdbeb5d83d

M webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/ProcessGlobalConfigActivityTestAppTest.java
M webkit/integration-tests/testapp/src/main/AndroidManifest.xml
M webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/DataDirectorySuffixActivity.java
A webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/DirectoryBasePathActivity.java
M webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/ProcessGlobalConfigActivity.java
M webkit/integration-tests/testapp/src/main/res/values/donottranslate-strings.xml
M webkit/webkit/src/main/java/androidx/webkit/ProcessGlobalConfig.java
M webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java
M webkit/webkit/src/main/java/androidx/webkit/internal/StartupApiFeature.java
M webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java
M webkit/webkit/src/main/java/androidx/webkit/internal/WebViewFeatureInternal.java

https://android-review.googlesource.com/2426541

ap...@google.com <ap...@google.com> #9Feb 24, 2023 04:04PM

Project: platform/frameworks/support
Branch: androidx-main

commit bcebef0a174188b46023a81b0b2b436b416b66e2
Author: Abhijith Nair <abhijithnair@google.com>
Date: Fri Feb 17 16:23:44 2023

Unhide ProcessGlobalConfig#setDirectoryBasePath()

API files are also updated.

Relnote: "Add ProcessGlobalConfig#setDirectoryBasePath(String, String) API"
Bug: 250553687
Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
Change-Id: Ibd1a165dd2739b652b26d3c5f2cfe773cb7eb386

M webkit/webkit/api/current.txt
M webkit/webkit/api/public_plus_experimental_current.txt
M webkit/webkit/api/restricted_current.txt
M webkit/webkit/src/main/java/androidx/webkit/ProcessGlobalConfig.java
M webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java

https://android-review.googlesource.com/2443580

ap...@google.com <ap...@google.com> #10Mar 1, 2023 09:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit 59e4bef48c9472debc8e8a418155977c81896e5a
Author: Abhijith Nair <abhijithnair@google.com>
Date: Wed Mar 01 18:49:22 2023

Rename the WebView manifest key name

Rename STARTUP_FEATURE_SET_DIRECTORY_BASE_PATH:DEV
to STARTUP_FEATURE_SET_DIRECTORY_BASE_PATH

Change-Id: I33a366dd64b1a63a6b39a9122749009cae37fde9
Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
Bug: 250553687

M webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java

https://android-review.googlesource.com/2464551

ab...@google.com <ab...@google.com> Mar 1, 2023 09:38PM

Marked as fixed.

na...@google.com <na...@google.com> #11Mar 8, 2023 07:51PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.webkit:webkit:1.7.0-alpha03