Status Update
Comments
za...@capitalone.com <za...@capitalone.com> #2
za...@capitalone.com <za...@capitalone.com> #3
sg...@google.com <sg...@google.com> #4
sg...@google.com <sg...@google.com> #5
my...@gmail.com <my...@gmail.com> #6
Android Studio version: 0.8.12
buildToolsVersion 21.0.1
Gradle 1.11
my...@gmail.com <my...@gmail.com> #7
--set-max-idx-number=<value>
Unfortunately changing the default is not a solution since the linearAlloc limit can be reached at very different levels depending on the classes hierarchy and other criteria.
In addition for most applications, moving to multidex will only help to workaround the linearalloc limit for the installation. But the application will still crash against the same limit at execution. The only working use case where I know multidex can help with linearalloc is when the apk does not contains one application but distinct pieces running in separate process.
sg...@google.com <sg...@google.com> #8
It's nice to know about that command line option. I do not see it in the output of 'dx --help', might be good to add that.
I'm not very familiar with the 'linearAlloc limit' issue outside of the context of the dexopt step. My sample app is able to run once the lower idx value is set, although I do not actually call into any of the library code that is bundled with the app. I assume it's undefined when/if the 'linearAlloc limit' will be hit in a large application on gb.
I'm a bit confused as to the platform compatibility of multidex given the 'linearAlloc limit' bug. What specific versions of Android are supported? The multidex code implies back to v4 (
sg...@google.com <sg...@google.com> #9
The linearalloc limit is reached when loading classes. At install time dexopt is loading all classes contained in the dex so it's facing the limit immediately. At execution the limit may be reached after some delay dependending of the usage you have of the packaged classes. If you face it at install time but not at execution, this means you never trigger the loading of some classes. In a real application those never loaded classes should have been shrinked away manually or by Proguard. The exception is when there are different groups of classes in the dex files used in separate process.
About multidex library supported versions I've merged recently a change to try to be clearer
The summary is that the library should work down to API 4 (Donut), but below ICS applications will probably be hit by the linearalloc limit
mk...@google.com <mk...@google.com> #10
dexOptions {
additionalParameters = ['--multi-dex', '--set-max-idx-number=40000']
}
ap...@google.com <ap...@google.com> #11
ap...@google.com <ap...@google.com> #14
Branch: 4.0
commit 9ea64a43dfec183bef36e046578b978d161b213b
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Dec 20 09:00:59 2022
Account for dynamic null receiver type in argument propagation
Bug:
Change-Id: I4d29c793951f11189ae7954380d72a3b056027f3
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorCodeScanner.java
M src/test/java/com/android/tools/r8/optimize/argumentpropagation/PolymorphicMethodWithNullReceiverBoundTest.java
ap...@google.com <ap...@google.com> #15
Branch: 4.0
commit 721b3e6a29f7aae7a961016cdc5d8d1ca7befb1d
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Dec 20 09:00:47 2022
Add test for trying to compute method states for dynamic null receiver
Bug:
Change-Id: I7ca63f38483c1e953b42c8b1737974f5b6897039
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorCodeScanner.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
A src/test/java/com/android/tools/r8/optimize/argumentpropagation/PolymorphicMethodWithNullReceiverBoundTest.java
ap...@google.com <ap...@google.com> #16
Branch: 8.0
commit 250899ac04be1635c53a4f6b12d92e78df629aad
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Dec 20 09:11:38 2022
Version 8.0.24
Bug:
Change-Id: Ide57065903e8462ed01296ea2894146a92386ad0
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #17
Branch: 8.0
commit e9581ba99259fd7ca7c7e46c40e87abe10d32639
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Dec 20 09:11:28 2022
Account for dynamic null receiver type in argument propagation
Bug:
Change-Id: I4d29c793951f11189ae7954380d72a3b056027f3
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorCodeScanner.java
M src/test/java/com/android/tools/r8/optimize/argumentpropagation/PolymorphicMethodWithNullReceiverBoundTest.java
ap...@google.com <ap...@google.com> #18
Branch: 8.0
commit 412f08f108d722837f41fc33ea4e69226a45b031
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Dec 20 09:11:19 2022
Add test for trying to compute method states for dynamic null receiver
Bug:
Change-Id: I7ca63f38483c1e953b42c8b1737974f5b6897039
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorCodeScanner.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
A src/test/java/com/android/tools/r8/optimize/argumentpropagation/PolymorphicMethodWithNullReceiverBoundTest.java
my...@gmail.com <my...@gmail.com> #19
4.0.49 fixes at least my problem! Thanks!
ap...@google.com <ap...@google.com> #20
Branch: main
commit a0b5226d8b06317f51e6f94752b40dbe2b7ee328
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Dec 20 16:07:23 2022
Update null cyclic phis when rewriting always throwing instructions
Bug:
Change-Id: I3a26861b028c553e8bb5c66ae30f335d19bc40c4
M src/main/java/com/android/tools/r8/ir/analysis/type/DestructivePhiTypeUpdater.java
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
mk...@google.com <mk...@google.com> #21
Great to hear. For others seeing the same problem version 4.0.49 can be used by adding the following to the build.gradle file:
pluginManagement {
buildscript {
repositories {
mavenCentral()
maven {
url = uri("https://storage.googleapis.com/r8-releases/raw")
}
}
dependencies {
classpath("com.android.tools:r8:4.0.49")
}
}
}
my...@gmail.com <my...@gmail.com> #22
Would this land in 7.4.0 stable? It doesn't seem to have landed in rc03...
mk...@google.com <mk...@google.com> #23
This will not land in stable. The version on that branch is 4.0.48 at most, 4.0.49 has not been checked in.
dm...@izettle.com <dm...@izettle.com> #24
mk...@google.com <mk...@google.com> #25
Please ensure that you have setup the specific dependency on R8 to be version 4.0.51 and that you are not specifiying the version other places (such as buildSrc).
dm...@izettle.com <dm...@izettle.com> #26
Yes, my previous stacktrace was from 4.0.48. It was trickier to update than I thought. After really updating to 4.0.51 I started to get new trace
Caused by: java.lang.NullPointerException
at com.android.tools.r8.shaking.Enqueuer.markTypeAsLive(Enqueuer.java:2012)
at com.android.tools.r8.shaking.Enqueuer.traceTypeReference(Enqueuer.java:1388)
at com.android.tools.r8.shaking.DefaultEnqueuerUseRegistry.registerTypeReference(DefaultEnqueuerUseRegistry.java:174)
at com.android.tools.r8.cf.code.CfFrame.internalRegisterUse(CfFrame.java:273)
at com.android.tools.r8.cf.code.CfFrame.lambda$internalRegisterUse$1(CfFrame.java:264)
at com.android.tools.r8.cf.code.CfFrame.internalRegisterUse(CfFrame.java:264)
at com.android.tools.r8.cf.code.CfInstruction.registerUse(CfInstruction.java:104)
at com.android.tools.r8.graph.CfCode.registerCodeReferences(CfCode.java:683)
at com.android.tools.r8.graph.LazyCfCode.registerCodeReferences(LazyCfCode.java:284)
at com.android.tools.r8.graph.ProgramMethod.registerCodeReferences(ProgramMethod.java:127)
at com.android.tools.r8.shaking.Enqueuer.traceCode(Enqueuer.java:4809)
at com.android.tools.r8.shaking.Enqueuer.traceNonDesugaredCode(Enqueuer.java:4803)
at com.android.tools.r8.shaking.Enqueuer.markMethodAsLive(Enqueuer.java:4742)
at com.android.tools.r8.shaking.EnqueuerWorklist$MarkMethodLiveAction.run(EnqueuerWorklist.java:166)
at com.android.tools.r8.shaking.Enqueuer.trace(Enqueuer.java:4395)
at com.android.tools.r8.shaking.Enqueuer.traceApplication(Enqueuer.java:3622)
at com.android.tools.r8.R8.runEnqueuer(R8.java:1012)
at com.android.tools.r8.R8.run(R8.java:369)
at com.android.tools.r8.R8.run(R8.java:252)
at com.android.tools.r8.R8.lambda$runForTesting$1(R8.java:243)
at com.android.tools.r8.utils.ExceptionUtils.withCompilationHandler(ExceptionUtils.java:80)
... 35 more
R8 is a new Android code shrinker. If you experience any issues, please file a bug at
https://issuetracker.google.com, using 'Shrinker (R8)' as component name.
Current version is: 4.0.51 (build 41681a871b6a304b5c57388bf833ab1417e17ca9 from go/r8bot (luci-r8-custom-ci-bionic-22-vlxz)).
mk...@google.com <mk...@google.com>
dm...@izettle.com <dm...@izettle.com> #27
FYI. Downgrading R8 to 3.3.75 solved the issue.
dm...@izettle.com <dm...@izettle.com> #29
I don't think I can share a dump, it will be against company policy, sorry.
mk...@google.com <mk...@google.com> #30
Can you try to run with assertions enabled then?
./gradlew assembleRelease -Dorg.gradle.jvmargs='-ea:com.android.tools.r8'
or set the jvmargs in the gradle properties. Hopefully we will see where the error first appear then.
dm...@izettle.com <dm...@izettle.com> #31
I did this and I got these messages. There were more lines like that, I removed project-specific ones for security reasons. Is this what you was looking for?
Unable to find common super type for androidx/window/extensions/embedding/SplitPlaceholderRule and androidx/window/extensions/embedding/ActivityRule.
Unable to find common super type for androidx/window/extensions/embedding/SplitPairRule and java/lang/Object.
Unable to find common super type for com/google/common/util/concurrent/ListenableFuture and java/util/ArrayList.
Unable to find common super type for kotlin/Pair and java/lang/Object.
Unable to find common super type for okhttp3/Response and java/lang/Object.
Unable to find common super type for okhttp3/OkHttpClient and java/lang/Object.
Unable to find common super type for java/lang/Object and kotlin/Pair.
Unable to find common super type for java/lang/Exception and com/google/android/gms/tasks/Task.
Unable to find common super type for kotlinx/coroutines/CoroutineScope and java/lang/Object.
Unable to find common super type for java/lang/Object and kotlinx/coroutines/CoroutineScope.
Unable to find common super type for java/lang/NoClassDefFoundError and [REDACTED].
Current version is: 4.0.51 (build 41681a871b6a304b5c57388bf833ab1417e17ca9 from go/r8bot (luci-r8-custom-ci-bionic-22-vlxz)).
mk...@google.com <mk...@google.com> #32
No, that is not what I was looking for I am looking for a stack trace that is not the NPE. Running with assertions enabled should give a better indication of the origin of the error. The problem is that an object is constructed with a field that is null
. That is the NPE you are seeing. Internally we have an assert that such an object cannot be created so running with assertions would move the exception to creation time.
Potentially the argument should be:
-ea:com.android.tools.r8...
You should be able to specify it both by the command line and the gradle.properties file.
Please also run with --no-daemon
to ensure it will create a fresh VM.
dm...@izettle.com <dm...@izettle.com> #33
I did ./gradlew assembleRelease -Dorg.gradle.jvmargs='-ea:com.android.tools.r8' --no-daemon --stacktrace
and got the same stacktrace as initially, the one with NPE.
mk...@google.com <mk...@google.com> #34
Did you try:
./gradlew assembleRelease -Dorg.gradle.jvmargs='-ea:com.android.tools.r8...' --no-daemon --stacktrace
(notice the dots in the end of r8.)
dm...@izettle.com <dm...@izettle.com> #35
I've tried with dots and got new callstack :)
Caused by: java.lang.NullPointerException
at com.android.tools.r8.cf.code.frame.UninitializedNew.<init>(UninitializedNew.java:22)
at com.android.tools.r8.cf.code.frame.FrameType.uninitializedNew(FrameType.java:135)
at com.android.tools.r8.graph.LazyCfCode$MethodCodeVisitor.getFrameType(LazyCfCode.java:542)
at com.android.tools.r8.graph.LazyCfCode$MethodCodeVisitor.parseStack(LazyCfCode.java:521)
at com.android.tools.r8.graph.LazyCfCode$MethodCodeVisitor.visitFrame(LazyCfCode.java:501)
at com.android.tools.r8.org.objectweb.asm.ClassReader.readCode(ClassReader.java:2068)
at com.android.tools.r8.org.objectweb.asm.ClassReader.readMethod(ClassReader.java:1514)
at com.android.tools.r8.org.objectweb.asm.ClassReader.accept(ClassReader.java:744)
at com.android.tools.r8.org.objectweb.asm.ClassReader.accept(ClassReader.java:424)
at com.android.tools.r8.graph.LazyCfCode.parseCode(LazyCfCode.java:205)
at com.android.tools.r8.graph.LazyCfCode.internalParseCode(LazyCfCode.java:161)
at com.android.tools.r8.utils.ExceptionUtils.lambda$withOriginAndPositionAttachmentHandler$5(ExceptionUtils.java:238)
at com.android.tools.r8.utils.ExceptionUtils.withOriginAndPositionAttachmentHandler(ExceptionUtils.java:246)
at com.android.tools.r8.utils.ExceptionUtils.withOriginAndPositionAttachmentHandler(ExceptionUtils.java:234)
at com.android.tools.r8.utils.ExceptionUtils.withOriginAttachmentHandler(ExceptionUtils.java:225)
at com.android.tools.r8.graph.LazyCfCode.asCfCode(LazyCfCode.java:143)
at com.android.tools.r8.ir.desugar.NonEmptyCfInstructionDesugaringCollection.needsDesugaring(NonEmptyCfInstructionDesugaringCollection.java:349)
at com.android.tools.r8.shaking.Enqueuer.addToPendingDesugaring(Enqueuer.java:4004)
at com.android.tools.r8.shaking.Enqueuer.traceNonDesugaredCode(Enqueuer.java:4798)
at com.android.tools.r8.shaking.Enqueuer.markMethodAsLive(Enqueuer.java:4742)
at com.android.tools.r8.shaking.EnqueuerWorklist$MarkMethodLiveAction.run(EnqueuerWorklist.java:166)
at com.android.tools.r8.shaking.Enqueuer.trace(Enqueuer.java:4395)
at com.android.tools.r8.shaking.Enqueuer.traceApplication(Enqueuer.java:3622)
at com.android.tools.r8.R8.runEnqueuer(R8.java:1012)
at com.android.tools.r8.R8.run(R8.java:369)
at com.android.tools.r8.R8.run(R8.java:252)
at com.android.tools.r8.R8.lambda$runForTesting$1(R8.java:243)
at com.android.tools.r8.utils.ExceptionUtils.withCompilationHandler(ExceptionUtils.java:80)
... 35 more
Suppressed: com.android.tools.r8.utils.ExceptionUtils$OriginAttachmentException: java.lang.NullPointerException
at com.android.tools.r8.utils.ExceptionUtils$OriginAttachmentException.wrap(ExceptionUtils.java:258)
at com.android.tools.r8.utils.ExceptionUtils.withOriginAndPositionAttachmentHandler(ExceptionUtils.java:248)
at com.android.tools.r8.utils.ExceptionUtils.withOriginAndPositionAttachmentHandler(ExceptionUtils.java:234)
at com.android.tools.r8.utils.ExceptionUtils.withOriginAttachmentHandler(ExceptionUtils.java:225)
at com.android.tools.r8.graph.LazyCfCode.asCfCode(LazyCfCode.java:143)
at com.android.tools.r8.ir.desugar.NonEmptyCfInstructionDesugaringCollection.needsDesugaring(NonEmptyCfInstructionDesugaringCollection.java:349)
at com.android.tools.r8.shaking.Enqueuer.addToPendingDesugaring(Enqueuer.java:4004)
at com.android.tools.r8.shaking.Enqueuer.traceNonDesugaredCode(Enqueuer.java:4798)
at com.android.tools.r8.shaking.Enqueuer.markMethodAsLive(Enqueuer.java:4742)
at com.android.tools.r8.shaking.EnqueuerWorklist$MarkMethodLiveAction.run(EnqueuerWorklist.java:166)
at com.android.tools.r8.shaking.Enqueuer.trace(Enqueuer.java:4395)
at com.android.tools.r8.shaking.Enqueuer.traceApplication(Enqueuer.java:3622)
at com.android.tools.r8.R8.runEnqueuer(R8.java:1012)
at com.android.tools.r8.R8.run(R8.java:369)
at com.android.tools.r8.R8.run(R8.java:252)
at com.android.tools.r8.R8.lambda$runForTesting$1(R8.java:243)
at com.android.tools.r8.utils.ExceptionUtils.withCompilationHandler(ExceptionUtils.java:80)
at com.android.tools.r8.utils.ExceptionUtils.withR8CompilationHandler(ExceptionUtils.java:69)
at com.android.tools.r8.R8.runForTesting(R8.java:239)
at com.android.tools.r8.R8.run(R8.java:187)
at com.android.builder.dexing.R8Tool.runR8(r8Tool.kt:308)
at com.android.build.gradle.internal.tasks.R8Task$Companion.shrink(R8Task.kt:642)
at com.android.build.gradle.internal.tasks.R8Task$R8Runnable.execute(R8Task.kt:712)
at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:63)
at org.gradle.workers.internal.NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:66)
at org.gradle.workers.internal.NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:62)
at org.gradle.internal.classloader.ClassLoaderUtils.executeInClassloader(ClassLoaderUtils.java:100)
at org.gradle.workers.internal.NoIsolationWorkerFactory$1.lambda$execute$0(NoIsolationWorkerFactory.java:62)
at org.gradle.workers.internal.AbstractWorker$1.call(AbstractWorker.java:44)
at org.gradle.workers.internal.AbstractWorker$1.call(AbstractWorker.java:41)
at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
at org.gradle.workers.internal.AbstractWorker.executeWrappedInBuildOperation(AbstractWorker.java:41)
at org.gradle.workers.internal.NoIsolationWorkerFactory$1.execute(NoIsolationWorkerFactory.java:59)
at org.gradle.workers.internal.DefaultWorkerExecutor.lambda$submitWork$2(DefaultWorkerExecutor.java:212)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.runExecution(DefaultConditionalExecutionQueue.java:187)
at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.access$700(DefaultConditionalExecutionQueue.java:120)
at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner$1.run(DefaultConditionalExecutionQueue.java:162)
at org.gradle.internal.Factories$1.create(Factories.java:31)
at org.gradle.internal.work.DefaultWorkerLeaseService.withLocks(DefaultWorkerLeaseService.java:249)
at org.gradle.internal.work.DefaultWorkerLeaseService.runAsWorkerThread(DefaultWorkerLeaseService.java:109)
at org.gradle.internal.work.DefaultWorkerLeaseService.runAsWorkerThread(DefaultWorkerLeaseService.java:114)
at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.runBatch(DefaultConditionalExecutionQueue.java:157)
at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.run(DefaultConditionalExecutionQueue.java:126)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:49)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: [CIRCULAR REFERENCE: java.lang.NullPointerException]
ap...@google.com <ap...@google.com> #36
Branch: main
commit d3be3e93b26b4797fcfa4b071da30e5184ac27b5
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Thu Feb 02 10:38:36 2023
Throw compilation error with origin when failing to parse code
Bug:
Change-Id: I358dc5d95aacfe448ec9d1e2d5e5d5deb4921631
M src/main/java/com/android/tools/r8/graph/LazyCfCode.java
mk...@google.com <mk...@google.com> #37
I've created a new CL ToT that will show the origin of the class-file we cannot parse. Hopefully you can share that library/file with us. To use the new version, you have amend your build.gradle file:
pluginManagement {
buildscript {
repositories {
mavenCentral()
maven {
url = uri("https://storage.googleapis.com/r8-releases/raw/main")
}
}
dependencies {
classpath("com.android.tools:r8:d3be3e93b26b4797fcfa4b071da30e5184ac27b5")
classpath('com.google.guava:guava:30.1.1-jre') // <-- THIS IS REQUIRED UNTIL R8 3.2.4-dev
}
}
}
(Note that the maven repository is different)
Then run the .gradlew command again.
mk...@google.com <mk...@google.com> #38
I will close this bug waiting for answer since it marked as P1 and cannot change it since we backported an issue. Please open a new bug when you have the source files that we cannot parse.
Description
Getting the following exception when executing
:app:minifyVariantWithR8
when upgrading to7.4.0-beta02
. This worked without issues with AGP7.3.0
.