Status Update
Comments
ak...@google.com <ak...@google.com> #2
Thanks for filing the bug!
Do you also see the issue with finishPrimaryWithSecondary
functionality in the stable version of 1.0.0?
Have you considered using 1.1.0-alpha01
in your application, or do you have any reasons preventing you from doing so?
ki...@linecorp.com <ki...@linecorp.com> #3
// Do you also see the issue with finishPrimaryWithSecondary functionality in the stable version of 1.0.0?
- Yes. We have issue in the stable version of 1.0.0. Our app has SplashActivity. and SplashActivity start MainActivity. And then split the MainActivity and DetailActivity using ActivityEmbedding to reproduce the bug.
//Have you considered using 1.1.0-alpha01 in your application, or do you have any reasons preventing you from doing so?
- If we could know a release plan for a stable version, we tried to work on that schedule.
ak...@google.com <ak...@google.com> #4
Thank you for sharing.
From my perspective, 1.1.0-alpha01
has minimal amount of changes over 1.0.0
and is expected to have the same level of stability. It should also have full compatibility with implementations of ActivityEmbedding in Android 12L and 13.
The future alpha and stable releases of 1.1.0
will primarily be focused on additions rather than changes to the current functionality. It's currently an active work in progress. Unfortunately, there are no specific date that I'm ready to share at the moment.
ak...@google.com <ak...@google.com> #5
An An, do you know why finishPrimaryWithSecondary
is not behaving as expected in 1.0.0
?
ki...@linecorp.com <ki...@linecorp.com> #6
// there are no specific date that I'm ready to share at the moment.
- Thank you. No Problem. Let me know when the release date comes later
// do you know why finishPrimaryWithSecondary is not behaving as expected in 1.0.0?
- I'll organize the bugs and post them on this thread.
ki...@linecorp.com <ki...@linecorp.com> #7
Our team is wary of possible bugs in SplitPairRule. Because the workaround for this bug is to remove SplitPairRule. If you remove the SplitPairRule and only the PlaceHolderActivity remains, the bug is no longer reproduced.
main_split_configuration.xml
<?xml version="1.0" encoding="utf-8"?>
<resources xmlns:window="http://schemas.android.com/apk/res-auto">
<SplitPairRule
window:splitRatio="0.5"
window:finishSecondaryWithPrimary="true"
window:finishPrimaryWithSecondary="true"
window:splitMinSmallestWidth="600dp">
<SplitPairFilter
window:primaryActivityName=".MainActivity"
window:secondaryActivityName=".SecondaryActivity" />
</SplitPairRule>
<SplitPlaceholderRule
window:placeholderActivityName=".PlaceHolderActivity"
window:splitRatio="0.5"
window:splitMinWidth="600dp">
<ActivityFilter
window:activityName=".MainActivity"/>
</SplitPlaceholderRule>
</resources>
Reproduction step
- Start the app (Start SplashActivity)
- Start MainActivity from SplashActivity
- Split MainActivity and PlaceHolderActivity
- Start SecondaryActivity
- Split MainActivity and SecondaryActivity
- Touch MainActivity.
- Give focus to MainActivity
- Press the Back key.
- Split is released and only SecondaryActivity remains.
I attached reproduction video file and sample project. First scene is giving focus to MainActivity. Second scene is giving focus to SecondaryActivity.
ak...@google.com <ak...@google.com> #8
Thank you for the details!
Description
Component used: window(ActivityEmbedding) Version used:1.0.0 Devices/Android versions reproduced on: Galaxy fold3/4 Android 12L
hello.
Found a new bug with ActivityEmbedding.
If we use the window version from the development guide, the
finishPrimaryWithSecondary
option does not work properly.androidx.window:window:1.0.0-beta03
You can find out more about the bug by searching for "Potential bug" in the blog below.https://proandroiddev.com/activity-embedding-in-android-b07da14b715
However, we confirmed that this bug was fixed in 1.1.0-alpha01.https://developer.android.com/jetpack/androidx/releases/window#1.1.0-alpha01
Is there any other workaround that can be solved in the current version (1.0.0)?
So, when are you planning to release a stable version with this fix?