Status Update
No update yet.
Comments
jn...@google.com
Good catch!
Possibly relevant
jn...@google.com
Curious, is it intended that TimeText could have an interact-able composable? Like a Network symbol in leadingCurvedContent that shows network information when clicked?
jn...@google.com
In the last patch (going out as alpha19) we removed that, since CurvedText is not a compose-ui node anymore, but we will look into adding it back again (with better bounds).
pe...@google.com
Branch: androidx-main
commit 29737ba91ffe21e7b3132693094b5484c5cecbe1
Author: Sergio Sancho <ssancho@google.com>
Date: Mon Oct 03 14:18:01 2022
Create compose-ui nodes for curved text elements.
For each curvedText/basicCurvedText we create a compose-ui node that has
as content description the text of the (basic)curved text, and we size
and place it appropiatelly. This enables talkback to work properly with
curved text elements.
Minor change to the internal API for CurvedChild.initializeMeasure
Test: Manual, with and withouth talkback. + ./gradlew :wear:compose:compose-foundation:connectedCheck
Relnote: "curveText and basicCurvedText will now have a properly sized
and placed (but empty) compose-ui node associated with them, using the text as
content description, to properly work with talkback"
Bug: 210721259
Change-Id: I7af7ced923180839eee782fe2e45a1976c7e8ab4
M wear/compose/compose-foundation/samples/src/main/java/androidx/wear/compose/foundation/samples/CurvedWorldSample.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedLayout.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedContainer.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedSize.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/BasicCurvedText.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedPadding.kt
M wear/compose/compose-foundation/src/androidAndroidTest/kotlin/androidx/wear/compose/foundation/SpyModifier.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedComposable.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/FoundationDemos.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedModifier.kt
st...@google.com
The following release(s) address this bug:
androidx.wear.compose:compose-foundation:1.1.0-beta01
st...@google.com
Note that if we change ListHeader to use Modifier.defaultMinSize(minHeight = 48.dp).height(IntrinsicSize.Min), then according to my testing, that allows developers to override the height in their own code, which is what the chat in comment 6 was originally about.
st...@google.com
FWIW I notice that we have already made exactly this change in our Material3 codebase following a UX code review (see aosp/2715054)
st...@google.com
@vincenttam Please will you confirm if we should make this change to expand the ListHeader to accommodate contents in Material 2.5 - thanks.
vi...@google.com
Yes, confirming from UX that we should update to ensure the ListHeader can accommodate contents for up to 3 lines of text (and behaviour is to push the content below further down as a result)
We made this update on SysUI for accessibility reasons, as Steve has noted in
st...@google.com
ap...@google.com
Branch: androidx-main
commit 150d8bdb16a8d55375780e8092c9fd8aae4ea5aa
Author: stevebower <stevebower@google.com>
Date: Mon Jan 29 17:43:27 2024
Update ListHeader so that its height adjusts to accommodate its contents when large font sizes are used.
Test: Added multi-line example to integration demos for testing
Bug: 251166127
Relnote: "We have updated the ListHeader to support height adjustments when contents need extra height to accommodate large font sizes."
Change-Id: I7290ce63e80f480bf67da630013b875aa0005ee2
M wear/compose/compose-material/src/main/java/androidx/wear/compose/material/ListHeader.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/MaterialDemos.kt
Description
After discussing Figma designs with UX, I got the following:
They are referring to the height defined in:https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:wear/compose/compose-material/src/main/java/androidx/wear/compose/material/ListHeader.kt;l=53?q=ListHeader
So I believe there should be code changes to not have the height hardcoded?
Full discussion:https://www.figma.com/file/G6QEiBHkZ9TeKyBNUybJao?node-id=50:20539#279549982
Component used: ListHeader
Version used: 1.0.0
Devices/Android versions reproduced on: N/A