Status Update
Comments
jn...@google.com <jn...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
jn...@google.com <jn...@google.com> #3
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
pe...@google.com <pe...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
st...@google.com <st...@google.com> #6
Following this
- Before with ListHeader using
Modifier.height(48.dp)
- only room for 2 lines:https://screenshot.googleplex.com/5zi9RqeAwoTQaPK - After with ListHeader using
defaultMinSize(minHeight = 48.dp).height(IntrinsicSize.Min)
- expands to 3 lines:https://screenshot.googleplex.com/9L43x8dcqTtJ6VZ
st...@google.com <st...@google.com> #7
Note that if we change ListHeader to use Modifier.defaultMinSize(minHeight = 48.dp).height(IntrinsicSize.Min)
, then according to my testing, that allows developers to override the height in their own code, which is what the chat in comment 6 was originally about.
st...@google.com <st...@google.com> #8
FWIW I notice that we have already made exactly this change in our Material3 codebase following a UX code review (see aosp/2715054)
st...@google.com <st...@google.com> #9
@vincenttam Please will you confirm if we should make this change to expand the ListHeader to accommodate contents in Material 2.5 - thanks.
vi...@google.com <vi...@google.com> #10
Yes, confirming from UX that we should update to ensure the ListHeader can accommodate contents for up to 3 lines of text (and behaviour is to push the content below further down as a result)
We made this update on SysUI for accessibility reasons, as Steve has noted in
st...@google.com <st...@google.com>
ap...@google.com <ap...@google.com> #11
Branch: androidx-main
commit 150d8bdb16a8d55375780e8092c9fd8aae4ea5aa
Author: stevebower <stevebower@google.com>
Date: Mon Jan 29 17:43:27 2024
Update ListHeader so that its height adjusts to accommodate its contents when large font sizes are used.
Test: Added multi-line example to integration demos for testing
Bug: 251166127
Relnote: "We have updated the ListHeader to support height adjustments when contents need extra height to accommodate large font sizes."
Change-Id: I7290ce63e80f480bf67da630013b875aa0005ee2
M wear/compose/compose-material/src/main/java/androidx/wear/compose/material/ListHeader.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/MaterialDemos.kt
Description
After discussing Figma designs with UX, I got the following:
They are referring to the height defined in:https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:wear/compose/compose-material/src/main/java/androidx/wear/compose/material/ListHeader.kt;l=53?q=ListHeader
So I believe there should be code changes to not have the height hardcoded?
Full discussion:https://www.figma.com/file/G6QEiBHkZ9TeKyBNUybJao?node-id=50:20539#279549982
Component used: ListHeader
Version used: 1.0.0
Devices/Android versions reproduced on: N/A