Status Update
Comments
jn...@google.com <jn...@google.com> #2
BTW, the source code for this is fairly straightforward. I just added the source into the sample for now, but it would be nicer if we had the function.
From source:
/**
* Gets the current navigation back stack entry as a [MutableState]. When the given navController
* changes the back stack due to a [NavController.navigate] or [NavController.popBackStack] this
* will trigger a recompose and return the top entry on the back stack.
*
* @return a mutable state of the current back stack entry
*/
@Composable
public fun NavController.currentBackStackEntryAsState(): State<NavBackStackEntry?> {
return currentBackStackEntryFlow.collectAsState(null)
}
jn...@google.com <jn...@google.com> #3
jn...@google.com <jn...@google.com> #4
Branch: androidx-main
commit 804463f3f416212296133fe53e30b5d5cbc2fba9
Author: stevebower <stevebower@google.com>
Date: Wed Jan 05 15:04:02 2022
Add currentBackStackEntryAsState to Wear Compose Navigation.
Test: Run tests for wear.compose.navigation.
Bug: 212739653
Relnote: "We have added NavController.currentBackStackEntryAsState()
to the Wear.Compose.Navigation library."
Change-Id: If90286c7debe623df926a091f15766abf04f2ecc
M wear/compose/compose-navigation/api/restricted_current.txt
M wear/compose/compose-navigation/api/current.txt
M wear/compose/compose-navigation/src/androidTest/kotlin/androidx/wear/compose/navigation/SwipeDismissableNavHostTest.kt
M wear/compose/compose-navigation/api/public_plus_experimental_current.txt
M wear/compose/compose-navigation/src/main/java/androidx/wear/compose/navigation/SwipeDismissableNavHostController.kt
pe...@google.com <pe...@google.com> #5
Hi Steve, which version of the library will this be released in?
st...@google.com <st...@google.com> #6
Never mind, it's in alpha15, missed that. Thanks!
st...@google.com <st...@google.com> #7
Note that if we change ListHeader to use Modifier.defaultMinSize(minHeight = 48.dp).height(IntrinsicSize.Min)
, then according to my testing, that allows developers to override the height in their own code, which is what the chat in comment 6 was originally about.
st...@google.com <st...@google.com> #8
FWIW I notice that we have already made exactly this change in our Material3 codebase following a UX code review (see aosp/2715054)
st...@google.com <st...@google.com> #9
@vincenttam Please will you confirm if we should make this change to expand the ListHeader to accommodate contents in Material 2.5 - thanks.
vi...@google.com <vi...@google.com> #10
Yes, confirming from UX that we should update to ensure the ListHeader can accommodate contents for up to 3 lines of text (and behaviour is to push the content below further down as a result)
We made this update on SysUI for accessibility reasons, as Steve has noted in
st...@google.com <st...@google.com>
ap...@google.com <ap...@google.com> #11
Branch: androidx-main
commit 150d8bdb16a8d55375780e8092c9fd8aae4ea5aa
Author: stevebower <stevebower@google.com>
Date: Mon Jan 29 17:43:27 2024
Update ListHeader so that its height adjusts to accommodate its contents when large font sizes are used.
Test: Added multi-line example to integration demos for testing
Bug: 251166127
Relnote: "We have updated the ListHeader to support height adjustments when contents need extra height to accommodate large font sizes."
Change-Id: I7290ce63e80f480bf67da630013b875aa0005ee2
M wear/compose/compose-material/src/main/java/androidx/wear/compose/material/ListHeader.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/MaterialDemos.kt
Description
After discussing Figma designs with UX, I got the following:
They are referring to the height defined in:https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:wear/compose/compose-material/src/main/java/androidx/wear/compose/material/ListHeader.kt;l=53?q=ListHeader
So I believe there should be code changes to not have the height hardcoded?
Full discussion:https://www.figma.com/file/G6QEiBHkZ9TeKyBNUybJao?node-id=50:20539#279549982
Component used: ListHeader
Version used: 1.0.0
Devices/Android versions reproduced on: N/A