Obsolete 48dp height in ListHeader [251166127]

Fixed

Bug

Status Update

No update yet.

Description

gu...@google.com

created issue #1

Oct 5, 2022 03:19PM

After discussing Figma designs with UX, I got the following:

The 48DP fixed height header is now obsolete as SysUI allows for 3 lines and just pushes the content down

They are referring to the height defined in: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:wear/compose/compose-material/src/main/java/androidx/wear/compose/material/ListHeader.kt;l=53?q=ListHeader

So I believe there should be code changes to not have the height hardcoded?

Full discussion: https://www.figma.com/file/G6QEiBHkZ9TeKyBNUybJao?node-id=50:20539#279549982

Component used: ListHeader

Version used: 1.0.0

Devices/Android versions reproduced on: N/A

Comments

jn...@google.com <jn...@google.com> #2Oct 6, 2022 09:00AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

jn...@google.com <jn...@google.com> #3Oct 17, 2022 05:10PM

Assigned to ma...@google.com.

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

jn...@google.com <jn...@google.com> #4Nov 7, 2022 10:26AM

Reassigned to vi...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

pe...@google.com <pe...@google.com> #5Dec 19, 2023 11:48AM

These tickets were part of Compose UX backlog hotlist

Adding these to wear_ux_sprint_inbox so they can be reassessed and verify if UX action is needed or if obsolete

st...@google.com <st...@google.com> #6Jan 25, 2024 04:54PM

Following this https://chat.google.com/room/AAAAYRnp4-Y/8xkRlG-EsbE in Compose Friends, this ticket should be treated as an accessibility issue if UX confirm that ListHeader should show up to 3 lines of text. Currently, that would fail to expand to show 3 lines for the largest font size (please ignore the clipping at the top as that's just a result of the demo app being used for testing):

Before with ListHeader using Modifier.height(48.dp) - only room for 2 lines: https://screenshot.googleplex.com/5zi9RqeAwoTQaPK
After with ListHeader using defaultMinSize(minHeight = 48.dp).height(IntrinsicSize.Min) - expands to 3 lines: https://screenshot.googleplex.com/9L43x8dcqTtJ6VZ

st...@google.com <st...@google.com> #7Jan 25, 2024 04:57PM

Note that if we change ListHeader to use Modifier.defaultMinSize(minHeight = 48.dp).height(IntrinsicSize.Min), then according to my testing, that allows developers to override the height in their own code, which is what the chat in comment 6 was originally about.

st...@google.com <st...@google.com> #8Jan 25, 2024 05:03PM

FWIW I notice that we have already made exactly this change in our Material3 codebase following a UX code review (see aosp/2715054)

st...@google.com <st...@google.com> #9Jan 26, 2024 10:16AM

@vincenttam Please will you confirm if we should make this change to expand the ListHeader to accommodate contents in Material 2.5 - thanks.

vi...@google.com <vi...@google.com> #10Jan 26, 2024 08:05PM

Yes, confirming from UX that we should update to ensure the ListHeader can accommodate contents for up to 3 lines of text (and behaviour is to push the content below further down as a result)

We made this update on SysUI for accessibility reasons, as Steve has noted in comment#6, to ensure scalability for larger text sizes and also localized strings

st...@google.com <st...@google.com> Jan 29, 2024 10:04AM

Reassigned to st...@google.com.

ap...@google.com <ap...@google.com> #11Jan 30, 2024 11:41AM

Project: platform/frameworks/support
Branch: androidx-main

commit 150d8bdb16a8d55375780e8092c9fd8aae4ea5aa
Author: stevebower <stevebower@google.com>
Date: Mon Jan 29 17:43:27 2024

Update ListHeader so that its height adjusts to accommodate its contents when large font sizes are used.

Test: Added multi-line example to integration demos for testing
Bug: 251166127
Relnote: "We have updated the ListHeader to support height adjustments when contents need extra height to accommodate large font sizes."
Change-Id: I7290ce63e80f480bf67da630013b875aa0005ee2

M wear/compose/compose-material/src/main/java/androidx/wear/compose/material/ListHeader.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/MaterialDemos.kt

https://android-review.googlesource.com/2933031

st...@google.com <st...@google.com> Feb 1, 2024 12:02PM

Marked as fixed.