Status Update
No update yet.
Comments
jn...@google.com
Given this is a UX specification change that is a breaking UX change for existing users we will need to decide whether this goes into 1.X or has to wait for 2.0 (no plans for 2.0 at this stage).
We could update samples and/or add an overload that continues to provide the existing behaviour and makes it easy to change to the new behaviour.
jn...@google.com
Marc could we have someone from UX take a look at this request so we can look at updates to the UX Spec and then we can work out how/when to release.
jn...@google.com
Should we be looking to change this as part of the WM3? Do we need to change either the WM2 spec/guidance or existing code?
pe...@google.com
Adding these to wear_ux_sprint_inbox so they can be reassessed and verify if UX action is needed or if obsolete
st...@google.com
Following this
- Before with ListHeader using
Modifier.height(48.dp)- only room for 2 lines:https://screenshot.googleplex.com/5zi9RqeAwoTQaPK - After with ListHeader using
defaultMinSize(minHeight = 48.dp).height(IntrinsicSize.Min)- expands to 3 lines:https://screenshot.googleplex.com/9L43x8dcqTtJ6VZ
st...@google.com
Note that if we change ListHeader to use Modifier.defaultMinSize(minHeight = 48.dp).height(IntrinsicSize.Min), then according to my testing, that allows developers to override the height in their own code, which is what the chat in comment 6 was originally about.
st...@google.com
FWIW I notice that we have already made exactly this change in our Material3 codebase following a UX code review (see aosp/2715054)
st...@google.com
@vincenttam Please will you confirm if we should make this change to expand the ListHeader to accommodate contents in Material 2.5 - thanks.
vi...@google.com
Yes, confirming from UX that we should update to ensure the ListHeader can accommodate contents for up to 3 lines of text (and behaviour is to push the content below further down as a result)
We made this update on SysUI for accessibility reasons, as Steve has noted in
st...@google.com
ap...@google.com
Branch: androidx-main
commit 150d8bdb16a8d55375780e8092c9fd8aae4ea5aa
Author: stevebower <stevebower@google.com>
Date: Mon Jan 29 17:43:27 2024
Update ListHeader so that its height adjusts to accommodate its contents when large font sizes are used.
Test: Added multi-line example to integration demos for testing
Bug: 251166127
Relnote: "We have updated the ListHeader to support height adjustments when contents need extra height to accommodate large font sizes."
Change-Id: I7290ce63e80f480bf67da630013b875aa0005ee2
M wear/compose/compose-material/src/main/java/androidx/wear/compose/material/ListHeader.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/MaterialDemos.kt
Description
After discussing Figma designs with UX, I got the following:
They are referring to the height defined in:https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:wear/compose/compose-material/src/main/java/androidx/wear/compose/material/ListHeader.kt;l=53?q=ListHeader
So I believe there should be code changes to not have the height hardcoded?
Full discussion:https://www.figma.com/file/G6QEiBHkZ9TeKyBNUybJao?node-id=50:20539#279549982
Component used: ListHeader
Version used: 1.0.0
Devices/Android versions reproduced on: N/A