Updated LazyPagingItems in LazyVerticalGrid throws IllegalArgumentException when using keys in 1.3.0-rc01 but not in beta03 [253195989]

Fixed

Bug

Status Update

No update yet.

Description

se...@candybytes.com

created issue #1

Oct 12, 2022 10:51AM

Jetpack Compose component(s) used: androidxCompose = "1.3.0-rc01" androidxComposeCompiler = "1.3.2" androidxComposeMaterial3 = "1.0.0-alpha13" androidxComposeMaterial = "1.2.1"

Android Studio Build: Build #AI-222.4167.29.2221.9133400, built on October 4, 2022

Kotlin version: kotlin = "1.7.20"

Steps to Reproduce or Code Sample to Reproduce:

I struggle with a "Key" problem since I updated from androidx.compose "1.3.0-beta03" to "1.3.0-rc01".

I use LazyPagingItems for a LazyVerticalGrid and i add items like this in the LazyGridScope:

fun LazyGridScope.itemFeed(pagingData: Flow<PagingData<DangerItem>>){
val feedData = pagingData.collectAsLazyPagingItems()
items(feedData.itemCount,
        // to maximize the performance add a unique key
        // as fallback use index of element
        key = { index ->
            feedData[index]?.code ?: index
        },
        contentType = { idx ->
            if (feedData[idx] != null) 1 else 0
        }
    )

But since the library update, when I filter the content (so the paging items are updated in the flow), it throws an Exception. This exception wasn't thrown in the beta03 library version.

Because paging data is changing and elements become null while loading I can't supply a unique key, the App crashes. Is this a bug in the library or what exactly is the best practice when using LazyPagingItems that can change over time if you'd like to work with keys in the LazyGrid?

Stack trace (if applicable):

java.lang.IllegalArgumentException: Failed requirement. 
at androidx.compose.foundation.lazy.grid.LazyGridSpanLayoutProvider.getLineIndexOfItem--_Ze7BM(LazyGridSpanLayoutProvider.kt:174) 
at androidx.compose.foundation.lazy.grid.LazyGridItemPlacementAnimatorKt.lastIndexInPreviousLineBefore(LazyGridItemPlacementAnimator.kt:489)
at androidx.compose.foundation.lazy.grid.LazyGridItemPlacementAnimatorKt.access$lastIndexInPreviousLineBefore(LazyGridItemPlacementAnimator.kt:1)

device-2022-10-12-123708.webm

3.6 MB

Download

device-2022-10-12-123708.gif

317 KB

View

Download

log_exception.txt

17 KB

View

Download

Comments

se...@candybytes.com <se...@candybytes.com> #2Oct 12, 2022 12:05PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

an...@google.com <an...@google.com> Oct 12, 2022 02:23PM

Reassigned to an...@google.com.

an...@google.com <an...@google.com> #3Oct 12, 2022 05:16PM

It is a bug in how Modifier.animatedItemPlacement() works for lazy grids in 1.3.0-rc01.
It happens when the item which is visible after the items list change and was not visible before and had an index which is larger than the new items list size.
Workaround is to not use Modifier.animatedItemPlacement() for now

ap...@google.com <ap...@google.com> #4Nov 4, 2022 02:06PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit c221d62c6aee00a180bf48e776f106396a377a47
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Mon Oct 31 17:39:06 2022

Fix for a crash when Modifier.animateItemPlacement() is set on a child of Lazy grids

It was happening when the item which is visible after the items list change and was not visible before and had an index which is larger than the new items list size.

Fixes: 253195989
Test: new tests in LazyGridAnimateItemPlacementTest
Relnote: The crash with Modifier.animateItemPlacement() and Lazy grids was fixed. It was happening in some conditions when the new items count is smaller then the previous one.
Change-Id: I0bcac889f7916ab032be277ba11fcfb723e56516

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyGridAnimateItemPlacementTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGridItemPlacementAnimator.kt

https://android-review.googlesource.com/2277813

na...@google.com <na...@google.com> #5Nov 9, 2022 06:28PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.3.1

mi...@gmail.com <mi...@gmail.com> #6Nov 14, 2022 02:49PM

Crash is still there for me on 1.4.0-alpha02

an...@google.com <an...@google.com> #7Nov 14, 2022 04:35PM

Yes, it will be released in the next alpha (but it was cherrypicked to 1.3.1 stable)

ju...@google.com <ju...@google.com> #8Dec 7, 2022 06:35PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.4.0-alpha03

Issue 253195989

Description

Issue summary

Comments

se...@candybytes.com <se...@candybytes.com> #2Oct 12, 2022 12:05PM

an...@google.com <an...@google.com> Oct 12, 2022 02:23PM

an...@google.com <an...@google.com> #3Oct 12, 2022 05:16PM

ap...@google.com <ap...@google.com> #4Nov 4, 2022 02:06PM

na...@google.com <na...@google.com> #5Nov 9, 2022 06:28PM

mi...@gmail.com <mi...@gmail.com> #6Nov 14, 2022 02:49PM

an...@google.com <an...@google.com> #7Nov 14, 2022 04:35PM

ju...@google.com <ju...@google.com> #8Dec 7, 2022 06:35PM

Add comment

Issue metadata