Lint accesses source sets information without dependencies [253219347]

Fixed

Bug

Status Update

No update yet.

Description

ga...@google.com

created issue #1

Oct 12, 2022 01:41PM

Lint access source set information in a way that does not capture dependency information. Androidx is hitting this with:

* What went wrong:
A problem was found with the configuration of task ':room:room-compiler-processing-testing:lintAnalyze' (type 'AndroidLintAnalysisTask').
  - Gradle detected a problem with the following location: '$OUT_DIR/androidx/room/room-compiler-processing-testing/build/test-config-copy'.
    
    Reason: Task ':room:room-compiler-processing-testing:lintAnalyze' uses this output of task ':room:room-compiler-processing-testing:copyTestConfiguration' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':room:room-compiler-processing-testing:copyTestConfiguration' as an input of ':room:room-compiler-processing-testing:lintAnalyze'.
      2. Declare an explicit dependency on ':room:room-compiler-processing-testing:copyTestConfiguration' from ':room:room-compiler-processing-testing:lintAnalyze' using Task#dependsOn.
      3. Declare an explicit dependency on ':room:room-compiler-processing-testing:copyTestConfiguration' from ':room:room-compiler-processing-testing:lintAnalyze' using Task#mustRunAfter.
    
    Please refer to https://docs.gradle.org/8.0-milestone-2/userguide/validation_problems.html#implicit_dependency for more details about this problem.

* Exception is:
org.gradle.internal.execution.WorkValidationException: A problem was found with the configuration of task ':room:room-compiler-processing-testing:lintAnalyze' (type 'AndroidLintAnalysisTask').
  - Gradle detected a problem with the following location: '$OUT_DIR/androidx/room/room-compiler-processing-testing/build/test-config-copy'.
    
    Reason: Task ':room:room-compiler-processing-testing:lintAnalyze' uses this output of task ':room:room-compiler-processing-testing:copyTestConfiguration' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':room:room-compiler-processing-testing:copyTestConfiguration' as an input of ':room:room-compiler-processing-testing:lintAnalyze'.
      2. Declare an explicit dependency on ':room:room-compiler-processing-testing:copyTestConfiguration' from ':room:room-compiler-processing-testing:lintAnalyze' using Task#dependsOn.
      3. Declare an explicit dependency on ':room:room-compiler-processing-testing:copyTestConfiguration' from ':room:room-compiler-processing-testing:lintAnalyze' using Task#mustRunAfter.
    
    Please refer to https://docs.gradle.org/8.0-milestone-2/userguide/validation_problems.html#implicit_dependency for more details about this problem.

BUILD FAILED in 25m 59s

The issue seems to be usage of non-provider based APIs here.

We should switch to SourceSet.getAllSource().getSourceDirectories().

Comments

sp...@google.com <sp...@google.com> #2Oct 14, 2022 07:39PM

Accepted by sp...@google.com.

Here is the stacktrace:

java.lang.VerifyError: Verifier rejected class WN: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent) failed to verify: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent): [0x4]  can't resolve returned type 'Reference: android.app.Notification$Style' or 'Unresolved Reference: android.app.Notification$CallStyle' (declaration of 'WN' appears in base.apk!classes4.dex)
	at Tj.<init>(SourceFile:17)
	at kT1.<init>(SourceFile:23)
	at aL1.<init>(SourceFile:293)
	at bh4.get(SourceFile:1606)
	at cL1.a(SourceFile:29)
	at cL1.e(SourceFile:17)
	at s1i.getValue(Unknown Source:17)
	at dL1.a(SourceFile:11)
	at RQ1.b(Unknown Source:2)
	at EQ1.execute(SourceFile:15)
	at lU1.handleMessage(SourceFile:18)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at N52.dispatchMessage(SourceFile:7)
	at android.os.Looper.loop(Looper.java:237)
	at android.os.HandlerThread.run(HandlerThread.java:67)

Unfortunately, I can't share the dex2oat logs for this as I'm running into this problem on Android 11 emulator and I don't have a rooted Android 11 device on-hand.

au...@google.com <au...@google.com> #3Oct 17, 2022 04:53PM

Thanks for the report. Can you share the APK failing and give suggestions to force the error such that I can see the entire logcat on device. The outline is looking correct so I believe the error is someplace else and logcat will show that.

au...@google.com <au...@google.com> #4Oct 17, 2022 06:17PM

I shared the APK and instructions to reproduce over email. Let me know if you have any trouble reproing the crash.

au...@google.com <au...@google.com> #5Oct 21, 2022 01:00AM

Thank you for the dump and information. Turns out that behavior of the verifier changed on Android 11 and 12 but was reverted again. I am working on a fix that should be easy to merge to the 4.0 branch.

Note that the verification error is actually also easy to create by manual outlining, but our pattern just emphasize it.

au...@google.com <au...@google.com> #6Oct 21, 2022 01:15AM

Project: r8
Branch: main

commit b7b22190797c9b74218fb1d2fdfb497a9be9fb3b
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Mar 20 13:03:38 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

Change-Id: I2479d669217d90f057fa248fcea0f0f27faf91a6

M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
M src/main/java/com/android/tools/r8/ir/code/Return.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java
M src/main/java/com/android/tools/r8/ir/desugar/apimodel/ApiInvokeOutlinerDesugaring.java
A src/main/java/com/android/tools/r8/ir/optimize/RemoveVerificationErrorForUnknownReturnedValues.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelManualOutlineWithUnknownReturnTypeTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineHorizontalMergingTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineInstanceInitializerTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineWithUnknownReturnTypeTest.java

https://r8-review.googlesource.com/77221

au...@google.com <au...@google.com> #7Oct 21, 2022 01:28AM

Project: r8
Branch: main

commit 88dd6ed0006725301bcbe88942e474569c9aa1b1
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Mar 20 12:43:54 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

Change-Id: I5684a12bf42422bb96122422e063ffd0503fb5e5

M src/main/java/com/android/tools/r8/utils/AndroidApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelManualOutlineWithUnknownReturnTypeTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineWithUnknownReturnTypeTest.java

https://r8-review.googlesource.com/77180

au...@google.com <au...@google.com> #8Oct 21, 2022 01:39AM

thanks for the fix. if this can be backported to 4.0 that would be great

sp...@google.com <sp...@google.com> #9Oct 21, 2022 04:55PM

Project: r8
Branch: 8.0

commit e1cdcb66b3a225076a41b646a2684d150a594693
Author: Rico Wind <ricow@google.com>
Date: Tue Mar 21 18:58:29 2023

Version 8.0.39

Bug:

b/272725341

Change-Id: Iad8a15631027cf587871f6c8df12a8b4c601296c

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77428

sp...@google.com <sp...@google.com> #10Oct 21, 2022 11:30PM

Assigned to au...@google.com.

Project: r8
Branch: 8.0

commit 7248df9f87378eda019093887585afba9631a669
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Mar 21 13:59:20 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

https://r8-review.googlesource.com/77425

Bug_253219347_gradle_project_bug.zip

153 KB

Download

au...@google.com <au...@google.com> #11Oct 22, 2022 12:05AM

Project: r8
Branch: 8.0

commit 4c0694de75503094bb84d6e28fd091453b172e2e
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Mar 21 13:59:12 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

https://r8-review.googlesource.com/77424

bug.zip

163 KB

Download

sp...@google.com <sp...@google.com> #12Oct 22, 2022 04:03AM

Project: r8
Branch: 4.0

commit 4fe0ece4d3da01068bf0b63cd7a5f37d47fa6244
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Mar 22 16:30:30 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

https://r8-review.googlesource.com/77496

bug_repro.zip

153 KB

Download

xa...@google.com <xa...@google.com> #13Oct 28, 2022 02:14AM

Reassigned to sp...@google.com.

Project: r8
Branch: 4.0

commit 1e7c88c78ac0636eae649e132b862306ea416d48
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Mar 22 16:30:43 2023

Version 4.0.58

Bug:

b/272725341

Change-Id: If899ee42bdf757985546807d785639e98b3360e6

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77494

sp...@google.com <sp...@google.com> #14Oct 28, 2022 03:07PM

Project: r8
Branch: 4.0

commit b367460c6cab514f9c8c974f2a48e7ed862610de
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Mar 22 16:30:37 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

https://r8-review.googlesource.com/77492

au...@google.com <au...@google.com> #15Oct 28, 2022 04:23PM

I've backported the fix to version 4.0.58. Could you take that version for a spin to see if that solves the issues?

sp...@google.com <sp...@google.com> #16Feb 15, 2023 08:47PM

Marked as fixed.

I verified the fix works. Thanks!

na...@google.com <na...@google.com> #17Jul 26, 2023 05:21PM

Thanks for reporting back and your help with this issue.

Issue 253219347

Description

Issue summary

Comments

sp...@google.com <sp...@google.com> #2Oct 14, 2022 07:39PM

au...@google.com <au...@google.com> #3Oct 17, 2022 04:53PM

au...@google.com <au...@google.com> #4Oct 17, 2022 06:17PM

au...@google.com <au...@google.com> #5Oct 21, 2022 01:00AM

au...@google.com <au...@google.com> #6Oct 21, 2022 01:15AM

au...@google.com <au...@google.com> #7Oct 21, 2022 01:28AM

au...@google.com <au...@google.com> #8Oct 21, 2022 01:39AM

sp...@google.com <sp...@google.com> #9Oct 21, 2022 04:55PM

sp...@google.com <sp...@google.com> #10Oct 21, 2022 11:30PM

au...@google.com <au...@google.com> #11Oct 22, 2022 12:05AM

sp...@google.com <sp...@google.com> #12Oct 22, 2022 04:03AM

xa...@google.com <xa...@google.com> #13Oct 28, 2022 02:14AM

sp...@google.com <sp...@google.com> #14Oct 28, 2022 03:07PM

au...@google.com <au...@google.com> #15Oct 28, 2022 04:23PM

sp...@google.com <sp...@google.com> #16Feb 15, 2023 08:47PM

na...@google.com <na...@google.com> #17Jul 26, 2023 05:21PM

Add comment

Issue metadata